From: Stefan Weil <weil@mail.berlios.de>
To: QEMU Developers <qemu-devel@nongnu.org>
Cc: Blue Swirl <blauwirbel@gmail.com>, Kevin Wolf <kwolf@redhat.com>
Subject: [Qemu-devel] [PATCH] block: Use GCC_FMT_ATTR and fix a format error
Date: Thu, 23 Sep 2010 20:37:11 +0200 [thread overview]
Message-ID: <1285267031-22966-1-git-send-email-weil@mail.berlios.de> (raw)
Adding the gcc format attribute detects a format bug
which is fixed here.
Cc: Blue Swirl <blauwirbel@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
block/blkverify.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/block/blkverify.c b/block/blkverify.c
index 8083464..b39fb67 100644
--- a/block/blkverify.c
+++ b/block/blkverify.c
@@ -53,7 +53,8 @@ static AIOPool blkverify_aio_pool = {
.cancel = blkverify_aio_cancel,
};
-static void blkverify_err(BlkverifyAIOCB *acb, const char *fmt, ...)
+static void GCC_FMT_ATTR(2, 3) blkverify_err(BlkverifyAIOCB *acb,
+ const char *fmt, ...)
{
va_list ap;
@@ -300,7 +301,7 @@ static void blkverify_verify_readv(BlkverifyAIOCB *acb)
ssize_t offset = blkverify_iovec_compare(acb->qiov, &acb->raw_qiov);
if (offset != -1) {
blkverify_err(acb, "contents mismatch in sector %ld",
- acb->sector_num + (offset / BDRV_SECTOR_SIZE));
+ (long)(acb->sector_num + (offset / BDRV_SECTOR_SIZE)));
}
}
--
1.7.1
next reply other threads:[~2010-09-23 18:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-23 18:37 Stefan Weil [this message]
2010-09-23 18:53 ` [Qemu-devel] Re: [PATCH] block: Use GCC_FMT_ATTR and fix a format error Blue Swirl
2010-09-23 19:03 ` Stefan Weil
2010-09-23 19:11 ` Stefan Weil
2010-09-23 20:24 ` Blue Swirl
2010-09-23 21:23 ` Stefan Weil
2010-09-24 19:02 ` [Qemu-devel] " Stefan Weil
2010-09-25 8:01 ` [Qemu-devel] " Blue Swirl
2010-09-25 11:59 ` Stefan Weil
2010-10-13 19:06 ` Stefan Weil
2010-10-14 8:11 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285267031-22966-1-git-send-email-weil@mail.berlios.de \
--to=weil@mail.berlios.de \
--cc=blauwirbel@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).