From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=45133 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oyqfr-0000fc-97 for qemu-devel@nongnu.org; Thu, 23 Sep 2010 14:37:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Oyqfo-0003US-Mc for qemu-devel@nongnu.org; Thu, 23 Sep 2010 14:37:39 -0400 Received: from moutng.kundenserver.de ([212.227.17.8]:53175) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oyqfo-0003Sz-9U for qemu-devel@nongnu.org; Thu, 23 Sep 2010 14:37:36 -0400 From: Stefan Weil Date: Thu, 23 Sep 2010 20:37:11 +0200 Message-Id: <1285267031-22966-1-git-send-email-weil@mail.berlios.de> Subject: [Qemu-devel] [PATCH] block: Use GCC_FMT_ATTR and fix a format error List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: QEMU Developers Cc: Blue Swirl , Kevin Wolf Adding the gcc format attribute detects a format bug which is fixed here. Cc: Blue Swirl Cc: Kevin Wolf Signed-off-by: Stefan Weil --- block/blkverify.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/block/blkverify.c b/block/blkverify.c index 8083464..b39fb67 100644 --- a/block/blkverify.c +++ b/block/blkverify.c @@ -53,7 +53,8 @@ static AIOPool blkverify_aio_pool = { .cancel = blkverify_aio_cancel, }; -static void blkverify_err(BlkverifyAIOCB *acb, const char *fmt, ...) +static void GCC_FMT_ATTR(2, 3) blkverify_err(BlkverifyAIOCB *acb, + const char *fmt, ...) { va_list ap; @@ -300,7 +301,7 @@ static void blkverify_verify_readv(BlkverifyAIOCB *acb) ssize_t offset = blkverify_iovec_compare(acb->qiov, &acb->raw_qiov); if (offset != -1) { blkverify_err(acb, "contents mismatch in sector %ld", - acb->sector_num + (offset / BDRV_SECTOR_SIZE)); + (long)(acb->sector_num + (offset / BDRV_SECTOR_SIZE))); } } -- 1.7.1