From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=55396 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oyqpk-0004iW-2b for qemu-devel@nongnu.org; Thu, 23 Sep 2010 14:47:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OyqpW-0005D0-8Q for qemu-devel@nongnu.org; Thu, 23 Sep 2010 14:47:40 -0400 Received: from moutng.kundenserver.de ([212.227.126.187]:49943) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OyqpV-0005CM-SV for qemu-devel@nongnu.org; Thu, 23 Sep 2010 14:47:38 -0400 From: Stefan Weil Date: Thu, 23 Sep 2010 20:47:32 +0200 Message-Id: <1285267652-24454-1-git-send-email-weil@mail.berlios.de> Subject: [Qemu-devel] [PATCH] blockdev: Use GCC_FMT_ATTR (format checking) List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: QEMU Developers Cc: Blue Swirl , Kevin Wolf Additional changes: * Removed 'extern' from drive_add (avoids too long line). * Removed 'extern' from other functions (makes declarations consistent with others in same header file). Cc: Blue Swirl Cc: Kevin Wolf Signed-off-by: Stefan Weil --- blockdev.h | 15 +++++++-------- 1 files changed, 7 insertions(+), 8 deletions(-) diff --git a/blockdev.h b/blockdev.h index 89dcd9a..653affc 100644 --- a/blockdev.h +++ b/blockdev.h @@ -34,14 +34,13 @@ struct DriveInfo { #define MAX_IDE_DEVS 2 #define MAX_SCSI_DEVS 7 -extern DriveInfo *drive_get(BlockInterfaceType type, int bus, int unit); -extern int drive_get_max_bus(BlockInterfaceType type); -extern void drive_uninit(DriveInfo *dinfo); -extern DriveInfo *drive_get_by_blockdev(BlockDriverState *bs); - -extern QemuOpts *drive_add(const char *file, const char *fmt, ...); -extern DriveInfo *drive_init(QemuOpts *arg, int default_to_scsi, - int *fatal_error); +DriveInfo *drive_get(BlockInterfaceType type, int bus, int unit); +int drive_get_max_bus(BlockInterfaceType type); +void drive_uninit(DriveInfo *dinfo); +DriveInfo *drive_get_by_blockdev(BlockDriverState *bs); + +QemuOpts *drive_add(const char *file, const char *fmt, ...) GCC_FMT_ATTR(2, 3); +DriveInfo *drive_init(QemuOpts *arg, int default_to_scsi, int *fatal_error); /* device-hotplug */ -- 1.7.1