From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Paul Brook <paul@codesourcery.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
Kevin Wolf <kwolf@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>
Cc: kvm-devel <kvm@vger.kernel.org>,
qemu-devel <qemu-devel@nongnu.org>,
Nicholas Bellinger <nab@linux-iscsi.org>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
Hannes Reinecke <hare@suse.de>,
Matthew Wilcox <willy@linux.intel.com>
Subject: [Qemu-devel] [PATCH] scsi-generic: Add reset handler
Date: Wed, 29 Sep 2010 22:07:25 -0700 [thread overview]
Message-ID: <1285823246-6680-1-git-send-email-nab@linux-iscsi.org> (raw)
From: Nicholas Bellinger <nab@linux-iscsi.org>
This patch adds NOP scsi_generic_reset() caller to fix an OOPs
which is expected to be set by hw/lsi53895a.c code for both
scsi-disk and scsi-generic operation.
Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi.org>
---
hw/scsi-generic.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/hw/scsi-generic.c b/hw/scsi-generic.c
index 1bb26e7..176fcaf 100644
--- a/hw/scsi-generic.c
+++ b/hw/scsi-generic.c
@@ -379,6 +379,11 @@ static int scsi_generic_initfn(SCSIDevice *dev)
return 0;
}
+static void scsi_generic_reset(DeviceState *dev)
+{
+ DPRINTF("scsi_generic_reset\n");
+}
+
static void scsi_generic_unmap(SCSIGenericReq *r)
{
int is_write = !scsi_req_is_write(&r->req);
@@ -552,6 +557,7 @@ static SCSIDeviceInfo scsi_generic_info = {
.qdev.name = "scsi-generic",
.qdev.desc = "pass through generic scsi device (/dev/sg*)",
.qdev.size = sizeof(SCSIGenericState),
+ .qdev.reset = scsi_generic_reset,
.init = scsi_generic_initfn,
.destroy = scsi_destroy,
--
1.5.6.5
reply other threads:[~2010-09-30 5:07 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285823246-6680-1-git-send-email-nab@linux-iscsi.org \
--to=nab@linux-iscsi.org \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=hare@suse.de \
--cc=jan.kiszka@siemens.com \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).