* [Qemu-devel] [PATCH] block/vvfat: Fix compiler warning in debug code
@ 2010-09-30 19:15 Stefan Weil
2010-10-03 7:50 ` [Qemu-devel] " Blue Swirl
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Weil @ 2010-09-30 19:15 UTC (permalink / raw)
To: QEMU Developers; +Cc: Blue Swirl, Kevin Wolf
Fix this compiler warning:
./block/vvfat.c:2285: error: comparison of unsigned expression >= 0 is always true
Cc: Blue Swirl <blauwirbel@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
block/vvfat.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/block/vvfat.c b/block/vvfat.c
index 53e57bf..26dd474 100644
--- a/block/vvfat.c
+++ b/block/vvfat.c
@@ -2282,7 +2282,6 @@ static void check1(BDRVVVFATState* s)
fprintf(stderr, "deleted\n");
continue;
}
- assert(mapping->dir_index >= 0);
assert(mapping->dir_index < s->directory.next);
direntry_t* direntry = array_get(&(s->directory), mapping->dir_index);
assert(mapping->begin == begin_of_direntry(direntry) || mapping->first_mapping_index >= 0);
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Qemu-devel] Re: [PATCH] block/vvfat: Fix compiler warning in debug code
2010-09-30 19:15 [Qemu-devel] [PATCH] block/vvfat: Fix compiler warning in debug code Stefan Weil
@ 2010-10-03 7:50 ` Blue Swirl
0 siblings, 0 replies; 2+ messages in thread
From: Blue Swirl @ 2010-10-03 7:50 UTC (permalink / raw)
To: Stefan Weil; +Cc: Kevin Wolf, QEMU Developers
Thanks, applied.
On Thu, Sep 30, 2010 at 7:15 PM, Stefan Weil <weil@mail.berlios.de> wrote:
> Fix this compiler warning:
> ./block/vvfat.c:2285: error: comparison of unsigned expression >= 0 is always true
>
> Cc: Blue Swirl <blauwirbel@gmail.com>
> Cc: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
> block/vvfat.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/block/vvfat.c b/block/vvfat.c
> index 53e57bf..26dd474 100644
> --- a/block/vvfat.c
> +++ b/block/vvfat.c
> @@ -2282,7 +2282,6 @@ static void check1(BDRVVVFATState* s)
> fprintf(stderr, "deleted\n");
> continue;
> }
> - assert(mapping->dir_index >= 0);
> assert(mapping->dir_index < s->directory.next);
> direntry_t* direntry = array_get(&(s->directory), mapping->dir_index);
> assert(mapping->begin == begin_of_direntry(direntry) || mapping->first_mapping_index >= 0);
> --
> 1.7.1
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-10-03 7:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-30 19:15 [Qemu-devel] [PATCH] block/vvfat: Fix compiler warning in debug code Stefan Weil
2010-10-03 7:50 ` [Qemu-devel] " Blue Swirl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).