qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Weil <weil@mail.berlios.de>
To: QEMU Developers <qemu-devel@nongnu.org>
Cc: Blue Swirl <blauwirbel@gmail.com>
Subject: [Qemu-devel] [PATCH] ds1225y: Fix compiler errors in debug code
Date: Thu, 30 Sep 2010 21:30:19 +0200	[thread overview]
Message-ID: <1285875019-14246-1-git-send-email-weil@mail.berlios.de> (raw)

TARGET_FMT_lx is not allowed here, so use type casts to unsigned
(which should be large enough to hold typical nvram addresses).

./hw/ds1225y.c:48:35: error: attempt to use poisoned "TARGET_FMT_lx"
./hw/ds1225y.c: In function ‘nvram_readb’:
./hw/ds1225y.c:48: error: expected ‘)’ before ‘TARGET_FMT_lx’
./hw/ds1225y.c:48: error: too few arguments for format
./hw/ds1225y.c:76:36: error: attempt to use poisoned "TARGET_FMT_lx"
./hw/ds1225y.c: In function ‘nvram_writeb’:
./hw/ds1225y.c:76: error: expected ‘)’ before ‘TARGET_FMT_lx’
./hw/ds1225y.c:76: error: too few arguments for format
./hw/ds1225y.c:107:47: error: attempt to use poisoned "TARGET_FMT_lx"
./hw/ds1225y.c: In function ‘nvram_writeb_protected’:
./hw/ds1225y.c:107: error: expected ‘)’ before ‘TARGET_FMT_lx’
./hw/ds1225y.c:107: error: too few arguments for format

Cc: Blue Swirl <blauwirbel@gmail.com>
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
 hw/ds1225y.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/hw/ds1225y.c b/hw/ds1225y.c
index 009d127..381ca65 100644
--- a/hw/ds1225y.c
+++ b/hw/ds1225y.c
@@ -45,7 +45,7 @@ static uint32_t nvram_readb (void *opaque, target_phys_addr_t addr)
     val = s->contents[addr];
 
 #ifdef DEBUG_NVRAM
-    printf("nvram: read 0x%x at " TARGET_FMT_lx "\n", val, addr);
+    printf("nvram: read 0x%x at %08x\n", val, (unsigned)addr);
 #endif
     return val;
 }
@@ -73,7 +73,7 @@ static void nvram_writeb (void *opaque, target_phys_addr_t addr, uint32_t val)
     ds1225y_t *s = opaque;
 
 #ifdef DEBUG_NVRAM
-    printf("nvram: write 0x%x at " TARGET_FMT_lx "\n", val, addr);
+    printf("nvram: write 0x%x at %08x\n", val, (unsigned)addr);
 #endif
 
     s->contents[addr] = val & 0xff;
@@ -104,7 +104,7 @@ static void nvram_writeb_protected (void *opaque, target_phys_addr_t addr, uint3
 
     if (s->protection != 7) {
 #ifdef DEBUG_NVRAM
-    printf("nvram: prevent write of 0x%x at " TARGET_FMT_lx "\n", val, addr);
+    printf("nvram: prevent write of 0x%x at %08x\n", val, (unsigned)addr);
 #endif
         return;
     }
-- 
1.7.1

             reply	other threads:[~2010-09-30 19:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-30 19:30 Stefan Weil [this message]
2010-09-30 19:37 ` [Qemu-devel] Re: [PATCH] ds1225y: Fix compiler errors in debug code Blue Swirl
2010-09-30 19:55   ` Stefan Weil
2010-09-30 20:09     ` Blue Swirl
2010-09-30 20:22       ` Stefan Weil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1285875019-14246-1-git-send-email-weil@mail.berlios.de \
    --to=weil@mail.berlios.de \
    --cc=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).