* [Qemu-devel] [PATCH] rc4030: Fix compilation error in debug code
@ 2010-09-30 20:05 Stefan Weil
2010-10-03 7:51 ` [Qemu-devel] " Blue Swirl
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Weil @ 2010-09-30 20:05 UTC (permalink / raw)
To: QEMU Developers; +Cc: Blue Swirl
min was unknown here, so avoid it.
Cc: Blue Swirl <blauwirbel@gmail.com>
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
hw/rc4030.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/hw/rc4030.c b/hw/rc4030.c
index 2231373..abbc3eb 100644
--- a/hw/rc4030.c
+++ b/hw/rc4030.c
@@ -749,7 +749,10 @@ static void rc4030_do_dma(void *opaque, int n, uint8_t *buf, int len, int is_wri
printf("rc4030 dma: Copying %d bytes %s host %p\n",
len, is_write ? "from" : "to", buf);
for (i = 0; i < len; i += 16) {
- int n = min(16, len - i);
+ int n = 16;
+ if (n > len - i) {
+ n = len - i;
+ }
for (j = 0; j < n; j++)
printf("%02x ", buf[i + j]);
while (j++ < 16)
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Qemu-devel] Re: [PATCH] rc4030: Fix compilation error in debug code
2010-09-30 20:05 [Qemu-devel] [PATCH] rc4030: Fix compilation error in debug code Stefan Weil
@ 2010-10-03 7:51 ` Blue Swirl
0 siblings, 0 replies; 2+ messages in thread
From: Blue Swirl @ 2010-10-03 7:51 UTC (permalink / raw)
To: Stefan Weil; +Cc: QEMU Developers
Thanks, applied.
On Thu, Sep 30, 2010 at 8:05 PM, Stefan Weil <weil@mail.berlios.de> wrote:
> min was unknown here, so avoid it.
>
> Cc: Blue Swirl <blauwirbel@gmail.com>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
> hw/rc4030.c | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/hw/rc4030.c b/hw/rc4030.c
> index 2231373..abbc3eb 100644
> --- a/hw/rc4030.c
> +++ b/hw/rc4030.c
> @@ -749,7 +749,10 @@ static void rc4030_do_dma(void *opaque, int n, uint8_t *buf, int len, int is_wri
> printf("rc4030 dma: Copying %d bytes %s host %p\n",
> len, is_write ? "from" : "to", buf);
> for (i = 0; i < len; i += 16) {
> - int n = min(16, len - i);
> + int n = 16;
> + if (n > len - i) {
> + n = len - i;
> + }
> for (j = 0; j < n; j++)
> printf("%02x ", buf[i + j]);
> while (j++ < 16)
> --
> 1.7.1
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-10-03 7:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-30 20:05 [Qemu-devel] [PATCH] rc4030: Fix compilation error in debug code Stefan Weil
2010-10-03 7:51 ` [Qemu-devel] " Blue Swirl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).