* [Qemu-devel] [PATCH] acpi: Fix an infinite loop in acpi_table_add
@ 2010-10-05 0:23 Vincent Minet
2010-10-07 9:15 ` Jes Sorensen
2010-10-09 9:42 ` Blue Swirl
0 siblings, 2 replies; 3+ messages in thread
From: Vincent Minet @ 2010-10-05 0:23 UTC (permalink / raw)
To: qemu-devel
Commit d729bb9a7700e364b1c5f9893d61f07a9e002bce has a typo, causing an
infinite loop in acpi_table_add.
Signed-off-by: Vincent Minet <vincent@vincent-minet.net>
---
hw/acpi.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/acpi.c b/hw/acpi.c
index 069e05f..8071e7b 100644
--- a/hw/acpi.c
+++ b/hw/acpi.c
@@ -161,7 +161,7 @@ int acpi_table_add(const char *t)
/* off < length is necessary because file size can be changed
under our foot */
- while(s.st_size && off < length); {
+ while(s.st_size && off < length) {
int r;
r = read(fd, p + off, s.st_size);
if (r > 0) {
--
1.7.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] acpi: Fix an infinite loop in acpi_table_add
2010-10-05 0:23 [Qemu-devel] [PATCH] acpi: Fix an infinite loop in acpi_table_add Vincent Minet
@ 2010-10-07 9:15 ` Jes Sorensen
2010-10-09 9:42 ` Blue Swirl
1 sibling, 0 replies; 3+ messages in thread
From: Jes Sorensen @ 2010-10-07 9:15 UTC (permalink / raw)
To: Vincent Minet; +Cc: qemu-devel
On 10/05/10 02:23, Vincent Minet wrote:
> Commit d729bb9a7700e364b1c5f9893d61f07a9e002bce has a typo, causing an
> infinite loop in acpi_table_add.
>
> Signed-off-by: Vincent Minet <vincent@vincent-minet.net>
> ---
> hw/acpi.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
OUCH!
Good catch!
Acked-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Jes
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] acpi: Fix an infinite loop in acpi_table_add
2010-10-05 0:23 [Qemu-devel] [PATCH] acpi: Fix an infinite loop in acpi_table_add Vincent Minet
2010-10-07 9:15 ` Jes Sorensen
@ 2010-10-09 9:42 ` Blue Swirl
1 sibling, 0 replies; 3+ messages in thread
From: Blue Swirl @ 2010-10-09 9:42 UTC (permalink / raw)
To: Vincent Minet; +Cc: qemu-devel
Thanks, applied.
On Tue, Oct 5, 2010 at 12:23 AM, Vincent Minet
<vincent@vincent-minet.net> wrote:
> Commit d729bb9a7700e364b1c5f9893d61f07a9e002bce has a typo, causing an
> infinite loop in acpi_table_add.
>
> Signed-off-by: Vincent Minet <vincent@vincent-minet.net>
> ---
> hw/acpi.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/acpi.c b/hw/acpi.c
> index 069e05f..8071e7b 100644
> --- a/hw/acpi.c
> +++ b/hw/acpi.c
> @@ -161,7 +161,7 @@ int acpi_table_add(const char *t)
>
> /* off < length is necessary because file size can be changed
> under our foot */
> - while(s.st_size && off < length); {
> + while(s.st_size && off < length) {
> int r;
> r = read(fd, p + off, s.st_size);
> if (r > 0) {
> --
> 1.7.3.1
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-10-09 9:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-05 0:23 [Qemu-devel] [PATCH] acpi: Fix an infinite loop in acpi_table_add Vincent Minet
2010-10-07 9:15 ` Jes Sorensen
2010-10-09 9:42 ` Blue Swirl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).