qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jes.Sorensen@redhat.com
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, armbru@redhat.com
Subject: [Qemu-devel] [PATCH 5/6] Switch migrate_set_speed() to take an 'o' argument rather than a float.
Date: Thu,  7 Oct 2010 17:01:49 +0200	[thread overview]
Message-ID: <1286463710-28262-6-git-send-email-Jes.Sorensen@redhat.com> (raw)
In-Reply-To: <1286463710-28262-1-git-send-email-Jes.Sorensen@redhat.com>

From: Jes Sorensen <Jes.Sorensen@redhat.com>

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
---
 hmp-commands.hx |    2 +-
 migration.c     |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/hmp-commands.hx b/hmp-commands.hx
index 81999aa..95bdb91 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -754,7 +754,7 @@ ETEXI
 
     {
         .name       = "migrate_set_speed",
-        .args_type  = "value:f",
+        .args_type  = "value:o",
         .params     = "value",
         .help       = "set maximum speed (in bytes) for migrations",
         .user_print = monitor_user_noop,
diff --git a/migration.c b/migration.c
index 468d517..9ee8b17 100644
--- a/migration.c
+++ b/migration.c
@@ -132,10 +132,10 @@ int do_migrate_cancel(Monitor *mon, const QDict *qdict, QObject **ret_data)
 
 int do_migrate_set_speed(Monitor *mon, const QDict *qdict, QObject **ret_data)
 {
-    double d;
+    int64_t d;
     FdMigrationState *s;
 
-    d = qdict_get_double(qdict, "value");
+    d = qdict_get_int(qdict, "value");
     d = MAX(0, MIN(UINT32_MAX, d));
     max_throttle = d;
 
-- 
1.7.2.3

  parent reply	other threads:[~2010-10-07 15:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-07 15:01 [Qemu-devel] [PATCH v3 0/6] Introduce strtosz and make use of it Jes.Sorensen
2010-10-07 15:01 ` [Qemu-devel] [PATCH 1/6] Introduce strtosz() library function to convert a string to a byte count Jes.Sorensen
2010-10-07 15:01 ` [Qemu-devel] [PATCH 2/6] Support human unit formats in strtosz, eg. 1.0G Jes.Sorensen
2010-10-07 15:01 ` [Qemu-devel] [PATCH 3/6] Add more error handling to strtosz() Jes.Sorensen
2010-10-07 15:52   ` [Qemu-devel] " Paolo Bonzini
2010-10-07 15:01 ` [Qemu-devel] [PATCH 4/6] Add support for 'o' octet (bytes) format as monitor parameter Jes.Sorensen
2010-10-07 15:01 ` Jes.Sorensen [this message]
2010-10-07 16:03   ` [Qemu-devel] Re: [PATCH 5/6] Switch migrate_set_speed() to take an 'o' argument rather than a float Paolo Bonzini
2010-10-08  8:50     ` Jes Sorensen
2010-10-07 15:01 ` [Qemu-devel] [PATCH 6/6] Remove obsolete 'f' double parameter type Jes.Sorensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1286463710-28262-6-git-send-email-Jes.Sorensen@redhat.com \
    --to=jes.sorensen@redhat.com \
    --cc=armbru@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).