[Qemu-devel] [PATCH] configure: Send error message from spice check to /dev/null

[Qemu-devel] [PATCH] configure: Send error message from spice check to /dev/null

[Stefan Weil]

pkg-config is not always available (e.g. on win32 hosts),
but we don't want to see the 'command not found' error message.

Redirect stdout and stderr to /dev/null.

Cc: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
 configure |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/configure b/configure
index e67d076..2d06d87 100755
--- a/configure
+++ b/configure
@@ -21,6 +21,9 @@ trap "rm -f $TMPC $TMPO $TMPE" EXIT INT QUIT TERM
 rm -f config.log
 
 compile_object() {
+  echo >>config.log
+  cat $TMPC >>config.log
+  echo >>config.log
   echo $cc $QEMU_CFLAGS -c -o $TMPO $TMPC >> config.log
   $cc $QEMU_CFLAGS -c -o $TMPO $TMPC >> config.log 2>&1
 }
@@ -28,6 +31,9 @@ compile_object() {
 compile_prog() {
   local_cflags="$1"
   local_ldflags="$2"
+  echo >>config.log
+  cat $TMPC >>config.log
+  echo >>config.log
   echo $cc $QEMU_CFLAGS $local_cflags -o $TMPE $TMPC $LDFLAGS $local_ldflags >> config.log
   $cc $QEMU_CFLAGS $local_cflags -o $TMPE $TMPC $LDFLAGS $local_ldflags >> config.log 2>&1
 }
@@ -2089,7 +2095,7 @@ int main(void) { spice_server_new(); return 0; }
 EOF
   spice_cflags=$($pkgconfig --cflags spice-protocol spice-server 2>/dev/null)
   spice_libs=$($pkgconfig --libs spice-protocol spice-server 2>/dev/null)
-  if $pkgconfig --atleast-version=0.5.3 spice-server &&\
+  if $pkgconfig --atleast-version=0.5.3 spice-server >/dev/null 2>&1 && \
      compile_prog "$spice_cflags" "$spice_libs" ; then
     spice="yes"
     libs_softmmu="$libs_softmmu $spice_libs"
-- 
1.7.1

[Qemu-devel] Re: [PATCH] configure: Send error message from spice check to /dev/null

[Gerd Hoffmann]

On 10/07/10 17:58, Stefan Weil wrote:
> pkg-config is not always available (e.g. on win32 hosts),
> but we don't want to see the 'command not found' error message.

>   compile_object() {
> +  echo>>config.log
> +  cat $TMPC>>config.log
> +  echo>>config.log

This looks unrelated.

> @@ -28,6 +31,9 @@ compile_object() {
>   compile_prog() {
>     local_cflags="$1"
>     local_ldflags="$2"
> +  echo>>config.log
> +  cat $TMPC>>config.log
> +  echo>>config.log

This too.

>     spice_cflags=$($pkgconfig --cflags spice-protocol spice-server 2>/dev/null)
>     spice_libs=$($pkgconfig --libs spice-protocol spice-server 2>/dev/null)
> -  if $pkgconfig --atleast-version=0.5.3 spice-server&&\
> +  if $pkgconfig --atleast-version=0.5.3 spice-server>/dev/null 2>&1&&  \

Fine with me, the other pkgconfig calls are covered already, the third 
missing is just an oversight and the fix is ObliviouslyCorrect[tm].

cheers,
   Gerd

[Qemu-devel] Re: [PATCH] configure: Send error message from spice check to /dev/null

[Stefan Weil]

Am 07.10.2010 21:05, schrieb Gerd Hoffmann:
> On 10/07/10 17:58, Stefan Weil wrote:
>> pkg-config is not always available (e.g. on win32 hosts),
>> but we don't want to see the 'command not found' error message.
>
>>   compile_object() {
>> +  echo>>config.log
>> +  cat $TMPC>>config.log
>> +  echo>>config.log
>
> This looks unrelated.

Ups, that was the wrong patch (some test code).
Sorry - I'll fix that immediately.

Thanks for your feedback.

>
>> @@ -28,6 +31,9 @@ compile_object() {
>>   compile_prog() {
>>     local_cflags="$1"
>>     local_ldflags="$2"
>> +  echo>>config.log
>> +  cat $TMPC>>config.log
>> +  echo>>config.log
>
> This too.
>
>>     spice_cflags=$($pkgconfig --cflags spice-protocol spice-server 
>> 2>/dev/null)
>>     spice_libs=$($pkgconfig --libs spice-protocol spice-server 
>> 2>/dev/null)
>> -  if $pkgconfig --atleast-version=0.5.3 spice-server&&\
>> +  if $pkgconfig --atleast-version=0.5.3 spice-server>/dev/null 
>> 2>&1&&  \
>
> Fine with me, the other pkgconfig calls are covered already, the third 
> missing is just an oversight and the fix is ObliviouslyCorrect[tm].
>
> cheers,
>   Gerd
>
>

[Qemu-devel] [PATCH v2] configure: Send error message from spice check to /dev/null

[Stefan Weil]

pkg-config is not always available (e.g. on win32 hosts),
but we don't want to see the 'command not found' error message.

Redirect stdout and stderr to /dev/null.

v2:

* Removed changes which should not have been here.

Cc: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
 configure |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/configure b/configure
index e67d076..cc19d82 100755
--- a/configure
+++ b/configure
@@ -2089,7 +2089,7 @@ int main(void) { spice_server_new(); return 0; }
 EOF
   spice_cflags=$($pkgconfig --cflags spice-protocol spice-server 2>/dev/null)
   spice_libs=$($pkgconfig --libs spice-protocol spice-server 2>/dev/null)
-  if $pkgconfig --atleast-version=0.5.3 spice-server &&\
+  if $pkgconfig --atleast-version=0.5.3 spice-server >/dev/null 2>&1 && \
      compile_prog "$spice_cflags" "$spice_libs" ; then
     spice="yes"
     libs_softmmu="$libs_softmmu $spice_libs"
-- 
1.7.1

Re: [Qemu-devel] [PATCH v2] configure: Send error message from spice check to /dev/null

[Blue Swirl]

Thanks, applied.

On Thu, Oct 7, 2010 at 7:15 PM, Stefan Weil <weil@mail.berlios.de> wrote:
> pkg-config is not always available (e.g. on win32 hosts),
> but we don't want to see the 'command not found' error message.
>
> Redirect stdout and stderr to /dev/null.
>
> v2:
>
> * Removed changes which should not have been here.
>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
>  configure |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/configure b/configure
> index e67d076..cc19d82 100755
> --- a/configure
> +++ b/configure
> @@ -2089,7 +2089,7 @@ int main(void) { spice_server_new(); return 0; }
>  EOF
>   spice_cflags=$($pkgconfig --cflags spice-protocol spice-server 2>/dev/null)
>   spice_libs=$($pkgconfig --libs spice-protocol spice-server 2>/dev/null)
> -  if $pkgconfig --atleast-version=0.5.3 spice-server &&\
> +  if $pkgconfig --atleast-version=0.5.3 spice-server >/dev/null 2>&1 && \
>      compile_prog "$spice_cflags" "$spice_libs" ; then
>     spice="yes"
>     libs_softmmu="$libs_softmmu $spice_libs"
> --
> 1.7.1
>
>
>