From: Jes.Sorensen@redhat.com
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, armbru@redhat.com
Subject: [Qemu-devel] [PATCH 2/7] Support human unit formats in strtosz, eg. 1.0G
Date: Fri, 8 Oct 2010 11:15:55 +0200 [thread overview]
Message-ID: <1286529360-5715-3-git-send-email-Jes.Sorensen@redhat.com> (raw)
In-Reply-To: <1286529360-5715-1-git-send-email-Jes.Sorensen@redhat.com>
From: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
---
cutils.c | 34 ++++++++++++++++++++++++++--------
1 files changed, 26 insertions(+), 8 deletions(-)
diff --git a/cutils.c b/cutils.c
index ee591c5..0782032 100644
--- a/cutils.c
+++ b/cutils.c
@@ -291,34 +291,52 @@ int fcntl_setfl(int fd, int flag)
*/
ssize_t strtosz(const char *nptr, char **end)
{
- int64_t value;
+ ssize_t retval = -1;
char *endptr;
+ int mul_required = 0;
+ double val, mul = 1;
+
+ endptr = (char *)nptr + strspn(nptr, " 0123456789");
+ if (*endptr == '.') {
+ mul_required = 1;
+ }
+
+ val = strtod(nptr, &endptr);
+
+ if (val < 0)
+ goto fail;
- value = strtoll(nptr, &endptr, 0);
switch (*endptr++) {
case 'K':
case 'k':
- value <<= 10;
+ mul = 1 << 10;
break;
case 0:
+ case ' ':
+ if (mul_required) {
+ goto fail;
+ }
case 'M':
case 'm':
- value <<= 20;
+ mul = 1ULL << 20;
break;
case 'G':
case 'g':
- value <<= 30;
+ mul = 1ULL << 30;
break;
case 'T':
case 't':
- value <<= 40;
+ mul = 1ULL << 40;
break;
default:
- value = -1;
+ goto fail;
}
+ retval = (ssize_t)(val * mul);
+
if (end)
*end = endptr;
- return value;
+fail:
+ return retval;
}
--
1.7.2.3
next prev parent reply other threads:[~2010-10-08 9:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-08 9:15 [Qemu-devel] [PATCH v4 0/7] Introduce strtosz and make use of it Jes.Sorensen
2010-10-08 9:15 ` [Qemu-devel] [PATCH 1/7] Introduce strtosz() library function to convert a string to a byte count Jes.Sorensen
2010-10-11 8:51 ` Markus Armbruster
2010-10-11 12:45 ` Jes Sorensen
2010-10-11 14:39 ` Markus Armbruster
2010-10-08 9:15 ` Jes.Sorensen [this message]
2010-10-08 9:37 ` [Qemu-devel] [PATCH 2/7] Support human unit formats in strtosz, eg. 1.0G Stefan Weil
2010-10-08 9:15 ` [Qemu-devel] [PATCH 3/7] Add more error handling to strtosz() Jes.Sorensen
2010-10-08 9:38 ` Stefan Weil
2010-10-08 9:15 ` [Qemu-devel] [PATCH 4/7] Add support for 'o' octet (bytes) format as monitor parameter Jes.Sorensen
2010-10-08 9:15 ` [Qemu-devel] [PATCH 5/7] Switch migrate_set_speed() to take an 'o' argument rather than a float Jes.Sorensen
2010-10-11 9:03 ` Markus Armbruster
2010-10-11 9:26 ` Paolo Bonzini
2010-10-11 9:58 ` Jes Sorensen
2010-10-08 9:15 ` [Qemu-devel] [PATCH 6/7] Clarify default values in migration speed argument in monitor Jes.Sorensen
2010-10-08 16:21 ` [Qemu-devel] " Paolo Bonzini
2010-10-11 6:45 ` Jes Sorensen
2010-10-08 9:16 ` [Qemu-devel] [PATCH 7/7] Remove obsolete 'f' double parameter type Jes.Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286529360-5715-3-git-send-email-Jes.Sorensen@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).