From: Alex Williamson <alex.williamson@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Jes Sorensen <Jes.Sorensen@redhat.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] Re: [PATCH] pc: e820 qemu_cfg tables need to be packed
Date: Thu, 14 Oct 2010 13:58:08 -0600 [thread overview]
Message-ID: <1287086288.2987.10.camel@x201> (raw)
In-Reply-To: <4CB75EA4.9080004@codemonkey.ws>
On Thu, 2010-10-14 at 14:48 -0500, Anthony Liguori wrote:
> On 10/14/2010 02:44 PM, Jes Sorensen wrote:
> > On 10/14/10 20:33, Alex Williamson wrote:
> >
> >> We can't let the compiler define the alignment for qemu_cfg data.
> >>
> >> Signed-off-by: Alex Williamson<alex.williamson@redhat.com>
> >> ---
> >>
> >> 0.13 stable candidate?
> >>
> > ACK I would say so.
> >
>
> fw_cfg interfaces are somewhat difficult to rationalize about for
> compatibility.
>
> 0.13.0 is tagged already so it's too late to pull it in there. If we
> say we don't care about compatibility at the fw_cfg level, then it
> doesn't matter if we pull it into stable-0.13. If we do care, then this
> is an ABI breaker.
If it works anywhere (I assume it works on 32bit), then it's only
because it happened to get the alignment right. This just makes 64bit
hosts get it right too. I don't see any compatibility issues,
non-packed + 64bit = broken. Thanks,
Alex
next prev parent reply other threads:[~2010-10-14 19:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-14 18:33 [Qemu-devel] [PATCH] pc: e820 qemu_cfg tables need to be packed Alex Williamson
2010-10-14 19:44 ` [Qemu-devel] " Jes Sorensen
2010-10-14 19:48 ` Anthony Liguori
2010-10-14 19:58 ` Alex Williamson [this message]
2010-10-14 19:59 ` Anthony Liguori
2010-10-14 20:20 ` Arnd Bergmann
2010-10-14 20:59 ` Alex Williamson
2010-10-14 21:19 ` Arnd Bergmann
2010-10-15 4:01 ` Alex Williamson
2010-10-15 4:08 ` [Qemu-devel] [PATCH v2] " Alex Williamson
2010-10-15 10:20 ` [Qemu-devel] " Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287086288.2987.10.camel@x201 \
--to=alex.williamson@redhat.com \
--cc=Jes.Sorensen@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).