From: Jes.Sorensen@redhat.com
To: qemu-devel@nongnu.org
Cc: blauwirbel@gmail.com, pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH v3 0/9] Re-factor osdep code + macro and brace fixes
Date: Mon, 18 Oct 2010 10:15:45 +0200 [thread overview]
Message-ID: <1287389754-985-1-git-send-email-Jes.Sorensen@redhat.com> (raw)
From: Jes Sorensen <Jes.Sorensen@redhat.com>
Hi,
Here is another set of patches which tries to split up osdep.c further
into posix and win32 versions. It introduces oslib-{posix,win32}.c
files which are used for functions that are OS specific core library
functionality, like gettimeofday(), and which is used by both QEMU and
support applications like qemu-img. Other functions are moved to
os-{posix,win32}.c. In addtion there are a couple of minor fixes for
bad macro names.
In some cases braces were added to code when it was moved, to make it
compliant with the QEMU bracing rules.
v3 fixes the issues pointed out by Blue Swirl, notably it moves the
win32 ffs prototype to qemu-common.h which is consistent with it being
provided by strings.h for POSIX, and fixes linking of linux-user.
Cheers,
Jes
Jes Sorensen (9):
Move QEMU OS dependant library functions to OS specific files
Move osdep socket code to oslib-{posix,win32}.c
qemu_pipe() is used only by POSIX code, so move to oslib-posix.c
We only support eventfd under POSIX, move qemu_eventfd() to
os-posix.c
Move qemu_gettimeofday() to OS specific files
Do not redefine reserved key-words TRUE/FALSE
Separate qemu_pidfile() into OS specific versions
Consolidate oom_check() functions
Remove unncessary includes
Makefile | 6 +-
Makefile.objs | 9 ++-
Makefile.target | 2 +-
hw/bt-sdp.c | 20 ++--
os-posix.c | 53 +++++++++++
os-win32.c | 24 +++++
osdep.c | 256 ----------------------------------------------------
osdep.h | 15 ---
oslib-posix.c | 109 ++++++++++++++++++++++
oslib-win32.c | 121 +++++++++++++++++++++++++
posix-aio-compat.c | 1 +
qemu-common.h | 6 ++
qemu-img.c | 1 +
qemu-malloc.c | 14 +---
qemu-os-posix.h | 3 +
qemu-os-win32.h | 8 ++
qemu-tool.c | 1 +
17 files changed, 352 insertions(+), 297 deletions(-)
create mode 100644 oslib-posix.c
create mode 100644 oslib-win32.c
--
1.7.2.3
next reply other threads:[~2010-10-18 8:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-18 8:15 Jes.Sorensen [this message]
2010-10-18 8:15 ` [Qemu-devel] [PATCH 1/9] Move QEMU OS dependant library functions to OS specific files Jes.Sorensen
2010-10-18 8:15 ` [Qemu-devel] [PATCH 2/9] Move osdep socket code to oslib-{posix, win32}.c Jes.Sorensen
2010-10-18 8:15 ` [Qemu-devel] [PATCH 3/9] qemu_pipe() is used only by POSIX code, so move to oslib-posix.c Jes.Sorensen
2010-10-18 8:15 ` [Qemu-devel] [PATCH 4/9] We only support eventfd under POSIX, move qemu_eventfd() to os-posix.c Jes.Sorensen
2010-10-18 8:15 ` [Qemu-devel] [PATCH 5/9] Move qemu_gettimeofday() to OS specific files Jes.Sorensen
2010-10-23 14:42 ` [Qemu-devel] " Blue Swirl
2010-10-25 7:39 ` Jes Sorensen
2010-10-25 17:01 ` Blue Swirl
2010-10-18 8:15 ` [Qemu-devel] [PATCH 6/9] Do not redefine reserved key-words TRUE/FALSE Jes.Sorensen
2010-10-18 8:15 ` [Qemu-devel] [PATCH 7/9] Separate qemu_pidfile() into OS specific versions Jes.Sorensen
2010-10-18 8:15 ` [Qemu-devel] [PATCH 8/9] Consolidate oom_check() functions Jes.Sorensen
2010-10-18 8:15 ` [Qemu-devel] [PATCH 9/9] Remove unncessary includes Jes.Sorensen
2010-10-18 9:08 ` [Qemu-devel] Re: [PATCH v3 0/9] Re-factor osdep code + macro and brace fixes Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287389754-985-1-git-send-email-Jes.Sorensen@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).