qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] apic: convert debug printf statements to tracepoints
Date: Mon, 18 Oct 2010 13:42:53 +0100	[thread overview]
Message-ID: <1287405776-19651-1-git-send-email-stefanha@linux.vnet.ibm.com> (raw)
In-Reply-To: <AANLkTinUw8-tGxiNN2K=bz3ZZEFUZrLn=YSHGm2mUWfc@mail.gmail.com>

Thanks for pointing out this problem with simpletrace.py.  There are two
issues:

1. The regular expression used by simpletrace.py to parse trace event
   declarations cannot cope with concatenated string literals.
2. Format strings must begin and end with double quotes.  This was previously
   undocumented but is necessary because cpp is not run over trace-events, so
   parsing the strings and portability macros is non-trivial.

The follow-up patches fix the regex, add documentation for the format string
double quotes requirement, and update your patch.

simpletrace.py should work for the coalesced apic trace events now.

Stefan

  reply	other threads:[~2010-10-18 12:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-17  7:55 [Qemu-devel] [PATCH] apic: convert debug printf statements to tracepoints Blue Swirl
2010-10-18 12:42 ` Stefan Hajnoczi [this message]
2010-10-18 12:42 ` [Qemu-devel] [PATCH 1/3] trace: Relax trace-events parsing regex in simpletrace.py Stefan Hajnoczi
2010-10-20 16:49   ` [Qemu-devel] " Blue Swirl
2010-10-18 12:42 ` [Qemu-devel] [PATCH 2/3] trace: Format strings must begin/end with double quotes Stefan Hajnoczi
2010-10-18 12:42 ` [Qemu-devel] [PATCH 3/3] apic: convert debug printf statements to tracepoints Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1287405776-19651-1-git-send-email-stefanha@linux.vnet.ibm.com \
    --to=stefanha@linux.vnet.ibm.com \
    --cc=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).