From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=33030 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P7p3d-0005wX-5m
	for qemu-devel@nongnu.org; Mon, 18 Oct 2010 08:43:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@linux.vnet.ibm.com>) id 1P7p3U-0000z8-Dt
	for qemu-devel@nongnu.org; Mon, 18 Oct 2010 08:43:09 -0400
Received: from mtagate2.uk.ibm.com ([194.196.100.162]:37063)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@linux.vnet.ibm.com>) id 1P7p3U-0000ya-5c
	for qemu-devel@nongnu.org; Mon, 18 Oct 2010 08:43:08 -0400
Received: from d06nrmr1707.portsmouth.uk.ibm.com
	(d06nrmr1707.portsmouth.uk.ibm.com [9.149.39.225])
	by mtagate2.uk.ibm.com (8.13.1/8.13.1) with ESMTP id o9ICh6Dd005493
	for <qemu-devel@nongnu.org>; Mon, 18 Oct 2010 12:43:06 GMT
Received: from d06av12.portsmouth.uk.ibm.com (d06av12.portsmouth.uk.ibm.com
	[9.149.37.247])
	by d06nrmr1707.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with
	ESMTP id o9ICh00i3604648
	for <qemu-devel@nongnu.org>; Mon, 18 Oct 2010 13:43:06 +0100
Received: from d06av12.portsmouth.uk.ibm.com (loopback [127.0.0.1])
	by d06av12.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with
	ESMTP id o9ICgxwo010670
	for <qemu-devel@nongnu.org>; Mon, 18 Oct 2010 06:42:59 -0600
From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Date: Mon, 18 Oct 2010 13:42:53 +0100
Message-Id: <1287405776-19651-1-git-send-email-stefanha@linux.vnet.ibm.com>
In-Reply-To: <AANLkTinUw8-tGxiNN2K=bz3ZZEFUZrLn=YSHGm2mUWfc@mail.gmail.com>
References: <AANLkTinUw8-tGxiNN2K=bz3ZZEFUZrLn=YSHGm2mUWfc@mail.gmail.com>
Subject: [Qemu-devel] Re: [PATCH] apic: convert debug printf statements to
	tracepoints
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org

Thanks for pointing out this problem with simpletrace.py.  There are two
issues:

1. The regular expression used by simpletrace.py to parse trace event
   declarations cannot cope with concatenated string literals.
2. Format strings must begin and end with double quotes.  This was previously
   undocumented but is necessary because cpp is not run over trace-events, so
   parsing the strings and portability macros is non-trivial.

The follow-up patches fix the regex, add documentation for the format string
double quotes requirement, and update your patch.

simpletrace.py should work for the coalesced apic trace events now.

Stefan