qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH 2/3] trace: Format strings must begin/end with double quotes
Date: Mon, 18 Oct 2010 13:42:55 +0100	[thread overview]
Message-ID: <1287405776-19651-3-git-send-email-stefanha@linux.vnet.ibm.com> (raw)
In-Reply-To: <AANLkTinUw8-tGxiNN2K=bz3ZZEFUZrLn=YSHGm2mUWfc@mail.gmail.com>

Document the restriction that format strings must begin and end with
double quotes.  This is for easy parsing since we don't run cpp over
trace-events.

Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
 docs/tracing.txt |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/docs/tracing.txt b/docs/tracing.txt
index 5504850..963c504 100644
--- a/docs/tracing.txt
+++ b/docs/tracing.txt
@@ -74,7 +74,10 @@ Trace events should use types as follows:
 
 Format strings should reflect the types defined in the trace event.  Take
 special care to use PRId64 and PRIu64 for int64_t and uint64_t types,
-respectively.  This ensures portability between 32- and 64-bit platforms.
+respectively.  This ensures portability between 32- and 64-bit platforms.  Note
+that format strings must begin and end with double quotes.  When using
+portability macros, ensure they are preceded and followed by double quotes:
+"value %"PRIx64"".
 
 === Hints for adding new trace events ===
 
-- 
1.7.1

  parent reply	other threads:[~2010-10-18 12:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-17  7:55 [Qemu-devel] [PATCH] apic: convert debug printf statements to tracepoints Blue Swirl
2010-10-18 12:42 ` [Qemu-devel] " Stefan Hajnoczi
2010-10-18 12:42 ` [Qemu-devel] [PATCH 1/3] trace: Relax trace-events parsing regex in simpletrace.py Stefan Hajnoczi
2010-10-20 16:49   ` [Qemu-devel] " Blue Swirl
2010-10-18 12:42 ` Stefan Hajnoczi [this message]
2010-10-18 12:42 ` [Qemu-devel] [PATCH 3/3] apic: convert debug printf statements to tracepoints Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1287405776-19651-3-git-send-email-stefanha@linux.vnet.ibm.com \
    --to=stefanha@linux.vnet.ibm.com \
    --cc=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).