From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=33028 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P7p3h-0005wP-71 for qemu-devel@nongnu.org; Mon, 18 Oct 2010 08:43:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P7p3U-0000zH-Dw for qemu-devel@nongnu.org; Mon, 18 Oct 2010 08:43:09 -0400 Received: from mtagate5.uk.ibm.com ([194.196.100.165]:58458) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P7p3U-0000yb-5d for qemu-devel@nongnu.org; Mon, 18 Oct 2010 08:43:08 -0400 Received: from d06nrmr1707.portsmouth.uk.ibm.com (d06nrmr1707.portsmouth.uk.ibm.com [9.149.39.225]) by mtagate5.uk.ibm.com (8.13.1/8.13.1) with ESMTP id o9ICh6Ng029225 for ; Mon, 18 Oct 2010 12:43:06 GMT Received: from d06av12.portsmouth.uk.ibm.com (d06av12.portsmouth.uk.ibm.com [9.149.37.247]) by d06nrmr1707.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o9ICh2II2601108 for ; Mon, 18 Oct 2010 13:43:06 +0100 Received: from d06av12.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av12.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id o9ICh2QC010721 for ; Mon, 18 Oct 2010 06:43:02 -0600 From: Stefan Hajnoczi Date: Mon, 18 Oct 2010 13:42:55 +0100 Message-Id: <1287405776-19651-3-git-send-email-stefanha@linux.vnet.ibm.com> In-Reply-To: References: Subject: [Qemu-devel] [PATCH 2/3] trace: Format strings must begin/end with double quotes List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org, Stefan Hajnoczi Document the restriction that format strings must begin and end with double quotes. This is for easy parsing since we don't run cpp over trace-events. Signed-off-by: Stefan Hajnoczi --- docs/tracing.txt | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/docs/tracing.txt b/docs/tracing.txt index 5504850..963c504 100644 --- a/docs/tracing.txt +++ b/docs/tracing.txt @@ -74,7 +74,10 @@ Trace events should use types as follows: Format strings should reflect the types defined in the trace event. Take special care to use PRId64 and PRIu64 for int64_t and uint64_t types, -respectively. This ensures portability between 32- and 64-bit platforms. +respectively. This ensures portability between 32- and 64-bit platforms. Note +that format strings must begin and end with double quotes. When using +portability macros, ensure they are preceded and followed by double quotes: +"value %"PRIx64"". === Hints for adding new trace events === -- 1.7.1