From: Gianni Tedesco <gianni.tedesco@citrix.com>
To: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: [Qemu-devel] [PATCH]: VNC: set listener socket to non-blocking mode
Date: Thu, 21 Oct 2010 17:18:39 +0100 [thread overview]
Message-ID: <1287677919.12843.4383.camel@qabil.uk.xensource.com> (raw)
This prevents qemu from hanging waiting for a client to connect. I have
reproduced this when doing a loadvm but it may be a more general problem
in that poll/accept may race if a client aborts the connection with a
RST before the accept has completed. In either case the fix seems
harmless.
Signed-off-by: Gianni Tedesco <gianni.tedesco@citrix.com>
diff --git a/ui/vnc.c b/ui/vnc.c
index 864342e..172b988 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -2736,5 +2736,6 @@ int vnc_display_open(DisplayState *ds, const char *display)
vs->display = dpy;
}
}
+ socket_set_nonblock(vs->lsock);
return qemu_set_fd_handler2(vs->lsock, NULL, vnc_listen_read, NULL, vs);
}
next reply other threads:[~2010-10-21 16:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 16:18 Gianni Tedesco [this message]
2010-10-21 16:44 ` [Qemu-devel] [PATCH]: VNC: set listener socket to non-blocking mode Anthony Liguori
2010-10-22 11:34 ` Gianni Tedesco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287677919.12843.4383.camel@qabil.uk.xensource.com \
--to=gianni.tedesco@citrix.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).