From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=43272 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P9HuC-0002KK-Id for qemu-devel@nongnu.org; Fri, 22 Oct 2010 09:43:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P9Hu9-0003FM-Hn for qemu-devel@nongnu.org; Fri, 22 Oct 2010 09:43:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59601) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P9Hu9-0003FC-6Q for qemu-devel@nongnu.org; Fri, 22 Oct 2010 09:43:33 -0400 From: Kevin Wolf Date: Fri, 22 Oct 2010 15:43:52 +0200 Message-Id: <1287755036-27688-8-git-send-email-kwolf@redhat.com> In-Reply-To: <1287755036-27688-1-git-send-email-kwolf@redhat.com> References: <1287755036-27688-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 07/11] block: Use GCC_FMT_ATTR and fix a format error List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: kwolf@redhat.com, qemu-devel@nongnu.org From: Stefan Weil Adding the gcc format attribute detects a format bug which is fixed here. v2: Don't use type cast. BDRV_SECTOR_SIZE is unsigned long long, so %lld should be the correct format specifier. Cc: Blue Swirl Cc: Kevin Wolf Signed-off-by: Stefan Weil Signed-off-by: Kevin Wolf --- block/blkverify.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/block/blkverify.c b/block/blkverify.c index 8083464..b2a12fe 100644 --- a/block/blkverify.c +++ b/block/blkverify.c @@ -53,7 +53,8 @@ static AIOPool blkverify_aio_pool = { .cancel = blkverify_aio_cancel, }; -static void blkverify_err(BlkverifyAIOCB *acb, const char *fmt, ...) +static void GCC_FMT_ATTR(2, 3) blkverify_err(BlkverifyAIOCB *acb, + const char *fmt, ...) { va_list ap; @@ -299,7 +300,7 @@ static void blkverify_verify_readv(BlkverifyAIOCB *acb) { ssize_t offset = blkverify_iovec_compare(acb->qiov, &acb->raw_qiov); if (offset != -1) { - blkverify_err(acb, "contents mismatch in sector %ld", + blkverify_err(acb, "contents mismatch in sector %lld", acb->sector_num + (offset / BDRV_SECTOR_SIZE)); } } -- 1.7.2.3