From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH 2/6] pa: process 1/4 buffer max at once
Date: Wed, 27 Oct 2010 18:04:31 +0200 [thread overview]
Message-ID: <1288195475-3807-3-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1288195475-3807-1-git-send-email-kraxel@redhat.com>
Limit the size of data pieces processed by the pulseaudio worker
threads. Never ever process more than 1/4 of the buffer at once.
Data processing is less bulky then.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
audio/paaudio.c | 14 ++++----------
1 files changed, 4 insertions(+), 10 deletions(-)
diff --git a/audio/paaudio.c b/audio/paaudio.c
index f768ca9..f99ca73 100644
--- a/audio/paaudio.c
+++ b/audio/paaudio.c
@@ -57,9 +57,6 @@ static void *qpa_thread_out (void *arg)
{
PAVoiceOut *pa = arg;
HWVoiceOut *hw = &pa->hw;
- int threshold;
-
- threshold = conf.divisor ? hw->samples / conf.divisor : 0;
if (audio_pt_lock (&pa->pt, AUDIO_FUNC)) {
return NULL;
@@ -73,7 +70,7 @@ static void *qpa_thread_out (void *arg)
goto exit;
}
- if (pa->live > threshold) {
+ if (pa->live > 0) {
break;
}
@@ -82,7 +79,7 @@ static void *qpa_thread_out (void *arg)
}
}
- decr = to_mix = pa->live;
+ decr = to_mix = audio_MIN (pa->live, conf.samples >> 2);
rpos = pa->rpos;
if (audio_pt_unlock (&pa->pt, AUDIO_FUNC)) {
@@ -152,9 +149,6 @@ static void *qpa_thread_in (void *arg)
{
PAVoiceIn *pa = arg;
HWVoiceIn *hw = &pa->hw;
- int threshold;
-
- threshold = conf.divisor ? hw->samples / conf.divisor : 0;
if (audio_pt_lock (&pa->pt, AUDIO_FUNC)) {
return NULL;
@@ -168,7 +162,7 @@ static void *qpa_thread_in (void *arg)
goto exit;
}
- if (pa->dead > threshold) {
+ if (pa->dead > 0) {
break;
}
@@ -177,7 +171,7 @@ static void *qpa_thread_in (void *arg)
}
}
- incr = to_grab = pa->dead;
+ incr = to_grab = audio_MIN (pa->dead, conf.samples >> 2);
wpos = pa->wpos;
if (audio_pt_unlock (&pa->pt, AUDIO_FUNC)) {
--
1.7.1
next prev parent reply other threads:[~2010-10-27 16:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-27 16:04 [Qemu-devel] [PATCH 0/6] The windows 7 audio support patch series Gerd Hoffmann
2010-10-27 16:04 ` [Qemu-devel] [PATCH 1/6] pa: allow processing buffer pieces Gerd Hoffmann
2010-10-27 16:04 ` Gerd Hoffmann [this message]
2010-10-27 16:04 ` [Qemu-devel] [PATCH 3/6] pa: setup buffer attrs Gerd Hoffmann
2010-10-27 16:04 ` [Qemu-devel] [PATCH 4/6] pa: tweak config Gerd Hoffmann
2010-10-27 16:04 ` [Qemu-devel] [PATCH 5/6] Add support for a USB audio device model Gerd Hoffmann
2010-10-27 17:13 ` [Qemu-devel] " H. Peter Anvin
2010-10-28 8:01 ` Gerd Hoffmann
2010-10-28 15:23 ` H. Peter Anvin
2010-10-28 16:13 ` Gerd Hoffmann
2010-10-28 15:28 ` H. Peter Anvin
2010-10-28 15:29 ` H. Peter Anvin
2010-10-27 16:04 ` [Qemu-devel] [PATCH 6/6] Add Intel HD Audio support to qemu Gerd Hoffmann
2010-10-27 17:46 ` [Qemu-devel] [PATCH 0/6] The windows 7 audio support patch series malc
2010-10-27 17:51 ` malc
2010-10-28 8:47 ` Gerd Hoffmann
2010-10-28 9:46 ` malc
2010-10-28 10:06 ` malc
2010-10-28 10:06 ` Gerd Hoffmann
2010-10-28 22:21 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288195475-3807-3-git-send-email-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).