From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=42288 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PBomi-0005Xe-CY for qemu-devel@nongnu.org; Fri, 29 Oct 2010 09:15:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PBoV4-0006tS-Ix for qemu-devel@nongnu.org; Fri, 29 Oct 2010 08:57:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52312) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PBoV4-0006sy-8q for qemu-devel@nongnu.org; Fri, 29 Oct 2010 08:56:06 -0400 From: Gerd Hoffmann Date: Fri, 29 Oct 2010 14:55:54 +0200 Message-Id: <1288356955-6019-3-git-send-email-kraxel@redhat.com> In-Reply-To: <1288356955-6019-1-git-send-email-kraxel@redhat.com> References: <1288356955-6019-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PATCH 2/3] pulseaudio: setup buffer attrs List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: fengguang.wu@intel.com, Gerd Hoffmann Request reasonable buffer sizes from pulseaudio. Without this pa_simple_write() can block quite long and lead to dropouts, especially with guests which use small audio ring buffers. Signed-off-by: Gerd Hoffmann --- audio/paaudio.c | 12 +++++++++++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/audio/paaudio.c b/audio/paaudio.c index f99ca73..61af0c5 100644 --- a/audio/paaudio.c +++ b/audio/paaudio.c @@ -289,6 +289,7 @@ static int qpa_init_out (HWVoiceOut *hw, struct audsettings *as) { int error; static pa_sample_spec ss; + static pa_buffer_attr ba; struct audsettings obt_as = *as; PAVoiceOut *pa = (PAVoiceOut *) hw; @@ -296,6 +297,15 @@ static int qpa_init_out (HWVoiceOut *hw, struct audsettings *as) ss.channels = as->nchannels; ss.rate = as->freq; + /* + * qemu audio tick runs at 250 Hz (by default), so processing + * data chunks worth 4 ms of sound should be a good fit. + */ + ba.tlength = pa_usec_to_bytes (4 * 1000, &ss); + ba.minreq = pa_usec_to_bytes (2 * 1000, &ss); + ba.maxlength = -1; + ba.prebuf = -1; + obt_as.fmt = pa_to_audfmt (ss.format, &obt_as.endianness); pa->s = pa_simple_new ( @@ -306,7 +316,7 @@ static int qpa_init_out (HWVoiceOut *hw, struct audsettings *as) "pcm.playback", &ss, NULL, /* channel map */ - NULL, /* buffering attributes */ + &ba, /* buffering attributes */ &error ); if (!pa->s) { -- 1.7.1