* [Qemu-devel] [PATCH] Fixed default IRQ assignment for PL190 VIC.
@ 2010-11-01 12:46 Himanshu Chauhan
2010-12-27 19:30 ` Aurelien Jarno
0 siblings, 1 reply; 2+ messages in thread
From: Himanshu Chauhan @ 2010-11-01 12:46 UTC (permalink / raw)
To: qemu-devel; +Cc: Himanshu Chauhan
Everywhere else vect_addr[16] is returned on a read of default vector address
but updation is done only on default_addr in structure.
Signed-off-by: Himanshu Chauhan <hschauhan@nulltrace.org>
---
hw/pl190.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/pl190.c b/hw/pl190.c
index a4bc9c1..7363b87 100644
--- a/hw/pl190.c
+++ b/hw/pl190.c
@@ -187,6 +187,7 @@ static void pl190_write(void *opaque, target_phys_addr_t offset, uint32_t val)
break;
case 13: /* DEFVECTADDR */
s->default_addr = val;
+ s->vect_addr[16] = val;
break;
case 0xc0: /* ITCR */
if (val) {
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] Fixed default IRQ assignment for PL190 VIC.
2010-11-01 12:46 [Qemu-devel] [PATCH] Fixed default IRQ assignment for PL190 VIC Himanshu Chauhan
@ 2010-12-27 19:30 ` Aurelien Jarno
0 siblings, 0 replies; 2+ messages in thread
From: Aurelien Jarno @ 2010-12-27 19:30 UTC (permalink / raw)
To: Himanshu Chauhan; +Cc: qemu-devel
On Mon, Nov 01, 2010 at 06:16:01PM +0530, Himanshu Chauhan wrote:
> Everywhere else vect_addr[16] is returned on a read of default vector address
> but updation is done only on default_addr in structure.
>
> Signed-off-by: Himanshu Chauhan <hschauhan@nulltrace.org>
> ---
> hw/pl190.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/hw/pl190.c b/hw/pl190.c
> index a4bc9c1..7363b87 100644
> --- a/hw/pl190.c
> +++ b/hw/pl190.c
> @@ -187,6 +187,7 @@ static void pl190_write(void *opaque, target_phys_addr_t offset, uint32_t val)
> break;
> case 13: /* DEFVECTADDR */
> s->default_addr = val;
> + s->vect_addr[16] = val;
> break;
> case 0xc0: /* ITCR */
> if (val) {
After this change, default_addr is not used anymore in this file. It
should be removed from the pl190_state structure.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-12-27 21:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-01 12:46 [Qemu-devel] [PATCH] Fixed default IRQ assignment for PL190 VIC Himanshu Chauhan
2010-12-27 19:30 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).