From: Alexander Graf <agraf@suse.de>
To: qemu-devel Developers <qemu-devel@nongnu.org>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH 14/40] xenner: kernel: Instruction emulator
Date: Mon, 1 Nov 2010 16:01:27 +0100 [thread overview]
Message-ID: <1288623713-28062-15-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1288623713-28062-1-git-send-email-agraf@suse.de>
In some cases we need to emulate guest instructions. This patch adds
code to take care of this.
Signed-off-by: Alexander Graf <agraf@suse.de>
---
pc-bios/xenner/xenner-instr.c | 405 +++++++++++++++++++++++++++++++++++++++++
1 files changed, 405 insertions(+), 0 deletions(-)
create mode 100644 pc-bios/xenner/xenner-instr.c
diff --git a/pc-bios/xenner/xenner-instr.c b/pc-bios/xenner/xenner-instr.c
new file mode 100644
index 0000000..11be2ce
--- /dev/null
+++ b/pc-bios/xenner/xenner-instr.c
@@ -0,0 +1,405 @@
+/*
+ * Copyright (C) Red Hat 2007
+ * Copyright (C) Novell Inc. 2010
+ *
+ * Author(s): Gerd Hoffmann <kraxel@redhat.com>
+ * Alexander Graf <agraf@suse.de>
+ *
+ * Xenner instruction emulator
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; under version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include "xenner.h"
+#include "msr-index.h"
+#include "cpufeature.h"
+
+void real_cpuid(struct kvm_cpuid_entry *entry)
+{
+ asm volatile("cpuid"
+ : "=a" (entry->eax),
+ "=b" (entry->ebx),
+ "=c" (entry->ecx),
+ "=d" (entry->edx)
+ : "a" (entry->function));
+}
+
+static unsigned long clear_cpuid_bit(unsigned long bit, unsigned long x)
+{
+ unsigned long r = x;
+
+ bit %= 64;
+ r = x & ~(1 << bit);
+
+ return r;
+}
+
+static void filter_cpuid(struct kvm_cpuid_entry *entry)
+{
+ switch (entry->function) {
+ case 0x00000001:
+ entry->edx = clear_cpuid_bit(X86_FEATURE_SEP, entry->edx);
+ entry->edx = clear_cpuid_bit(X86_FEATURE_DS, entry->edx);
+ entry->edx = clear_cpuid_bit(X86_FEATURE_DS, entry->edx);
+ entry->edx = clear_cpuid_bit(X86_FEATURE_ACC, entry->edx);
+ entry->edx = clear_cpuid_bit(X86_FEATURE_PBE, entry->edx);
+
+ entry->ecx = clear_cpuid_bit(X86_FEATURE_DTES64, entry->ecx);
+ entry->ecx = clear_cpuid_bit(X86_FEATURE_MWAIT, entry->ecx);
+ entry->ecx = clear_cpuid_bit(X86_FEATURE_DSCPL, entry->ecx);
+ entry->ecx = clear_cpuid_bit(X86_FEATURE_VMXE, entry->ecx);
+ entry->ecx = clear_cpuid_bit(X86_FEATURE_SMXE, entry->ecx);
+ entry->ecx = clear_cpuid_bit(X86_FEATURE_EST, entry->ecx);
+ entry->ecx = clear_cpuid_bit(X86_FEATURE_TM2, entry->ecx);
+ entry->ecx = clear_cpuid_bit(X86_FEATURE_XTPR, entry->ecx);
+ entry->ecx = clear_cpuid_bit(X86_FEATURE_PDCM, entry->ecx);
+ entry->ecx = clear_cpuid_bit(X86_FEATURE_DCA, entry->ecx);
+ entry->ecx = clear_cpuid_bit(X86_FEATURE_XSAVE, entry->ecx);
+ /* fall through */
+ case 0x80000001:
+ entry->edx = clear_cpuid_bit(X86_FEATURE_VME, entry->edx);
+ entry->edx = clear_cpuid_bit(X86_FEATURE_PSE, entry->edx);
+ entry->edx = clear_cpuid_bit(X86_FEATURE_PGE, entry->edx);
+ entry->edx = clear_cpuid_bit(X86_FEATURE_MCE, entry->edx);
+ entry->edx = clear_cpuid_bit(X86_FEATURE_MCA, entry->edx);
+ entry->edx = clear_cpuid_bit(X86_FEATURE_MTRR, entry->edx);
+ entry->edx = clear_cpuid_bit(X86_FEATURE_PSE36, entry->edx);
+
+#ifdef CONFIG_32BIT
+ entry->edx = clear_cpuid_bit(X86_FEATURE_LM, entry->edx);
+ entry->ecx = clear_cpuid_bit(X86_FEATURE_LAHF_LM, entry->ecx);
+#endif
+ entry->edx = clear_cpuid_bit(X86_FEATURE_PAGE1GB, entry->edx);
+ entry->edx = clear_cpuid_bit(X86_FEATURE_RDTSCP, entry->edx);
+
+ entry->ecx = clear_cpuid_bit(X86_FEATURE_SVME, entry->ecx);
+ entry->ecx = clear_cpuid_bit(X86_FEATURE_OSVW, entry->ecx);
+ entry->ecx = clear_cpuid_bit(X86_FEATURE_IBS, entry->ecx);
+ entry->ecx = clear_cpuid_bit(X86_FEATURE_SKINIT, entry->ecx);
+ entry->ecx = clear_cpuid_bit(X86_FEATURE_WDT, entry->ecx);
+ break;
+
+ case 0x00000005: /* MONITOR/MWAIT */
+ case 0x0000000a: /* Architectural Performance Monitor Features */
+ case 0x8000000a: /* SVM revision and features */
+ case 0x8000001b: /* Instruction Based Sampling */
+ entry->eax = 0;
+ entry->ebx = 0;
+ entry->ecx = 0;
+ entry->edx = 0;
+ break;
+ }
+}
+
+static void emulate_cpuid(struct regs *regs)
+{
+ struct kvm_cpuid_entry entry;
+
+ entry.function = regs->rax;
+ real_cpuid(&entry);
+ filter_cpuid(&entry);
+ regs->rax = entry.eax;
+ regs->rbx = entry.ebx;
+ regs->rcx = entry.ecx;
+ regs->rdx = entry.edx;
+ printk(2, "cpuid 0x%08x: eax 0x%08x ebx 0x%08x ecx 0x%08x edx 0x%08x\n",
+ entry.function, entry.eax, entry.ebx, entry.ecx, entry.edx);
+}
+
+static void emulate_rdmsr(struct regs *regs)
+{
+ uint32_t ax,dx;
+ switch (regs->rcx) {
+ case MSR_EFER:
+ case MSR_FS_BASE:
+ case MSR_GS_BASE:
+ case MSR_KERNEL_GS_BASE:
+ /* white listed */
+ rdmsr(regs->rcx, &ax, &dx);
+ regs->rax = ax;
+ regs->rdx = dx;
+ break;
+ default:
+ printk(1, "%s: ignore: rcx 0x%" PRIxREG "\n", __FUNCTION__, regs->rcx);
+ regs->rax = 0;
+ regs->rdx = 0;
+ break;
+ }
+}
+
+static void emulate_wrmsr(struct regs *regs)
+{
+ static const uint64_t known = (EFER_NX|EFER_LMA|EFER_LME|EFER_SCE);
+ static const uint64_t fixed = (EFER_LMA|EFER_LME|EFER_SCE);
+ uint32_t ax,dx;
+
+ switch (regs->rcx) {
+ case MSR_EFER:
+ if (regs->rax & ~known) {
+ printk(1, "%s: efer: unknown bit set\n", __FUNCTION__);
+ goto out;
+ }
+
+ rdmsr(regs->rcx, &ax, &dx);
+ if ((regs->rax & fixed) != (ax & fixed)) {
+ printk(1, "%s: efer: modify fixed bit\n", __FUNCTION__);
+ goto out;
+ }
+
+ printk(1, "%s: efer:%s%s%s%s\n", __FUNCTION__,
+ regs->rax & EFER_SCE ? " sce" : "",
+ regs->rax & EFER_LME ? " lme" : "",
+ regs->rax & EFER_LMA ? " lma" : "",
+ regs->rax & EFER_NX ? " nx" : "");
+ /* fall through */
+ case MSR_FS_BASE:
+ case MSR_GS_BASE:
+ case MSR_KERNEL_GS_BASE:
+ wrmsr(regs->rcx, regs->rax, regs->rdx);
+ return;
+ }
+
+out:
+ printk(1, "%s: ignore: 0x%" PRIxREG " 0x%" PRIxREG ":0x%" PRIxREG "\n",
+ __FUNCTION__, regs->rcx, regs->rdx, regs->rax);
+}
+
+void print_emu_instr(int level, const char *prefix, uint8_t *instr)
+{
+ printk(level, "%s: rip %p bytes %02x %02x %02x %02x %02x %02x %02x %02x\n",
+ prefix, instr,
+ instr[0], instr[1], instr[2], instr[3],
+ instr[4], instr[5], instr[6], instr[7]);
+}
+
+static ureg_t *decode_reg(struct regs *regs, uint8_t modrm, int rm)
+{
+ int shift = rm ? 0 : 3;
+ ureg_t *reg = NULL;
+
+ switch ((modrm >> shift) & 0x07) {
+ case 0: reg = (ureg_t*)®s->rax; break;
+ case 1: reg = (ureg_t*)®s->rcx; break;
+ case 2: reg = (ureg_t*)®s->rdx; break;
+ case 3: reg = (ureg_t*)®s->rbx; break;
+ case 4: reg = (ureg_t*)®s->rsp; break;
+ case 5: reg = (ureg_t*)®s->rbp; break;
+ case 6: reg = (ureg_t*)®s->rsi; break;
+ case 7: reg = (ureg_t*)®s->rdi; break;
+ }
+ return reg;
+}
+
+void print_bits(int level, const char *msg, uint32_t old, uint32_t new,
+ const char *names[])
+{
+ char buf[128];
+ int pos = 0;
+ uint32_t mask;
+ char *mod;
+ int i;
+
+ pos += snprintf(buf+pos, sizeof(buf)-pos, "%s:", msg);
+ for (i = 0; i < 32; i++) {
+ mask = 1 << i;
+ if (new&mask) {
+ if (old&mask) {
+ /* bit present */
+ mod = "";
+ } else {
+ /* bit added */
+ mod = "+";
+ }
+ } else {
+ if (old&mask) {
+ /* bit removed */
+ mod = "-";
+ } else {
+ /* bit not present */
+ continue;
+ }
+ }
+ pos += snprintf(buf+pos, sizeof(buf)-pos, " %s%s",
+ mod, names[i] ? names[i] : "???");
+ }
+ pos += snprintf(buf+pos, sizeof(buf)-pos, "\n");
+ printk(level, "%s", buf);
+}
+
+int emulate(struct xen_cpu *cpu, struct regs *regs)
+{
+ static const uint8_t xen_emu_prefix[5] = {0x0f, 0x0b, 'x','e','n'};
+ uint8_t *instr;
+ int skip = 0;
+ int in = 0;
+ int shift = 0;
+ int port = 0;
+
+restart:
+ instr = (void*)regs->rip;
+
+ /* prefixes */
+ if (instr[skip] == 0x66) {
+ shift = 16;
+ skip++;
+ }
+
+ /* instructions */
+ switch (instr[skip]) {
+ case 0x0f:
+ switch (instr[skip+1]) {
+ case 0x06:
+ /* clts */
+ clts();
+ skip += 2;
+ break;
+ case 0x09:
+ /* wbinvd */
+ __asm__("wbinvd" ::: "memory");
+ skip += 2;
+ break;
+ case 0x0b:
+ /* ud2a */
+ if (xen_emu_prefix[2] == instr[skip+2] &&
+ xen_emu_prefix[3] == instr[skip+3] &&
+ xen_emu_prefix[4] == instr[skip+4]) {
+ printk(2, "%s: xen emu prefix\n", __FUNCTION__);
+ regs->rip += 5;
+ goto restart;
+ }
+ printk(1, "%s: ud2a -- linux kernel BUG()?\n", __FUNCTION__);
+ /* bounce to guest, hoping it prints more info */
+ return 0;
+ case 0x20:
+ {
+ /* read control registers */
+ ureg_t *reg = decode_reg(regs, instr[skip+2], 1);
+ switch (((instr[skip+2]) >> 3) & 0x07) {
+ case 0:
+ *reg = read_cr0();
+ skip = 3;
+ break;
+ case 3:
+ *reg = frame_to_addr(read_cr3_mfn(cpu));
+ skip = 3;
+ break;
+ case 4:
+ *reg = read_cr4();
+ skip = 3;
+ break;
+ }
+ break;
+ }
+ case 0x22:
+ {
+ /* write control registers */
+ static const ureg_t cr0_fixed = ~(X86_CR0_TS);
+ static const ureg_t cr4_fixed = X86_CR4_TSD;
+ ureg_t *reg = decode_reg(regs, instr[skip+2], 1);
+ ureg_t cr;
+ switch (((instr[skip+2]) >> 3) & 0x07) {
+ case 0:
+ cr = read_cr0();
+ if (cr != *reg) {
+ if ((cr & cr0_fixed) == (*reg & cr0_fixed)) {
+ print_bits(2, "apply cr0 update", cr, *reg, cr0_bits);
+ write_cr0(*reg);
+ } else {
+ print_bits(1, "IGNORE cr0 update", cr, *reg, cr0_bits);
+ }
+ }
+ skip = 3;
+ break;
+ case 4:
+ cr = read_cr4();
+ if (cr != *reg) {
+ if ((cr & cr4_fixed) == (*reg & cr4_fixed)) {
+ print_bits(1, "apply cr4 update", cr, *reg, cr4_bits);
+ write_cr4(*reg);
+ } else {
+ print_bits(1, "IGNORE cr4 update", cr, *reg, cr4_bits);
+ }
+ }
+ skip = 3;
+ break;
+ }
+ break;
+ }
+ case 0x30:
+ /* wrmsr */
+ emulate_wrmsr(regs);
+ skip += 2;
+ break;
+ case 0x32:
+ /* rdmsr */
+ emulate_rdmsr(regs);
+ skip += 2;
+ break;
+ case 0xa2:
+ /* cpuid */
+ emulate_cpuid(regs);
+ skip += 2;
+ break;
+ }
+ break;
+
+ case 0xe4: /* in <next byte>,%al */
+ case 0xe5:
+ in = (instr[skip] & 1) ? 2 : 1;
+ port = instr[skip+1];
+ skip += 2;
+ break;
+ case 0xec: /* in (%dx),%al */
+ case 0xed:
+ in = (instr[skip] & 1) ? 2 : 1;
+ port = regs->rdx & 0xffff;
+ skip += 1;
+ break;
+ case 0xe6: /* out %al,<next byte> */
+ case 0xe7:
+ port = instr[skip+1];
+ skip += 2;
+ break;
+ case 0xee: /* out %al,(%dx) */
+ case 0xef:
+ port = regs->rdx & 0xffff;
+ skip += 1;
+ break;
+
+ case 0xfa:
+ /* cli */
+ guest_cli(cpu);
+ skip += 1;
+ break;
+ case 0xfb:
+ /* sti */
+ guest_sti(cpu);
+ skip += 1;
+ break;
+ }
+
+ /* unknown instruction */
+ if (!skip) {
+ print_emu_instr(0, "instr emu failed", instr);
+ return -1;
+ }
+
+ /* I/O instruction */
+ if (in == 2) {
+ regs->rax |= 0xffffffff;
+ } else if (in == 1) {
+ regs->rax |= (0xffff << shift);
+ }
+
+ return skip;
+}
--
1.6.0.2
next prev parent reply other threads:[~2010-11-01 15:02 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-01 15:01 [Qemu-devel] [PATCH 00/40] RFC: Xenner Alexander Graf
2010-11-01 15:01 ` [Qemu-devel] [PATCH 01/40] elf: Move translate_fn to helper struct Alexander Graf
2010-11-01 15:01 ` [Qemu-devel] [PATCH 02/40] elf: Add notes implementation Alexander Graf
2010-11-01 18:29 ` Blue Swirl
2010-11-01 18:42 ` Stefan Weil
2010-11-01 19:51 ` Alexander Graf
2010-11-01 20:19 ` Stefan Weil
2010-11-01 21:17 ` Alexander Graf
2010-11-01 21:28 ` [Qemu-devel] " Paolo Bonzini
2010-11-01 21:31 ` [Qemu-devel] " Stefan Weil
2010-11-02 10:17 ` Michael Matz
2010-11-01 18:41 ` [Qemu-devel] " Paolo Bonzini
2010-11-01 18:52 ` Alexander Graf
2010-11-01 19:43 ` Paolo Bonzini
2010-11-01 19:48 ` Alexander Graf
2010-11-01 21:23 ` Paolo Bonzini
2010-11-01 15:01 ` [Qemu-devel] [PATCH 03/40] elf: add header notification Alexander Graf
2010-11-01 15:01 ` [Qemu-devel] [PATCH 04/40] elf: add section analyzer Alexander Graf
2010-11-01 15:01 ` [Qemu-devel] [PATCH 05/40] xen-disk: disable aio Alexander Graf
2010-11-01 15:01 ` [Qemu-devel] [PATCH 06/40] qdev-ify: xen backends Alexander Graf
2010-11-02 10:08 ` Markus Armbruster
2010-11-02 10:43 ` Gerd Hoffmann
2010-11-02 13:26 ` Markus Armbruster
2010-11-01 15:01 ` [Qemu-devel] [PATCH 07/40] xenner: kernel: 32 bit files Alexander Graf
2010-11-01 15:01 ` [Qemu-devel] [PATCH 08/40] xenner: kernel: 64-bit files Alexander Graf
2010-11-01 15:44 ` Anthony Liguori
2010-11-01 15:47 ` Alexander Graf
2010-11-01 15:59 ` Anthony Liguori
2010-11-01 19:00 ` Blue Swirl
2010-11-01 19:02 ` Anthony Liguori
2010-11-01 19:05 ` Alexander Graf
2010-11-01 19:23 ` Blue Swirl
2010-11-01 19:37 ` Anthony Liguori
2010-11-01 15:01 ` [Qemu-devel] [PATCH 09/40] xenner: kernel: Global data Alexander Graf
2010-11-01 15:01 ` [Qemu-devel] [PATCH 10/40] xenner: kernel: Hypercall handler (i386) Alexander Graf
2010-11-01 15:01 ` [Qemu-devel] [PATCH 11/40] xenner: kernel: Hypercall handler (x86_64) Alexander Graf
2010-11-01 15:01 ` [Qemu-devel] [PATCH 12/40] xenner: kernel: Hypercall handler (generic) Alexander Graf
2010-11-01 15:01 ` [Qemu-devel] [PATCH 13/40] xenner: kernel: Headers Alexander Graf
2010-11-01 15:01 ` Alexander Graf [this message]
2010-11-01 15:41 ` [Qemu-devel] [PATCH 14/40] xenner: kernel: Instruction emulator malc
2010-11-01 18:46 ` [Qemu-devel] " Paolo Bonzini
2010-11-01 15:01 ` [Qemu-devel] [PATCH 15/40] xenner: kernel: lapic code Alexander Graf
2010-11-01 15:01 ` [Qemu-devel] [PATCH 16/40] xenner: kernel: Main (i386) Alexander Graf
2010-11-01 15:01 ` [Qemu-devel] [PATCH 17/40] xenner: kernel: Main (x86_64) Alexander Graf
2010-11-01 15:01 ` [Qemu-devel] [PATCH 18/40] xenner: kernel: Main Alexander Graf
2010-11-01 15:01 ` [Qemu-devel] [PATCH 19/40] xenner: kernel: Makefile Alexander Graf
2010-11-01 15:01 ` [Qemu-devel] [PATCH 20/40] xenner: kernel: mmu support for 32-bit PAE Alexander Graf
2010-11-01 15:01 ` [Qemu-devel] [PATCH 21/40] xenner: kernel: mmu support for 32-bit normal Alexander Graf
2010-11-01 15:01 ` [Qemu-devel] [PATCH 22/40] xenner: kernel: mmu support for 64-bit Alexander Graf
2010-11-01 15:01 ` [Qemu-devel] [PATCH 23/40] xenner: kernel: generic MM functionality Alexander Graf
2010-11-01 15:01 ` [Qemu-devel] [PATCH 24/40] xenner: kernel: printk Alexander Graf
2010-11-01 15:01 ` [Qemu-devel] [PATCH 25/40] xenner: kernel: KVM PV code Alexander Graf
2010-11-01 15:01 ` [Qemu-devel] [PATCH 26/40] xenner: kernel: xen-names Alexander Graf
2010-11-01 15:01 ` [Qemu-devel] [PATCH 27/40] xenner: add xc_dom.h Alexander Graf
2010-11-01 15:01 ` [Qemu-devel] [PATCH 28/40] xenner: libxc emu: evtchn Alexander Graf
2010-11-01 15:45 ` Anthony Liguori
2010-11-01 15:49 ` Alexander Graf
2010-11-01 16:01 ` Anthony Liguori
2010-11-01 16:07 ` Alexander Graf
2010-11-01 16:14 ` Anthony Liguori
2010-11-01 16:15 ` Alexander Graf
2010-11-01 19:39 ` [Qemu-devel] " Paolo Bonzini
2010-11-01 19:41 ` Anthony Liguori
2010-11-01 19:47 ` Alexander Graf
2010-11-01 20:32 ` Anthony Liguori
2010-11-01 21:47 ` Paolo Bonzini
2010-11-01 22:00 ` Anthony Liguori
2010-11-01 22:08 ` Paolo Bonzini
2010-11-01 22:29 ` Anthony Liguori
2010-11-02 4:33 ` Stefano Stabellini
2010-11-02 10:06 ` Paolo Bonzini
2010-11-02 10:31 ` Gerd Hoffmann
2010-11-02 10:38 ` Paolo Bonzini
2010-11-02 13:55 ` Stefano Stabellini
2010-11-02 15:48 ` Alexander Graf
2010-11-02 19:20 ` Stefano Stabellini
2010-11-01 15:01 ` [Qemu-devel] [PATCH 29/40] xenner: libxc emu: grant tables Alexander Graf
2010-11-01 15:01 ` [Qemu-devel] [PATCH 30/40] xenner: libxc emu: memory mapping Alexander Graf
2010-11-01 15:12 ` malc
2010-11-01 15:15 ` Alexander Graf
2010-11-01 15:01 ` [Qemu-devel] [PATCH 31/40] xenner: libxc emu: xenstore Alexander Graf
2010-11-01 18:36 ` Blue Swirl
2010-11-01 15:01 ` [Qemu-devel] [PATCH 32/40] xenner: emudev Alexander Graf
2010-11-01 15:01 ` [Qemu-devel] [PATCH 33/40] xenner: core Alexander Graf
2010-11-01 15:13 ` malc
2010-11-01 15:01 ` [Qemu-devel] [PATCH 34/40] xenner: PV machine Alexander Graf
2010-11-01 15:01 ` [Qemu-devel] [PATCH 35/40] xenner: Domain Builder Alexander Graf
2010-11-02 10:09 ` [Qemu-devel] " Paolo Bonzini
2010-11-02 15:36 ` Alexander Graf
2010-11-02 15:51 ` Paolo Bonzini
2010-11-02 16:28 ` Alexander Graf
2010-11-01 15:21 ` [Qemu-devel] [PATCH 00/40] RFC: Xenner Alexander Graf
2010-11-02 16:26 ` [Qemu-devel] [PATCH 36/40] xen: only create dummy env when necessary Alexander Graf
2010-11-02 16:26 ` [Qemu-devel] [PATCH 38/40] xenner: integrate into build system Alexander Graf
2010-11-02 16:26 ` [Qemu-devel] [PATCH 39/40] xenner: integrate into xen pv machine Alexander Graf
2010-11-02 16:26 ` [Qemu-devel] [PATCH 40/40] xen: add sysrq support Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288623713-28062-15-git-send-email-agraf@suse.de \
--to=agraf@suse.de \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).