From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=53406 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PDonn-0002Fq-Ja for qemu-devel@nongnu.org; Wed, 03 Nov 2010 21:39:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PDmFR-0006qK-A7 for qemu-devel@nongnu.org; Wed, 03 Nov 2010 18:56:06 -0400 Received: from e32.co.us.ibm.com ([32.97.110.150]:41818) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PDmFR-0006qG-2N for qemu-devel@nongnu.org; Wed, 03 Nov 2010 18:56:05 -0400 Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com [9.17.195.228]) by e32.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id oA3MkvLx010071 for ; Wed, 3 Nov 2010 16:46:57 -0600 Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id oA3Mu3Rp216968 for ; Wed, 3 Nov 2010 16:56:04 -0600 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id oA3Mu3EI008473 for ; Wed, 3 Nov 2010 16:56:03 -0600 From: Adam Litke In-Reply-To: <1288798090-7127-5-git-send-email-mdroth@linux.vnet.ibm.com> References: <1288798090-7127-1-git-send-email-mdroth@linux.vnet.ibm.com> <1288798090-7127-5-git-send-email-mdroth@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" Date: Wed, 03 Nov 2010 17:56:01 -0500 Message-ID: <1288824961.2846.23.camel@aglitke> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [RFC][RESEND][PATCH v1 04/15] virtproxy: list look-up functions conns/oforwards/iforwards List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: abeekhof@redhat.com, agl@linux.vnet.ibm.com, qemu-devel@nongnu.org, aliguori@linux.vnet.ibm.com You should describe your changes a little bit more on the top here. Looks good otherwise. On Wed, 2010-11-03 at 10:27 -0500, Michael Roth wrote: > Signed-off-by: Michael Roth > --- > virtproxy.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 44 insertions(+), 0 deletions(-) > > diff --git a/virtproxy.c b/virtproxy.c > index 2f8996c..fa17722 100644 > --- a/virtproxy.c > +++ b/virtproxy.c > @@ -149,3 +149,47 @@ static QemuOptsList vp_socket_opts = { > { /* end if list */ } > }, > }; > + > +/* get VPConn by fd, "client" denotes whether to look for client or server */ > +static VPConn *get_conn(const VPDriver *drv, int fd, bool client) > +{ > + VPConn *c = NULL; > + int cur_fd; > + > + QLIST_FOREACH(c, &drv->conns, next) { > + cur_fd = client ? c->client_fd : c->server_fd; > + if (cur_fd == fd) { > + return c; > + } > + } > + > + return NULL; > +} > + > +/* get VPOForward by service_id */ > +static VPOForward *get_oforward(const VPDriver *drv, const char *service_id) > +{ > + VPOForward *f = NULL; > + > + QLIST_FOREACH(f, &drv->oforwards, next) { > + if (strncmp(f->service_id, service_id, VP_SERVICE_ID_LEN) == 0) { > + return f; > + } > + } > + > + return NULL; > +} > + > +/* get VPIForward by service_id */ > +static VPIForward *get_iforward(const VPDriver *drv, const char *service_id) > +{ > + VPIForward *f = NULL; > + > + QLIST_FOREACH(f, &drv->iforwards, next) { > + if (strncmp(f->service_id, service_id, VP_SERVICE_ID_LEN) == 0) { > + return f; > + } > + } > + > + return NULL; > +} -- Thanks, Adam