From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=54149 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PDomw-0002KK-Vu for qemu-devel@nongnu.org; Wed, 03 Nov 2010 21:38:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PDn1f-0005p4-38 for qemu-devel@nongnu.org; Wed, 03 Nov 2010 19:45:56 -0400 Received: from e1.ny.us.ibm.com ([32.97.182.141]:40987) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PDn1e-0005oy-So for qemu-devel@nongnu.org; Wed, 03 Nov 2010 19:45:55 -0400 Received: from d01relay05.pok.ibm.com (d01relay05.pok.ibm.com [9.56.227.237]) by e1.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id oA3NcOwr015123 for ; Wed, 3 Nov 2010 19:38:24 -0400 Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay05.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id oA3Njshb126488 for ; Wed, 3 Nov 2010 19:45:54 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id oA3Njrst014500 for ; Wed, 3 Nov 2010 19:45:53 -0400 From: Adam Litke In-Reply-To: <1288798090-7127-8-git-send-email-mdroth@linux.vnet.ibm.com> References: <1288798090-7127-1-git-send-email-mdroth@linux.vnet.ibm.com> <1288798090-7127-8-git-send-email-mdroth@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" Date: Wed, 03 Nov 2010 18:45:51 -0500 Message-ID: <1288827951.2846.78.camel@aglitke> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [RFC][RESEND][PATCH v1 07/15] virtproxy: add vp_new() VPDriver constructor List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: abeekhof@redhat.com, agl@linux.vnet.ibm.com, qemu-devel@nongnu.org, aliguori@linux.vnet.ibm.com Be more descriptive here please. On Wed, 2010-11-03 at 10:28 -0500, Michael Roth wrote: > Signed-off-by: Michael Roth > --- > virtproxy.c | 23 +++++++++++++++++++++++ > virtproxy.h | 3 +++ > 2 files changed, 26 insertions(+), 0 deletions(-) > > diff --git a/virtproxy.c b/virtproxy.c > index c9c3022..cc0ac9a 100644 > --- a/virtproxy.c > +++ b/virtproxy.c > @@ -313,3 +313,26 @@ static void vp_channel_read(void *opaque) > drv->buflen += count; > } > } > + > +/* create/init VPDriver object */ > +VPDriver *vp_new(int fd, bool listen) > +{ > + VPDriver *drv = NULL; > + > + drv = qemu_mallocz(sizeof(VPDriver)); > + drv->listen_fd = -1; > + drv->channel_fd = -1; > + QLIST_INIT(&drv->oforwards); > + QLIST_INIT(&drv->conns); > + > + if (listen) { > + /* provided FD is to be listened on for channel connection */ > + drv->listen_fd = fd; > + vp_set_fd_handler(drv->listen_fd, vp_channel_accept, NULL, drv); > + } else { > + drv->channel_fd = fd; > + vp_set_fd_handler(drv->channel_fd, vp_channel_read, NULL, drv); > + } > + > + return drv; > +} > diff --git a/virtproxy.h b/virtproxy.h > index 0203421..3df1691 100644 > --- a/virtproxy.h > +++ b/virtproxy.h > @@ -31,4 +31,7 @@ int vp_set_fd_handler(int fd, > IOHandler *fd_write, > void *opaque); > > +/* virtproxy interface */ > +VPDriver *vp_new(int fd, bool listen); > + > #endif /* VIRTPROXY_H */ -- Thanks, Adam