From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: "François Revol" <revol@free.fr>, "Gerd Hoffmann" <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH v2 3/6] intel-hda: Honor WAKEEN bits.
Date: Tue, 9 Nov 2010 11:47:46 +0100 [thread overview]
Message-ID: <1289299669-5504-4-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1289299669-5504-1-git-send-email-kraxel@redhat.com>
From: François Revol <revol@free.fr>
HDA: Honor WAKEEN bits when deciding to raise an interrupt on codec
status change. This prevents an interrupt storm with the Haiku HDA
driver which does not handle codec status changes in the irq handler.
Signed-off-by: François Revol <revol@free.fr>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/intel-hda.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/hw/intel-hda.c b/hw/intel-hda.c
index 78c32da..2c1ef12 100644
--- a/hw/intel-hda.c
+++ b/hw/intel-hda.c
@@ -246,7 +246,7 @@ static void intel_hda_update_int_sts(IntelHDAState *d)
if (d->rirb_sts & ICH6_RBSTS_OVERRUN) {
sts |= (1 << 30);
}
- if (d->state_sts) {
+ if (d->state_sts & d->wake_en) {
sts |= (1 << 30);
}
@@ -628,6 +628,7 @@ static const struct IntelHDAReg regtab[] = {
[ ICH6_REG_WAKEEN ] = {
.name = "WAKEEN",
.size = 2,
+ .wmask = 0x3fff,
.offset = offsetof(IntelHDAState, wake_en),
},
[ ICH6_REG_STATESTS ] = {
--
1.7.1
next prev parent reply other threads:[~2010-11-09 10:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-09 10:47 [Qemu-devel] [PATCH v2 0/6] intel-hda: bugfixes and msi support Gerd Hoffmann
2010-11-09 10:47 ` [Qemu-devel] [PATCH v2 1/6] intel-hda: exit cleanup Gerd Hoffmann
2010-11-09 10:47 ` [Qemu-devel] [PATCH v2 2/6] hda-audio: " Gerd Hoffmann
2010-11-09 10:47 ` Gerd Hoffmann [this message]
2010-11-09 10:47 ` [Qemu-devel] [PATCH v2 4/6] intel-hda: update irq status on WAKEEN changes Gerd Hoffmann
2010-11-09 10:47 ` [Qemu-devel] [PATCH v2 5/6] intel-hda: add msi support Gerd Hoffmann
2010-11-09 10:47 ` [Qemu-devel] [PATCH v2 6/6] intel-hda: fix codec addressing Gerd Hoffmann
2010-11-09 16:16 ` malc
2010-11-09 13:58 ` [Qemu-devel] [PATCH v2 0/6] intel-hda: bugfixes and msi support malc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289299669-5504-4-git-send-email-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=revol@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).