qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gleb Natapov <gleb@redhat.com>
To: qemu-devel@nongnu.org
Cc: blauwirbel@gmail.com, alex.williamson@redhat.com,
	armbru@redhat.com, kvm@vger.kernel.org, mst@redhat.com
Subject: [Qemu-devel] [PATCHv3 04/14] Add get_fw_dev_path callback to ISA bus in qdev.
Date: Wed, 10 Nov 2010 19:14:11 +0200	[thread overview]
Message-ID: <1289409261-5418-5-git-send-email-gleb@redhat.com> (raw)
In-Reply-To: <1289409261-5418-1-git-send-email-gleb@redhat.com>

Use device ioports to create unique device path.

Signed-off-by: Gleb Natapov <gleb@redhat.com>
---
 hw/isa-bus.c |   15 +++++++++++++++
 1 files changed, 15 insertions(+), 0 deletions(-)

diff --git a/hw/isa-bus.c b/hw/isa-bus.c
index c0ac7e9..741d28e 100644
--- a/hw/isa-bus.c
+++ b/hw/isa-bus.c
@@ -31,11 +31,13 @@ static ISABus *isabus;
 target_phys_addr_t isa_mem_base = 0;
 
 static void isabus_dev_print(Monitor *mon, DeviceState *dev, int indent);
+static char *isabus_get_fw_dev_path(DeviceState *dev);
 
 static struct BusInfo isa_bus_info = {
     .name      = "ISA",
     .size      = sizeof(ISABus),
     .print_dev = isabus_dev_print,
+    .get_fw_dev_path = isabus_get_fw_dev_path,
 };
 
 ISABus *isa_bus_new(DeviceState *dev)
@@ -188,4 +190,17 @@ static void isabus_register_devices(void)
     sysbus_register_withprop(&isabus_bridge_info);
 }
 
+static char *isabus_get_fw_dev_path(DeviceState *dev)
+{
+    ISADevice *d = (ISADevice*)dev;
+    char path[40];
+    int off;
+
+    off = snprintf(path, sizeof(path), "%s", qdev_fw_name(dev));
+    if (d->nioports)
+        snprintf(path + off, sizeof(path) - off, "@%04x", d->ioports[0]);
+
+    return strdup(path);
+}
+
 device_init(isabus_register_devices)
-- 
1.7.1

  parent reply	other threads:[~2010-11-10 17:14 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-10 17:14 [Qemu-devel] [PATCHv3 00/14] boot order specification Gleb Natapov
2010-11-10 17:14 ` [Qemu-devel] [PATCHv3 01/14] Introduce fw_name field to DeviceInfo structure Gleb Natapov
2010-11-10 17:14 ` [Qemu-devel] [PATCHv3 02/14] Introduce new BusInfo callback get_fw_dev_path Gleb Natapov
2010-11-10 17:14 ` [Qemu-devel] [PATCHv3 03/14] Keep track of ISA ports ISA device is using in qdev Gleb Natapov
2010-11-11 10:14   ` [Qemu-devel] " Gerd Hoffmann
2010-11-11 10:22     ` Gleb Natapov
2010-11-10 17:14 ` Gleb Natapov [this message]
2010-11-10 18:34   ` [Qemu-devel] Re: [PATCHv3 04/14] Add get_fw_dev_path callback to ISA bus " Blue Swirl
2010-11-10 17:14 ` [Qemu-devel] [PATCHv3 05/14] Store IDE bus id in IDEBus structure for easy access Gleb Natapov
2010-11-10 17:14 ` [Qemu-devel] [PATCHv3 06/14] Add get_fw_dev_path callback to IDE bus Gleb Natapov
2010-11-10 17:14 ` [Qemu-devel] [PATCHv3 07/14] Add get_dev_path callback for system bus Gleb Natapov
2010-11-10 17:14 ` [Qemu-devel] [PATCHv3 08/14] Add get_fw_dev_path callback for pci bus Gleb Natapov
2010-11-10 17:34   ` [Qemu-devel] " Michael S. Tsirkin
2010-11-10 18:02     ` Gleb Natapov
2010-11-10 18:21       ` Michael S. Tsirkin
2010-11-10 18:25         ` Blue Swirl
2010-11-10 18:33         ` Gleb Natapov
2010-11-11 10:07     ` Gerd Hoffmann
2010-11-11 10:17       ` Gleb Natapov
2010-11-11 11:00         ` Gerd Hoffmann
2010-11-11 15:05       ` Michael S. Tsirkin
2010-11-11 16:07         ` Gleb Natapov
2010-11-11 17:14           ` Michael S. Tsirkin
2010-11-10 17:14 ` [Qemu-devel] [PATCHv3 09/14] Record which USBDevice USBPort belongs too Gleb Natapov
2010-11-10 17:14 ` [Qemu-devel] [PATCHv3 10/14] Add get_dev_path callback for usb bus Gleb Natapov
2010-11-10 18:37   ` [Qemu-devel] " Blue Swirl
2010-11-10 19:11     ` Gleb Natapov
2010-11-10 17:14 ` [Qemu-devel] [PATCHv3 11/14] Add bootindex parameter to net/block/fd device Gleb Natapov
2010-11-10 18:32   ` [Qemu-devel] " Blue Swirl
2010-11-10 18:48     ` Gleb Natapov
2010-11-10 17:14 ` [Qemu-devel] [PATCHv3 12/14] Add bootindex parameter to pci assigned device Gleb Natapov
2010-11-10 17:14 ` [Qemu-devel] [PATCHv3 13/14] Add notifier that will be called when machine is fully created Gleb Natapov
2010-11-10 17:14 ` [Qemu-devel] [PATCHv3 14/14] Pass boot device list to firmware Gleb Natapov
2010-11-10 18:50   ` [Qemu-devel] " Blue Swirl
2010-11-10 19:11   ` Blue Swirl
2010-11-10 19:16     ` Gleb Natapov
2010-11-10 19:20       ` Blue Swirl
2010-11-11  7:03         ` Gleb Natapov
2010-11-10 18:08 ` [Qemu-devel] Re: [PATCHv3 00/14] boot order specification Blue Swirl
2010-11-10 18:19   ` Gleb Natapov
2010-11-11 10:21 ` Gerd Hoffmann
2010-11-11 18:41   ` Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1289409261-5418-5-git-send-email-gleb@redhat.com \
    --to=gleb@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=armbru@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).