From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: agl@linux.vnet.ibm.com, abeekhof@redhat.com,
mdroth@linux.vnet.ibm.com, aliguori@linux.vnet.ibm.com,
ryanh@us.ibm.com, amit.shah@redhat.com
Subject: [Qemu-devel] [RFC][PATCH v2 14/19] virtproxy: add read handler for proxied connections
Date: Wed, 10 Nov 2010 16:28:10 -0600 [thread overview]
Message-ID: <1289428095-5059-15-git-send-email-mdroth@linux.vnet.ibm.com> (raw)
In-Reply-To: <1289428095-5059-1-git-send-email-mdroth@linux.vnet.ibm.com>
reads data from client/server connections as they become readable, then
sends the data over the channel
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
---
virtproxy.c | 80 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 files changed, 80 insertions(+), 0 deletions(-)
diff --git a/virtproxy.c b/virtproxy.c
index b683ee6..1807c88 100644
--- a/virtproxy.c
+++ b/virtproxy.c
@@ -233,6 +233,86 @@ static VPIForward *get_iforward(const VPDriver *drv, const char *service_id)
return NULL;
}
+/* read handler for proxied connections */
+static void vp_conn_read(void *opaque)
+{
+ VPConn *conn = opaque;
+ VPDriver *drv = conn->drv;
+ VPPacket pkt;
+ char buf[VP_CONN_DATA_LEN];
+ int fd, count, ret;
+ bool client;
+
+ TRACE("called with opaque: %p, drv: %p", opaque, drv);
+
+ if (conn->state != VP_STATE_CONNECTED) {
+ LOG("invalid connection state");
+ return;
+ }
+
+ if (conn->type != VP_CONN_CLIENT && conn->type != VP_CONN_SERVER) {
+ LOG("invalid connection type");
+ return;
+ }
+
+ /* TODO: all fields should be explicitly set so we shouldn't
+ * need to memset. this might hurt if we beef up VPPacket size
+ */
+ memset(&pkt, 0, sizeof(VPPacket));
+ pkt.magic = VP_MAGIC;
+
+ if (conn->type == VP_CONN_CLIENT) {
+ client = true;
+ fd = conn->client_fd;
+ } else {
+ client = false;
+ fd = conn->server_fd;
+ }
+
+ count = read(fd, buf, VP_CONN_DATA_LEN);
+ if (count == -1) {
+ LOG("read() failed: %s", strerror(errno));
+ return;
+ } else if (count == 0) {
+ /* connection closed, tell remote end to clean up */
+ TRACE("connection closed");
+ pkt.type = VP_PKT_CONTROL;
+ pkt.payload.msg.type = VP_CONTROL_CLOSE;
+ if (client) {
+ /* we're closing the client, have remote close the server conn */
+ TRACE("closing connection for client fd %d", conn->client_fd);
+ pkt.payload.msg.args.close.client_fd = -1;
+ pkt.payload.msg.args.close.server_fd = conn->server_fd;
+ } else {
+ TRACE("closing connection for server fd %d", conn->server_fd);
+ pkt.payload.msg.args.close.server_fd = -1;
+ pkt.payload.msg.args.close.client_fd = conn->client_fd;;
+ }
+ /* clean up things on our end */
+ closesocket(fd);
+ vp_set_fd_handler(fd, NULL, NULL, NULL);
+ QLIST_REMOVE(conn, next);
+ qemu_free(conn);
+ } else {
+ TRACE("data read");
+ pkt.type = client ? VP_PKT_CLIENT : VP_PKT_SERVER;
+ pkt.payload.proxied.client_fd = conn->client_fd;
+ pkt.payload.proxied.server_fd = conn->server_fd;
+ memcpy(pkt.payload.proxied.data, buf, count);
+ pkt.payload.proxied.bytes = count;
+ }
+
+ ret = vp_channel_send_all(drv, (uint8_t*)&pkt, sizeof(VPPacket));
+ if (ret == -1) {
+ LOG("error sending data over channel");
+ return;
+ }
+ if (ret != sizeof(VPPacket)) {
+ TRACE("buffer full?");
+ return;
+ }
+}
+
/* accept handler for communication channel
*
* accept()s connection to communication channel (for sockets), and sets
--
1.7.0.4
next prev parent reply other threads:[~2010-11-10 22:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-10 22:27 [Qemu-devel] [RFC][PATCH v2 00/19] virtproxy: host/guest communication layer Michael Roth
2010-11-10 22:27 ` [Qemu-devel] [RFC][PATCH v2 01/19] virtproxy: base data structures and constants Michael Roth
2010-11-10 22:27 ` [Qemu-devel] [RFC][PATCH v2 02/19] virtproxy: qemu-vp, standalone daemon skeleton Michael Roth
2010-11-10 22:27 ` [Qemu-devel] [RFC][PATCH v2 03/19] virtproxy: add debug functions for virtproxy core Michael Roth
2010-11-10 22:28 ` [Qemu-devel] [RFC][PATCH v2 04/19] virtproxy: list look-up functions conns/oforwards/iforwards Michael Roth
2010-11-10 22:28 ` [Qemu-devel] [RFC][PATCH v2 05/19] virtproxy, add vp_channel_send_all Michael Roth
2010-11-10 22:28 ` [Qemu-devel] [RFC][PATCH v2 06/19] virtproxy: add accept handler for communication channel Michael Roth
2010-11-10 22:28 ` [Qemu-devel] [RFC][PATCH v2 07/19] virtproxy: add read " Michael Roth
2010-11-10 22:28 ` [Qemu-devel] [RFC][PATCH v2 08/19] virtproxy: add vp_new() VPDriver constructor Michael Roth
2010-11-10 22:28 ` [Qemu-devel] [RFC][PATCH v2 09/19] virtproxy: interfaces to set/remove/handle VPOForwards Michael Roth
2010-11-10 22:28 ` [Qemu-devel] [RFC][PATCH v2 10/19] virtproxy: add handler for data packets Michael Roth
2010-11-10 22:28 ` [Qemu-devel] [RFC][PATCH v2 11/19] virtproxy: add handler for control packet Michael Roth
2010-11-10 22:28 ` [Qemu-devel] [RFC][PATCH v2 12/19] virtproxy: add vp_handle_packet() Michael Roth
2010-11-10 22:28 ` [Qemu-devel] [RFC][PATCH v2 13/19] virtproxy: interfaces to set/remove VPIForwards Michael Roth
2010-11-10 22:28 ` Michael Roth [this message]
2010-11-10 22:28 ` [Qemu-devel] [RFC][PATCH v2 15/19] virtproxy: add virtproxy-builtin.c for compat defs Michael Roth
2010-11-10 22:28 ` [Qemu-devel] [RFC][PATCH v2 16/19] virtproxy: qemu integration, add virtproxy chardev Michael Roth
2010-11-10 22:28 ` [Qemu-devel] [RFC][PATCH v2 17/19] virtproxy: qemu integration, add virtproxy to Makefile.targets Michael Roth
2010-11-10 22:28 ` [Qemu-devel] [RFC][PATCH v2 18/19] virtproxy: qemu-vp, main logic Michael Roth
2010-11-10 22:28 ` [Qemu-devel] [RFC][PATCH v2 19/19] virtproxy: Makefile/configure changes to build qemu-vp Michael Roth
2010-11-10 23:47 ` [Qemu-devel] [RFC][PATCH v2 00/19] virtproxy: host/guest communication layer Michael Roth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289428095-5059-15-git-send-email-mdroth@linux.vnet.ibm.com \
--to=mdroth@linux.vnet.ibm.com \
--cc=abeekhof@redhat.com \
--cc=agl@linux.vnet.ibm.com \
--cc=aliguori@linux.vnet.ibm.com \
--cc=amit.shah@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=ryanh@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).