qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: agl@linux.vnet.ibm.com, abeekhof@redhat.com,
	mdroth@linux.vnet.ibm.com, aliguori@linux.vnet.ibm.com,
	ryanh@us.ibm.com, amit.shah@redhat.com
Subject: [Qemu-devel] [RFC][PATCH v2 05/19] virtproxy, add vp_channel_send_all
Date: Wed, 10 Nov 2010 16:28:01 -0600	[thread overview]
Message-ID: <1289428095-5059-6-git-send-email-mdroth@linux.vnet.ibm.com> (raw)
In-Reply-To: <1289428095-5059-1-git-send-email-mdroth@linux.vnet.ibm.com>

This handles sending of data to channel fd (qemu-vp in guest) or the
device associated with the virtproxy chardev for the host depending on
the context. vp_chr_read() wraps qemu_chr_read(), it'll be defined later
in virtproxy-builtin.c, and noop'd in the guest agent via qemu-vp.c.

Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
---
 virtproxy.c |   31 +++++++++++++++++++++++++++++++
 virtproxy.h |    1 +
 2 files changed, 32 insertions(+), 0 deletions(-)

diff --git a/virtproxy.c b/virtproxy.c
index 2cfd905..edca62e 100644
--- a/virtproxy.c
+++ b/virtproxy.c
@@ -152,6 +152,37 @@ static QemuOptsList vp_socket_opts = {
     },
 };
 
+static int vp_channel_send_all(VPDriver *drv, uint8_t *buf, int count)
+{
+    int ret;
+    CharDriverState *chr = drv->chr;
+
+    if (drv->chr != NULL) {
+        /* send data to guest via channel device's read handler */
+        vp_chr_read(chr, buf, count);
+        /* TODO: we assume here the full buffer was written to device
+         * due to the dev write handler being a void function.
+         * can we confirm? Do we need to?
+         */
+        ret = count;
+    } else if (drv->channel_fd != -1) {
+        /* send data to host via channel fd */
+        ret = vp_send_all(drv->channel_fd, buf, count);
+        if (ret == -1) {
+            LOG("error sending data");
+            goto out_bad;
+        }
+    } else {
+        LOG("driver in unknown state");
+        goto out_bad;
+    }
+
+    return ret;
+out_bad:
+    LOG("unable to send to channel");
+    return -1;
+}
+
 /* get VPConn by fd, "client" denotes whether to look for client or server */
 static VPConn *get_conn(const VPDriver *drv, int fd, bool client)
 {
diff --git a/virtproxy.h b/virtproxy.h
index 0203421..1a5e56a 100644
--- a/virtproxy.h
+++ b/virtproxy.h
@@ -30,5 +30,6 @@ int vp_set_fd_handler(int fd,
                         IOHandler *fd_read,
                         IOHandler *fd_write,
                         void *opaque);
+void vp_chr_read(CharDriverState *s, uint8_t *buf, int len);
 
 #endif /* VIRTPROXY_H */
-- 
1.7.0.4

  parent reply	other threads:[~2010-11-10 22:32 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-10 22:27 [Qemu-devel] [RFC][PATCH v2 00/19] virtproxy: host/guest communication layer Michael Roth
2010-11-10 22:27 ` [Qemu-devel] [RFC][PATCH v2 01/19] virtproxy: base data structures and constants Michael Roth
2010-11-10 22:27 ` [Qemu-devel] [RFC][PATCH v2 02/19] virtproxy: qemu-vp, standalone daemon skeleton Michael Roth
2010-11-10 22:27 ` [Qemu-devel] [RFC][PATCH v2 03/19] virtproxy: add debug functions for virtproxy core Michael Roth
2010-11-10 22:28 ` [Qemu-devel] [RFC][PATCH v2 04/19] virtproxy: list look-up functions conns/oforwards/iforwards Michael Roth
2010-11-10 22:28 ` Michael Roth [this message]
2010-11-10 22:28 ` [Qemu-devel] [RFC][PATCH v2 06/19] virtproxy: add accept handler for communication channel Michael Roth
2010-11-10 22:28 ` [Qemu-devel] [RFC][PATCH v2 07/19] virtproxy: add read " Michael Roth
2010-11-10 22:28 ` [Qemu-devel] [RFC][PATCH v2 08/19] virtproxy: add vp_new() VPDriver constructor Michael Roth
2010-11-10 22:28 ` [Qemu-devel] [RFC][PATCH v2 09/19] virtproxy: interfaces to set/remove/handle VPOForwards Michael Roth
2010-11-10 22:28 ` [Qemu-devel] [RFC][PATCH v2 10/19] virtproxy: add handler for data packets Michael Roth
2010-11-10 22:28 ` [Qemu-devel] [RFC][PATCH v2 11/19] virtproxy: add handler for control packet Michael Roth
2010-11-10 22:28 ` [Qemu-devel] [RFC][PATCH v2 12/19] virtproxy: add vp_handle_packet() Michael Roth
2010-11-10 22:28 ` [Qemu-devel] [RFC][PATCH v2 13/19] virtproxy: interfaces to set/remove VPIForwards Michael Roth
2010-11-10 22:28 ` [Qemu-devel] [RFC][PATCH v2 14/19] virtproxy: add read handler for proxied connections Michael Roth
2010-11-10 22:28 ` [Qemu-devel] [RFC][PATCH v2 15/19] virtproxy: add virtproxy-builtin.c for compat defs Michael Roth
2010-11-10 22:28 ` [Qemu-devel] [RFC][PATCH v2 16/19] virtproxy: qemu integration, add virtproxy chardev Michael Roth
2010-11-10 22:28 ` [Qemu-devel] [RFC][PATCH v2 17/19] virtproxy: qemu integration, add virtproxy to Makefile.targets Michael Roth
2010-11-10 22:28 ` [Qemu-devel] [RFC][PATCH v2 18/19] virtproxy: qemu-vp, main logic Michael Roth
2010-11-10 22:28 ` [Qemu-devel] [RFC][PATCH v2 19/19] virtproxy: Makefile/configure changes to build qemu-vp Michael Roth
2010-11-10 23:47 ` [Qemu-devel] [RFC][PATCH v2 00/19] virtproxy: host/guest communication layer Michael Roth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1289428095-5059-6-git-send-email-mdroth@linux.vnet.ibm.com \
    --to=mdroth@linux.vnet.ibm.com \
    --cc=abeekhof@redhat.com \
    --cc=agl@linux.vnet.ibm.com \
    --cc=aliguori@linux.vnet.ibm.com \
    --cc=amit.shah@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=ryanh@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).