From: Corentin Chary <corentincj@iksaif.net>
To: Qemu-development List <qemu-devel@nongnu.org>
Cc: Corentin Chary <corentincj@iksaif.net>,
Anthony Liguori <aliguori@linux.vnet.ibm.com>,
Alexander Graf <agraf@suse.de>,
Andre Przywara <andre.przywara@amd.com>
Subject: [Qemu-devel] [PATCH v2 01/15] vnc: don't set the quality if lossy encoding are disabled
Date: Thu, 11 Nov 2010 17:56:50 +0100 [thread overview]
Message-ID: <1289494624-12807-2-git-send-email-corentincj@iksaif.net> (raw)
In-Reply-To: <1289494624-12807-1-git-send-email-corentincj@iksaif.net>
This should not change the current behavior, but if any new
encoding try to use the tight quality, it will always be set
to -1 when lossy encodings are disabled.
Signed-off-by: Corentin Chary <corentincj@iksaif.net>
---
ui/vnc.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index 864342e..7391311 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -1780,7 +1780,9 @@ static void set_encodings(VncState *vs, int32_t *encodings, size_t n_encodings)
vs->tight.compression = (enc & 0x0F);
break;
case VNC_ENCODING_QUALITYLEVEL0 ... VNC_ENCODING_QUALITYLEVEL0 + 9:
- vs->tight.quality = (enc & 0x0F);
+ if (vs->vd->lossy) {
+ vs->tight.quality = (enc & 0x0F);
+ }
break;
default:
VNC_DEBUG("Unknown encoding: %d (0x%.8x): %d\n", i, enc, enc);
--
1.7.3.2
next prev parent reply other threads:[~2010-11-11 16:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-11 16:56 [Qemu-devel] [PATCH v2 00/15] vnc: adapative tight, zrle, zywrle, and bitmap module Corentin Chary
2010-11-11 16:56 ` Corentin Chary [this message]
2010-11-11 16:56 ` [Qemu-devel] [PATCH v2 02/15] vnc: add a way to get the update frequency for a given region Corentin Chary
2010-11-11 16:56 ` [Qemu-devel] [PATCH v2 03/15] vnc: refresh lossy rect after a given timeout Corentin Chary
2010-11-11 18:44 ` Blue Swirl
2010-11-11 16:56 ` [Qemu-devel] [PATCH v2 04/15] vnc: tight: use the update frequency to choose between lossy and lossless Corentin Chary
2010-11-11 16:56 ` [Qemu-devel] [PATCH v2 05/15] vnc: palette: use a pool to reduce memory allocations Corentin Chary
2010-11-11 16:56 ` [Qemu-devel] [PATCH v2 06/15] vnc: palette: add palette_init calls Corentin Chary
2010-11-11 16:56 ` [Qemu-devel] [PATCH v2 07/15] vnc: palette: and fill and color calls Corentin Chary
2010-11-11 16:56 ` [Qemu-devel] [PATCH v2 08/15] vnc: Add ZRLE and ZYWRLE encodings Corentin Chary
2010-11-11 18:58 ` Blue Swirl
2010-11-11 16:56 ` [Qemu-devel] [PATCH v2 09/15] vnc: fix uint8_t comparisons with negative values Corentin Chary
2010-11-11 16:56 ` [Qemu-devel] [PATCH v2 10/15] vnc: fix lossy rect refreshing Corentin Chary
2010-11-11 16:57 ` [Qemu-devel] [PATCH v2 11/15] bitmap: add a generic bitmap and bitops library Corentin Chary
2010-11-11 19:07 ` Blue Swirl
2010-11-11 21:25 ` Corentin Chary
2010-11-11 16:57 ` [Qemu-devel] [PATCH v2 12/15] vnc: use the new generic bitmap functions Corentin Chary
2010-11-11 16:57 ` [Qemu-devel] [PATCH v2 13/15] vnc: don't try to send bigger updates that client height Corentin Chary
2010-11-11 16:57 ` [Qemu-devel] [PATCH v2 14/15] vnc: tight: tweak adaptive tight settings Corentin Chary
2010-11-11 16:57 ` [Qemu-devel] [PATCH v2 15/15] vnc: add a non-adaptive option Corentin Chary
2010-11-11 17:02 ` [Qemu-devel] Re: [PATCH v2 00/15] vnc: adapative tight, zrle, zywrle, and bitmap module Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289494624-12807-2-git-send-email-corentincj@iksaif.net \
--to=corentincj@iksaif.net \
--cc=agraf@suse.de \
--cc=aliguori@linux.vnet.ibm.com \
--cc=andre.przywara@amd.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).