qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 10/14] reorganize sdl-config tests
Date: Sun, 14 Nov 2010 12:48:58 +0100	[thread overview]
Message-ID: <1289735342-8660-11-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1289735342-8660-1-git-send-email-pbonzini@redhat.com>

This also allows overriding it with SDL_CONFIG, and warning in suspicious
cross-compilation scenarios.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 configure |   26 +++++++++++++-------------
 1 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/configure b/configure
index 4556a1d..2d2d306 100755
--- a/configure
+++ b/configure
@@ -208,6 +208,7 @@ ld="${cross_prefix}${LD-ld}"
 strip="${cross_prefix}${STRIP-strip}"
 windres="${cross_prefix}${WINDRES-windres}"
 pkg_config="${cross_prefix}${PKG_CONFIG-pkg-config}"
+sdl_config="${cross_prefix}${SDL_CONFIG-sdl-config}"
 
 # default flags for all hosts
 QEMU_CFLAGS="-fno-strict-aliasing $QEMU_CFLAGS"
@@ -1176,21 +1177,17 @@ fi
 ##########################################
 # SDL probe
 
-# Look for sdl configuration program (pkg-config or sdl-config).
-# Prefer variant with cross prefix if cross compiling,
-# and favour pkg-config with sdl over sdl-config.
-if test -n "$cross_prefix" -a $pkg_config != pkg-config && \
-     $pkg_config sdl --modversion >/dev/null 2>&1; then
-  sdlconfig="$pkg_config sdl"
-  _sdlversion=`$sdlconfig --modversion 2>/dev/null | sed 's/[^0-9]//g'`
-elif test -n "$cross_prefix" && has ${cross_prefix}sdl-config; then
-  sdlconfig="${cross_prefix}sdl-config"
-  _sdlversion=`$sdlconfig --version | sed 's/[^0-9]//g'`
-elif $pkg_config sdl --modversion >/dev/null 2>&1; then
+# Look for sdl configuration program (pkg-config or sdl-config).  Try
+# sdl-config even without cross prefix, and favour pkg-config over sdl-config.
+if test "`basename $sdl_config`" != sdl-config && ! has ${sdl_config}; then
+  sdl_config=sdl-config
+fi
+
+if $pkg_config sdl --modversion >/dev/null 2>&1; then
   sdlconfig="$pkg_config sdl"
   _sdlversion=`$sdlconfig --modversion 2>/dev/null | sed 's/[^0-9]//g'`
-elif has sdl-config; then
-  sdlconfig='sdl-config'
+elif has ${sdl_config}; then
+  sdlconfig="$sdl_config"
   _sdlversion=`$sdlconfig --version | sed 's/[^0-9]//g'`
 else
   if test "$sdl" = "yes" ; then
@@ -1198,6 +1195,9 @@ else
   fi
   sdl=no
 fi
+if test -n "$cross_prefix" && test "`basename $sdlconfig`" = sdl-config; then
+  echo warning: using "\"$sdlconfig\"" to detect cross-compiled sdl >&2
+fi
 
 sdl_too_old=no
 if test "$sdl" != "no" ; then
-- 
1.7.2.3

  parent reply	other threads:[~2010-11-14 11:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-14 11:48 [Qemu-devel] [PATCH 00/14] preparation for autoconfy configure script Paolo Bonzini
2010-11-14 11:48 ` [Qemu-devel] [PATCH 01/14] default compilation tools to environment variables Paolo Bonzini
2010-11-14 11:48 ` [Qemu-devel] [PATCH 02/14] default make and install " Paolo Bonzini
2010-11-14 11:48 ` [Qemu-devel] [PATCH 03/14] move feature variables to the top Paolo Bonzini
2010-11-14 11:48 ` [Qemu-devel] [PATCH 04/14] fix sparse support (?) Paolo Bonzini
2010-11-14 11:48 ` [Qemu-devel] [PATCH 05/14] test cc with the complete set of chosen flags Paolo Bonzini
2010-11-14 11:48 ` [Qemu-devel] [PATCH 06/14] do not pass bogus $(SRC_PATH) include paths to cc during configure Paolo Bonzini
2010-11-14 11:48 ` [Qemu-devel] [PATCH 07/14] provide portable HOST_LONG_BITS test Paolo Bonzini
2010-11-14 11:48 ` [Qemu-devel] [PATCH 08/14] fix spelling of $pkg_config, move default together with other cross tools Paolo Bonzini
2010-11-14 11:48 ` [Qemu-devel] [PATCH 09/14] do not default to non-prefixed pkg-config when cross compiling Paolo Bonzini
2010-11-14 11:48 ` Paolo Bonzini [this message]
2010-11-14 11:48 ` [Qemu-devel] [PATCH 11/14] assume existence of "ln -sf" Paolo Bonzini
2010-11-14 14:39   ` Blue Swirl
2010-11-14 14:57     ` Paolo Bonzini
2010-11-14 11:49 ` [Qemu-devel] [PATCH 12/14] simplify source_path handling Paolo Bonzini
2010-11-14 11:49 ` [Qemu-devel] [PATCH 13/14] move --srcdir detection earlier Paolo Bonzini
2010-11-14 11:49 ` [Qemu-devel] [PATCH 14/14] remove HOST_CC mention from roms/{sea, vga}bios/config.mak Paolo Bonzini
2010-11-14 20:10 ` [Qemu-devel] [PATCH 00/14] preparation for autoconfy configure script Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1289735342-8660-11-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).