qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 05/14] test cc with the complete set of chosen flags
Date: Sun, 14 Nov 2010 12:48:53 +0100	[thread overview]
Message-ID: <1289735342-8660-6-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1289735342-8660-1-git-send-email-pbonzini@redhat.com>

The "test the C compiler works ok" comes before a bunch of flags
are added for --cpu or just depending on the host.  It helps
debugging if the test is done after these flags are (unconditionally)
added.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 configure |   50 +++++++++++++++++++++++++-------------------------
 1 files changed, 25 insertions(+), 25 deletions(-)

diff --git a/configure b/configure
index 47a7525..b11bb44 100755
--- a/configure
+++ b/configure
@@ -218,31 +218,6 @@ QEMU_CFLAGS="-D_FORTIFY_SOURCE=2 $QEMU_CFLAGS"
 QEMU_CFLAGS="-I. -I\$(SRC_PATH) $QEMU_CFLAGS"
 LDFLAGS="-g $LDFLAGS"
 
-gcc_flags="-Wold-style-declaration -Wold-style-definition -Wtype-limits"
-gcc_flags="-Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers $gcc_flags"
-gcc_flags="-Wmissing-include-dirs -Wempty-body -Wnested-externs $gcc_flags"
-gcc_flags="-fstack-protector-all $gcc_flags"
-cat > $TMPC << EOF
-int main(void) { return 0; }
-EOF
-for flag in $gcc_flags; do
-    if compile_prog "-Werror $QEMU_CFLAGS" "-Werror $flag" ; then
-	QEMU_CFLAGS="$QEMU_CFLAGS $flag"
-    fi
-done
-
-# check that the C compiler works.
-cat > $TMPC <<EOF
-int main(void) {}
-EOF
-
-if compile_object ; then
-  : C compiler works ok
-else
-    echo "ERROR: \"$cc\" either does not exist or does not work"
-    exit 1
-fi
-
 check_define() {
 cat > $TMPC <<EOF
 #if !defined($1)
@@ -934,6 +909,31 @@ echo "NOTE: The object files are built at the place where configure is launched"
 exit 1
 fi
 
+# check that the C compiler works.
+cat > $TMPC <<EOF
+int main(void) {}
+EOF
+
+if compile_object ; then
+  : C compiler works ok
+else
+    echo "ERROR: \"$cc\" either does not exist or does not work"
+    exit 1
+fi
+
+gcc_flags="-Wold-style-declaration -Wold-style-definition -Wtype-limits"
+gcc_flags="-Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers $gcc_flags"
+gcc_flags="-Wmissing-include-dirs -Wempty-body -Wnested-externs $gcc_flags"
+gcc_flags="-fstack-protector-all $gcc_flags"
+cat > $TMPC << EOF
+int main(void) { return 0; }
+EOF
+for flag in $gcc_flags; do
+    if compile_prog "-Werror $QEMU_CFLAGS" "-Werror $flag" ; then
+	QEMU_CFLAGS="$QEMU_CFLAGS $flag"
+    fi
+done
+
 #
 # Solaris specific configure tool chain decisions
 #
-- 
1.7.2.3

  parent reply	other threads:[~2010-11-14 11:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-14 11:48 [Qemu-devel] [PATCH 00/14] preparation for autoconfy configure script Paolo Bonzini
2010-11-14 11:48 ` [Qemu-devel] [PATCH 01/14] default compilation tools to environment variables Paolo Bonzini
2010-11-14 11:48 ` [Qemu-devel] [PATCH 02/14] default make and install " Paolo Bonzini
2010-11-14 11:48 ` [Qemu-devel] [PATCH 03/14] move feature variables to the top Paolo Bonzini
2010-11-14 11:48 ` [Qemu-devel] [PATCH 04/14] fix sparse support (?) Paolo Bonzini
2010-11-14 11:48 ` Paolo Bonzini [this message]
2010-11-14 11:48 ` [Qemu-devel] [PATCH 06/14] do not pass bogus $(SRC_PATH) include paths to cc during configure Paolo Bonzini
2010-11-14 11:48 ` [Qemu-devel] [PATCH 07/14] provide portable HOST_LONG_BITS test Paolo Bonzini
2010-11-14 11:48 ` [Qemu-devel] [PATCH 08/14] fix spelling of $pkg_config, move default together with other cross tools Paolo Bonzini
2010-11-14 11:48 ` [Qemu-devel] [PATCH 09/14] do not default to non-prefixed pkg-config when cross compiling Paolo Bonzini
2010-11-14 11:48 ` [Qemu-devel] [PATCH 10/14] reorganize sdl-config tests Paolo Bonzini
2010-11-14 11:48 ` [Qemu-devel] [PATCH 11/14] assume existence of "ln -sf" Paolo Bonzini
2010-11-14 14:39   ` Blue Swirl
2010-11-14 14:57     ` Paolo Bonzini
2010-11-14 11:49 ` [Qemu-devel] [PATCH 12/14] simplify source_path handling Paolo Bonzini
2010-11-14 11:49 ` [Qemu-devel] [PATCH 13/14] move --srcdir detection earlier Paolo Bonzini
2010-11-14 11:49 ` [Qemu-devel] [PATCH 14/14] remove HOST_CC mention from roms/{sea, vga}bios/config.mak Paolo Bonzini
2010-11-14 20:10 ` [Qemu-devel] [PATCH 00/14] preparation for autoconfy configure script Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1289735342-8660-6-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).