From: Gleb Natapov <gleb@redhat.com>
To: qemu-devel@nongnu.org
Cc: kvm@vger.kernel.org, mst@redhat.com, armbru@redhat.com,
blauwirbel@gmail.com, alex.williamson@redhat.com,
kevin@koconnor.net
Subject: [Qemu-devel] [PATCHv5 09/15] Record which USBDevice USBPort belongs too.
Date: Mon, 15 Nov 2010 16:31:03 +0200 [thread overview]
Message-ID: <1289831469-25540-10-git-send-email-gleb@redhat.com> (raw)
In-Reply-To: <1289831469-25540-1-git-send-email-gleb@redhat.com>
Ports on root hub will have NULL here. This is needed to reconstruct
path from device to its root hub to build device path.
Signed-off-by: Gleb Natapov <gleb@redhat.com>
---
hw/usb-bus.c | 3 ++-
hw/usb-hub.c | 2 +-
hw/usb-musb.c | 2 +-
hw/usb-ohci.c | 2 +-
hw/usb-uhci.c | 2 +-
hw/usb.h | 3 ++-
6 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/hw/usb-bus.c b/hw/usb-bus.c
index b692503..256b881 100644
--- a/hw/usb-bus.c
+++ b/hw/usb-bus.c
@@ -110,11 +110,12 @@ USBDevice *usb_create_simple(USBBus *bus, const char *name)
}
void usb_register_port(USBBus *bus, USBPort *port, void *opaque, int index,
- usb_attachfn attach)
+ USBDevice *pdev, usb_attachfn attach)
{
port->opaque = opaque;
port->index = index;
port->attach = attach;
+ port->pdev = pdev;
QTAILQ_INSERT_TAIL(&bus->free, port, next);
bus->nfree++;
}
diff --git a/hw/usb-hub.c b/hw/usb-hub.c
index 8e3a96b..8a3f829 100644
--- a/hw/usb-hub.c
+++ b/hw/usb-hub.c
@@ -535,7 +535,7 @@ static int usb_hub_initfn(USBDevice *dev)
for (i = 0; i < s->nb_ports; i++) {
port = &s->ports[i];
usb_register_port(usb_bus_from_device(dev),
- &port->port, s, i, usb_hub_attach);
+ &port->port, s, i, &s->dev, usb_hub_attach);
port->wPortStatus = PORT_STAT_POWER;
port->wPortChange = 0;
}
diff --git a/hw/usb-musb.c b/hw/usb-musb.c
index 7f15842..9efe7a6 100644
--- a/hw/usb-musb.c
+++ b/hw/usb-musb.c
@@ -343,7 +343,7 @@ struct MUSBState {
}
usb_bus_new(&s->bus, NULL /* FIXME */);
- usb_register_port(&s->bus, &s->port, s, 0, musb_attach);
+ usb_register_port(&s->bus, &s->port, s, 0, NULL, musb_attach);
return s;
}
diff --git a/hw/usb-ohci.c b/hw/usb-ohci.c
index c60fd8d..59604cf 100644
--- a/hw/usb-ohci.c
+++ b/hw/usb-ohci.c
@@ -1705,7 +1705,7 @@ static void usb_ohci_init(OHCIState *ohci, DeviceState *dev,
usb_bus_new(&ohci->bus, dev);
ohci->num_ports = num_ports;
for (i = 0; i < num_ports; i++) {
- usb_register_port(&ohci->bus, &ohci->rhport[i].port, ohci, i, ohci_attach);
+ usb_register_port(&ohci->bus, &ohci->rhport[i].port, ohci, i, NULL, ohci_attach);
}
ohci->async_td = 0;
diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c
index 1d83400..b9b822f 100644
--- a/hw/usb-uhci.c
+++ b/hw/usb-uhci.c
@@ -1115,7 +1115,7 @@ static int usb_uhci_common_initfn(UHCIState *s)
usb_bus_new(&s->bus, &s->dev.qdev);
for(i = 0; i < NB_PORTS; i++) {
- usb_register_port(&s->bus, &s->ports[i].port, s, i, uhci_attach);
+ usb_register_port(&s->bus, &s->ports[i].port, s, i, NULL, uhci_attach);
}
s->frame_timer = qemu_new_timer(vm_clock, uhci_frame_timer, s);
s->expire_time = qemu_get_clock(vm_clock) +
diff --git a/hw/usb.h b/hw/usb.h
index 00d2802..0b32d77 100644
--- a/hw/usb.h
+++ b/hw/usb.h
@@ -203,6 +203,7 @@ struct USBPort {
USBDevice *dev;
usb_attachfn attach;
void *opaque;
+ USBDevice *pdev;
int index; /* internal port index, may be used with the opaque */
QTAILQ_ENTRY(USBPort) next;
};
@@ -312,7 +313,7 @@ USBDevice *usb_create(USBBus *bus, const char *name);
USBDevice *usb_create_simple(USBBus *bus, const char *name);
USBDevice *usbdevice_create(const char *cmdline);
void usb_register_port(USBBus *bus, USBPort *port, void *opaque, int index,
- usb_attachfn attach);
+ USBDevice *pdev, usb_attachfn attach);
void usb_unregister_port(USBBus *bus, USBPort *port);
int usb_device_attach(USBDevice *dev);
int usb_device_detach(USBDevice *dev);
--
1.7.1
next prev parent reply other threads:[~2010-11-15 14:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-15 14:30 [Qemu-devel] [PATCHv5 00/15] boot order specification Gleb Natapov
2010-11-15 14:30 ` [Qemu-devel] [PATCHv5 01/15] Introduce fw_name field to DeviceInfo structure Gleb Natapov
2010-11-16 8:09 ` Isaku Yamahata
2010-11-16 8:59 ` Gleb Natapov
2010-11-15 14:30 ` [Qemu-devel] [PATCHv5 02/15] Introduce new BusInfo callback get_fw_dev_path Gleb Natapov
2010-11-15 14:30 ` [Qemu-devel] [PATCHv5 03/15] Keep track of ISA ports ISA device is using in qdev Gleb Natapov
2010-11-15 14:30 ` [Qemu-devel] [PATCHv5 04/15] Add get_fw_dev_path callback to ISA bus " Gleb Natapov
2010-11-15 14:30 ` [Qemu-devel] [PATCHv5 05/15] Store IDE bus id in IDEBus structure for easy access Gleb Natapov
2010-11-15 14:31 ` [Qemu-devel] [PATCHv5 06/15] Add get_fw_dev_path callback to IDE bus Gleb Natapov
2010-11-15 14:31 ` [Qemu-devel] [PATCHv5 07/15] Add get_dev_path callback for system bus Gleb Natapov
2010-11-15 14:31 ` [Qemu-devel] [PATCHv5 08/15] Add get_fw_dev_path callback for pci bus Gleb Natapov
2010-11-15 14:31 ` Gleb Natapov [this message]
2010-11-15 14:31 ` [Qemu-devel] [PATCHv5 10/15] Add get_dev_path callback for usb bus Gleb Natapov
2010-11-15 14:31 ` [Qemu-devel] [PATCHv5 11/15] Add bootindex parameter to net/block/fd device Gleb Natapov
2010-11-15 14:31 ` [Qemu-devel] [PATCHv5 12/15] Change fw_cfg_add_file() to get full file path as a parameter Gleb Natapov
2010-11-15 14:31 ` [Qemu-devel] [PATCHv5 13/15] Add bootindex for option roms Gleb Natapov
2010-11-15 14:31 ` [Qemu-devel] [PATCHv5 14/15] Add notifier that will be called when machine is fully created Gleb Natapov
2010-11-15 14:31 ` [Qemu-devel] [PATCHv5 15/15] Pass boot device list to firmware Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289831469-25540-10-git-send-email-gleb@redhat.com \
--to=gleb@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=armbru@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=kevin@koconnor.net \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).