qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH 3/3] vga: tag as not hotplugable.
Date: Thu, 18 Nov 2010 11:45:18 +0100	[thread overview]
Message-ID: <1290077118-11577-4-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1290077118-11577-1-git-send-email-kraxel@redhat.com>

This patch tags all vga cards as not hotpluggable.  The qemu
standard vga will never ever be hotpluggable.  For cirrus + vmware
it might be possible to get that work some day.  Todays we can't
handle that for a number of reasons though.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/cirrus_vga.c |    1 +
 hw/vga-pci.c    |    1 +
 hw/vmware_vga.c |    1 +
 3 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c
index b473759..0577e94 100644
--- a/hw/cirrus_vga.c
+++ b/hw/cirrus_vga.c
@@ -3227,6 +3227,7 @@ static PCIDeviceInfo cirrus_vga_info = {
     .qdev.desc    = "Cirrus CLGD 54xx VGA",
     .qdev.size    = sizeof(PCICirrusVGAState),
     .qdev.vmsd    = &vmstate_pci_cirrus_vga,
+    .qdev.no_hotplug = 1,
     .init         = pci_cirrus_vga_initfn,
     .romfile      = VGABIOS_CIRRUS_FILENAME,
     .config_write = pci_cirrus_write_config,
diff --git a/hw/vga-pci.c b/hw/vga-pci.c
index 4931eee..31e82d5 100644
--- a/hw/vga-pci.c
+++ b/hw/vga-pci.c
@@ -114,6 +114,7 @@ static PCIDeviceInfo vga_info = {
     .qdev.name    = "VGA",
     .qdev.size    = sizeof(PCIVGAState),
     .qdev.vmsd    = &vmstate_vga_pci,
+    .qdev.no_hotplug = 1,
     .init         = pci_vga_initfn,
     .config_write = pci_vga_write_config,
     .romfile      = "vgabios-stdvga.bin",
diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c
index e852620..4a0525f 100644
--- a/hw/vmware_vga.c
+++ b/hw/vmware_vga.c
@@ -1322,6 +1322,7 @@ static PCIDeviceInfo vmsvga_info = {
     .qdev.name    = "vmware-svga",
     .qdev.size    = sizeof(struct pci_vmsvga_state_s),
     .qdev.vmsd    = &vmstate_vmware_vga,
+    .qdev.no_hotplug = 1,
     .init         = pci_vmsvga_initfn,
     .romfile      = "vgabios-vmware.bin",
 };
-- 
1.7.1

  parent reply	other threads:[~2010-11-18 10:45 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-18 10:45 [Qemu-devel] [PATCH 0/3] add hotplug opt-out option for devices Gerd Hoffmann
2010-11-18 10:45 ` [Qemu-devel] [PATCH 1/3] qdev: allow devices being tagged as not hotpluggable Gerd Hoffmann
2010-11-18 10:45 ` [Qemu-devel] [PATCH 2/3] piix: tag " Gerd Hoffmann
2010-11-18 10:45 ` Gerd Hoffmann [this message]
2010-11-18 11:01 ` [Qemu-devel] [PATCH 0/3] add hotplug opt-out option for devices Gleb Natapov
2010-11-18 11:13   ` Gerd Hoffmann
2010-11-18 11:20     ` Gleb Natapov
2010-11-18 11:29       ` Gerd Hoffmann
2010-11-18 11:42         ` Gleb Natapov
2010-11-18 12:07           ` Michael Tokarev
2010-11-18 12:16             ` Gleb Natapov
2010-11-20  2:30 ` Anthony Liguori
2010-11-20 17:24   ` Gleb Natapov
2010-11-22 10:17   ` Gerd Hoffmann
2010-11-22 13:31     ` Gleb Natapov
2010-12-10 12:34     ` Markus Armbruster
2010-12-10 14:04       ` Gerd Hoffmann
  -- strict thread matches above, loose matches on Subject: below --
2010-11-30 13:26 [Qemu-devel] [PATCH 0/3] add hotplug opt-out option for pci devices Gerd Hoffmann
2010-11-30 13:26 ` [Qemu-devel] [PATCH 3/3] vga: tag as not hotplugable Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1290077118-11577-4-git-send-email-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).