From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49023)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1cePxE-0003kT-Cw
	for qemu-devel@nongnu.org; Thu, 16 Feb 2017 12:34:53 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1cePxB-0007wy-AQ
	for qemu-devel@nongnu.org; Thu, 16 Feb 2017 12:34:52 -0500
Received: from mx5-phx2.redhat.com ([209.132.183.37]:41854)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <pbonzini@redhat.com>) id 1cePxB-0007v1-2I
	for qemu-devel@nongnu.org; Thu, 16 Feb 2017 12:34:49 -0500
Date: Thu, 16 Feb 2017 12:34:47 -0500 (EST)
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <1290195729.22930391.1487266487069.JavaMail.zimbra@redhat.com>
In-Reply-To: <CAFEAcA-na4tRT79jT+U8GgR8qekZUnxR2WyJzOE4dxzvFRPSDA@mail.gmail.com>
References: <1487255507-106654-1-git-send-email-pbonzini@redhat.com>
	<CAFEAcA-na4tRT79jT+U8GgR8qekZUnxR2WyJzOE4dxzvFRPSDA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 00/23] Misc patches for 2017-02-16
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>


> The problem is in the bit of the prototype the error message
> doesn't quote:
> 
> Prototype in cpu.h:
>   void cpu_vmexit(CPUX86State *nenv, uint32_t exit_code, uint64_t
>   exit_info_1,
>                   uintptr_t retaddr);
> 
> svm_helper.c stub version;
>   void cpu_vmexit(CPUX86State *nenv, uint32_t exit_code, uint64_t
>   exit_info_1,
>                   uint64_t retaddr)
> 
> svm_helper.c real version:
>   void cpu_vmexit(CPUX86State *env, uint32_t exit_code, uint64_t exit_info_1,
>                   uintptr_t retaddr)
> 
> On 32-bit uintptr_t and uint64_t aren't the same thing.

Saw the same on mingw, must have forgotten to "commit --amend".

Paolo