qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: QEMU-devel Developers <qemu-devel@nongnu.org>
Cc: Kevin Wolf <kwolf@redhat.com>,
	Joerg Roedel <Joerg.Roedel@amd.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Stefan Hajnoczi <stefanha@gmail.com>,
	tj@kernel.org, Roland Elek <elek.roland@gmail.com>,
	Sebastian Herbszt <herbszt@gmx.de>
Subject: [Qemu-devel] [PATCH 00/12] AHCI emulation support v4
Date: Tue, 23 Nov 2010 15:34:37 +0100	[thread overview]
Message-ID: <1290522889-27559-1-git-send-email-agraf@suse.de> (raw)

This patch adds support for AHCI emulation. I have tested and verified it works
in Linux, OpenBSD, Windows Vista and Windows 7. This AHCI emulation supports
NCQ, so multiple read or write requests can be outstanding at the same time.

The code is however not fully optimized yet. I'm fairly sure that there are
low hanging performance fruits to be found still :). In my simple benchmarks
I achieved about 2/3rd of virtio performance.

Also, this AHCI emulation layer does not support legacy mode. So if you're
using a disk with this emulation, you do not get it exposed using the legacy
IDE interfaces.

Another nitpick is CD-ROM support in Windows. Somehow it doesn't detect a
CD-ROM drive attached to AHCI. At least it doesn't list it.

To attach an AHCI disk to your VM, please use

  -drive file=...,if=sata

This should do the trick for x86. On other platforms, you need to add the
ahci host controller using -device and add CONFIG_AHCI to its default config.
Big endian hosts are still broken due to qemu shortcomings in mmio handing.
Expect patches to follow.


This patch set is based on work done during the Google Summer of Code. I was
mentoring a student, Roland Elek, who wrote most of the AHCI emulation code
based on a patch from Chong Qiao. A bunch of other people were also involved,
so everybody who I didn't mention - thanks a lot!

  git://repo.or.cz/qemu/ahci.git ahci

v1 -> v2:

  - rename IDEExtender to IDEBusOps and make a pointer (kraxel)
  - make dma hooks explicit by putting them into ops struct (stefanha)
  - use qdev buses (kraxel)
  - minor cleanups
  - dprintf overhaul
  - add reset function

v2 -> v3:

  - add msi support (kraxel)
  - use MIN macro (kraxel)
  - add msi support (kraxel)
  - fix ncq with multiple ports
  - zap qdev properties (kraxel)
  - redesign legacy IF_SATA hooks (kraxel)
  - don't build ahci as part of target
  - move to ide/ (kwolf)

v3 -> v4:

  - prepare for endianness safety
  - add lspci dump (herbszt)
  - use ich7 instead of ich7m (herbszt)
  - fix lst+fis mapping (kraxel)
  - coding style (blue swirl)
  - explicit mmio setters/getters (blue swirl)
  - split pata code out to pata.c (kwolf)
  - only include config-devices.h in machine description (blue swirl)


Alex

Alexander Graf (10):
  ide: split ide command interpretation off
  ide: fix whitespace gap in ide_exec_cmd
  ide: add DMA hooks to bus ops
  pci: add storage class for sata
  pci: add ich7 pci id
  ahci: add ahci emulation
  ahci: add -drive support
  config: Add header file for device config options
  ahci: spawn controller on demand
  ide: move pata specific parts to pata.c

Roland Elek (2):
  ide: add support for ide bus ops
  ide: add ncq identify data for ahci sata drives

 Makefile.objs                      |    3 +-
 Makefile.target                    |    5 +-
 blockdev.c                         |    6 +-
 blockdev.h                         |    1 +
 default-configs/i386-softmmu.mak   |    1 +
 default-configs/x86_64-softmmu.mak |    1 +
 hw/ide/ahci.c                      | 1397 ++++++++++++++++++++++++++++++++++++
 hw/ide/core.c                      |  874 ++++++++++-------------
 hw/ide/internal.h                  |   37 +-
 hw/ide/pata.c                      |  178 +++++
 hw/pc.h                            |    1 +
 hw/pc_piix.c                       |    4 +
 hw/pci.h                           |    1 +
 hw/pci_ids.h                       |    1 +
 qemu-common.h                      |    2 +-
 15 files changed, 2020 insertions(+), 492 deletions(-)
 create mode 100644 hw/ide/ahci.c
 create mode 100644 hw/ide/pata.c

             reply	other threads:[~2010-11-23 14:34 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-23 14:34 Alexander Graf [this message]
2010-11-23 14:34 ` [Qemu-devel] [PATCH 01/12] ide: split ide command interpretation off Alexander Graf
2010-11-23 14:34 ` [Qemu-devel] [PATCH 02/12] ide: fix whitespace gap in ide_exec_cmd Alexander Graf
2010-11-23 14:34 ` [Qemu-devel] [PATCH 03/12] ide: add support for ide bus ops Alexander Graf
2010-11-23 14:34 ` [Qemu-devel] [PATCH 04/12] ide: add DMA hooks to " Alexander Graf
2010-11-23 14:34 ` [Qemu-devel] [PATCH 05/12] ide: add ncq identify data for ahci sata drives Alexander Graf
2010-11-23 14:34 ` [Qemu-devel] [PATCH 06/12] pci: add storage class for sata Alexander Graf
2010-11-23 14:34 ` [Qemu-devel] [PATCH 07/12] pci: add ich7 pci id Alexander Graf
2010-11-23 14:34 ` [Qemu-devel] [PATCH 08/12] ahci: add ahci emulation Alexander Graf
2010-11-25 12:28   ` Paul Brook
2010-11-25 12:32     ` Alexander Graf
2010-11-25 12:45       ` Paul Brook
2010-11-25 12:47         ` Alexander Graf
2010-11-25 12:52           ` Paul Brook
2010-11-23 14:34 ` [Qemu-devel] [PATCH 09/12] ahci: add -drive support Alexander Graf
2010-11-23 14:34 ` [Qemu-devel] [PATCH 10/12] config: Add header file for device config options Alexander Graf
2010-11-23 19:21   ` Blue Swirl
2010-11-23 19:37     ` Alexander Graf
2010-11-24  2:22   ` [Qemu-devel] " Juan Quintela
2010-11-24 10:54     ` Alexander Graf
2010-11-24 20:45       ` Blue Swirl
2010-11-23 14:34 ` [Qemu-devel] [PATCH 11/12] ahci: spawn controller on demand Alexander Graf
2010-11-23 14:34 ` [Qemu-devel] [PATCH 12/12] ide: move pata specific parts to pata.c Alexander Graf
2010-11-24 11:44 ` [Qemu-devel] Re: [PATCH 00/12] AHCI emulation support v4 Gerd Hoffmann
2010-11-24 11:46   ` Alexander Graf
2010-12-01 23:29   ` Alexander Graf
2010-12-02 10:43     ` Gerd Hoffmann
2010-12-02 10:48       ` Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1290522889-27559-1-git-send-email-agraf@suse.de \
    --to=agraf@suse.de \
    --cc=Joerg.Roedel@amd.com \
    --cc=elek.roland@gmail.com \
    --cc=herbszt@gmx.de \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).