From: Peter Maydell <peter.maydell@linaro.org>
To: Anthony Liguori <anthony@codemonkey.ws>, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 08/12] ARM: Return correct result for single<->double conversion of NaN
Date: Tue, 23 Nov 2010 18:53:47 +0000 [thread overview]
Message-ID: <1290538431-13170-9-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1290538431-13170-1-git-send-email-peter.maydell@linaro.org>
The ARM ARM defines that if the input to a single<->double conversion
is a NaN then the output is always forced to be a quiet NaN by setting
the most significant bit of the fraction part.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
target-arm/helper.c | 18 ++++++++++++++++--
1 files changed, 16 insertions(+), 2 deletions(-)
diff --git a/target-arm/helper.c b/target-arm/helper.c
index 72ba314..356715c 100644
--- a/target-arm/helper.c
+++ b/target-arm/helper.c
@@ -2529,12 +2529,26 @@ float32 VFP_HELPER(tosiz, d)(float64 x, CPUState *env)
/* floating point conversion */
float64 VFP_HELPER(fcvtd, s)(float32 x, CPUState *env)
{
- return float32_to_float64(x, &env->vfp.fp_status);
+ float64 r = float32_to_float64(x, &env->vfp.fp_status);
+ /* ARM requires that S<->D conversion of any kind of NaN generates
+ * a quiet NaN by forcing the most significant frac bit to 1.
+ */
+ if (float64_is_signaling_nan(r)) {
+ return make_float64(float64_val(r) | (1LL << 51));
+ }
+ return r;
}
float32 VFP_HELPER(fcvts, d)(float64 x, CPUState *env)
{
- return float64_to_float32(x, &env->vfp.fp_status);
+ float32 r = float64_to_float32(x, &env->vfp.fp_status);
+ /* ARM requires that S<->D conversion of any kind of NaN generates
+ * a quiet NaN by forcing the most significant frac bit to 1.
+ */
+ if (float32_is_signaling_nan(r)) {
+ return make_float32(float32_val(r) | (1 << 22));
+ }
+ return r;
}
/* VFP3 fixed point conversion. */
--
1.6.3.3
next prev parent reply other threads:[~2010-11-23 18:54 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-23 18:53 [Qemu-devel] [PATCH 00/12] [PULL] ARM fixes Peter Maydell
2010-11-23 18:53 ` [Qemu-devel] [PATCH 01/12] target-arm: Add support for PKHxx in thumb2 Peter Maydell
2010-11-29 18:43 ` Nathan Froyd
2010-11-23 18:53 ` [Qemu-devel] [PATCH 02/12] target-arm: Fix mixup in decoding of saturating add and sub Peter Maydell
2010-11-29 17:01 ` Nathan Froyd
2010-11-23 18:53 ` [Qemu-devel] [PATCH 03/12] target-arm: Handle 'smc' as an undefined instruction Peter Maydell
2010-11-29 18:23 ` Nathan Froyd
2010-11-23 18:53 ` [Qemu-devel] [PATCH 04/12] ARM: Fix decoding of VFP forms of VCVT between float and int/fixed Peter Maydell
2010-11-23 18:53 ` [Qemu-devel] [PATCH 05/12] ARM: Fix decoding of Neon forms of VCVT between float and fixed point Peter Maydell
2010-11-29 18:11 ` Nathan Froyd
2010-11-23 18:53 ` [Qemu-devel] [PATCH 06/12] ARM: Fix sense of to_integer bit in Neon VCVT float/int conversion Peter Maydell
2010-11-29 16:34 ` Nathan Froyd
2010-11-23 18:53 ` [Qemu-devel] [PATCH 07/12] ARM: Return correct result for float-to-integer conversion of NaN Peter Maydell
2010-11-29 16:38 ` Nathan Froyd
2010-11-29 16:49 ` Peter Maydell
2010-11-29 16:58 ` Nathan Froyd
2010-11-23 18:53 ` Peter Maydell [this message]
2010-11-29 17:49 ` [Qemu-devel] [PATCH 08/12] ARM: Return correct result for single<->double " Nathan Froyd
2010-11-29 19:25 ` Peter Maydell
2010-11-29 19:54 ` Nathan Froyd
2010-11-29 20:04 ` Peter Maydell
2010-11-29 20:21 ` Nathan Froyd
2010-11-30 11:15 ` Peter Maydell
2010-12-01 15:39 ` Nathan Froyd
2010-12-01 17:52 ` Richard Henderson
2010-12-01 17:54 ` Nathan Froyd
2010-11-23 18:53 ` [Qemu-devel] [PATCH 09/12] ARM: Ignore top 16 bits when doing VCVT from 16 bit fixed point Peter Maydell
2010-11-29 17:02 ` Nathan Froyd
2010-11-23 18:53 ` [Qemu-devel] [PATCH 10/12] softfloat: Add float/double to 16 bit integer conversion functions Peter Maydell
2010-11-29 18:46 ` Nathan Froyd
2010-11-23 18:53 ` [Qemu-devel] [PATCH 11/12] ARM: Implement VCVT to 16 bit integer using new softfloat routines Peter Maydell
2010-11-29 18:47 ` Nathan Froyd
2010-11-23 18:53 ` [Qemu-devel] [PATCH 12/12] ARM: fix ldrexd/strexd Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290538431-13170-9-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).