* [Qemu-devel] [PATCH 2/5] [block]: Add BSG qemu_open() in block/raw.c:raw_open()
@ 2010-06-14 9:44 Nicholas A. Bellinger
0 siblings, 0 replies; 2+ messages in thread
From: Nicholas A. Bellinger @ 2010-06-14 9:44 UTC (permalink / raw)
To: Gerd Hoffmann, Kevin Wolf, FUJITA Tomonori
Cc: kvm-devel, qemu-devel, Nicholas Bellinger, Hannes Reinecke,
Christoph Hellwig, Paul Brook
From: Nicholas Bellinger <nab@linux-iscsi.org>
This patch adds a BSG specific qemu_open() call in block/raw.c:raw_open() that
saves the opened file descriptor for BSG AIO into BlockDriverState->fd.
It also adds the reverse close() call to block/raw.c:raw_close()
Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi.org>
---
block/raw.c | 20 ++++++++++++++++++++
1 files changed, 20 insertions(+), 0 deletions(-)
diff --git a/block/raw.c b/block/raw.c
index 4406b8c..7820c78 100644
--- a/block/raw.c
+++ b/block/raw.c
@@ -5,7 +5,25 @@
static int raw_open(BlockDriverState *bs, int flags)
{
+ int fd, ret;
+
bs->sg = bs->file->sg;
+ /*
+ * scsi-generic and other raw types do not call qemu_open()
+ */
+ if (bs->sg != BDS_BSG)
+ return 0;
+ /*
+ * Obtain a file descriptor for the underlying BSG device for AIO w/ iovecs
+ */
+ fd = qemu_open(bs->filename, flags, 0644);
+ if (fd < 0) {
+ ret = -errno;
+ if (ret == -EROFS)
+ ret = -EACCES;
+ return ret;
+ }
+ bs->fd = fd;
return 0;
}
@@ -37,6 +55,8 @@ static BlockDriverAIOCB *raw_aio_writev(BlockDriverState *bs,
static void raw_close(BlockDriverState *bs)
{
+ if (bs->fd > 0)
+ close(bs->fd);
}
static void raw_flush(BlockDriverState *bs)
--
1.5.6.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Qemu-devel] [PATCH 2/5] block: Add BSG qemu_open() in block/raw.c:raw_open()
@ 2010-11-24 8:40 Nicholas A. Bellinger
0 siblings, 0 replies; 2+ messages in thread
From: Nicholas A. Bellinger @ 2010-11-24 8:40 UTC (permalink / raw)
To: Hannes Reinecke, Kevin Wolf
Cc: qemu-devel, Stefan Hajnoczi, Gerd Hoffmann, Nicholas Bellinger,
Paolo Bonzini
From: Nicholas Bellinger <nab@linux-iscsi.org>
This patch adds a BSG specific qemu_open() call in block/raw.c:raw_open() that
saves the opened file descriptor for BSG AIO into BlockDriverState->fd.
It also adds the reverse close() call to block/raw.c:raw_close()
Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi.org>
---
block/raw.c | 21 +++++++++++++++++++++
1 files changed, 21 insertions(+), 0 deletions(-)
diff --git a/block/raw.c b/block/raw.c
index 1980deb..c6c1968 100644
--- a/block/raw.c
+++ b/block/raw.c
@@ -5,7 +5,26 @@
static int raw_open(BlockDriverState *bs, int flags)
{
+ int fd, ret;
+
bs->sg = bs->file->sg;
+ /*
+ * scsi-generic and other raw types do not call qemu_open()
+ */
+ if (bs->sg != BDS_BSG)
+ return 0;
+ /*
+ * Obtain a file descriptor for the underlying BSG device for AIO w/ iovecs
+ */
+ fd = qemu_open(bs->filename, flags, 0644);
+ if (fd < 0) {
+ ret = -errno;
+ if (ret == -EROFS)
+ ret = -EACCES;
+ return ret;
+ }
+ bs->fd = fd;
+
return 0;
}
@@ -37,6 +56,8 @@ static BlockDriverAIOCB *raw_aio_writev(BlockDriverState *bs,
static void raw_close(BlockDriverState *bs)
{
+ if (bs->fd > 0)
+ close(bs->fd);
}
static int raw_flush(BlockDriverState *bs)
--
1.5.6.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-11-24 8:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-24 8:40 [Qemu-devel] [PATCH 2/5] block: Add BSG qemu_open() in block/raw.c:raw_open() Nicholas A. Bellinger
-- strict thread matches above, loose matches on Subject: below --
2010-06-14 9:44 [Qemu-devel] [PATCH 2/5] [block]: " Nicholas A. Bellinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).