From: Alexander Graf <agraf@suse.de>
To: QEMU-devel Developers <qemu-devel@nongnu.org>
Cc: Kevin Wolf <kwolf@redhat.com>,
Joerg Roedel <Joerg.Roedel@amd.com>,
Blue Swirl <blauwirbel@gmail.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Stefan Hajnoczi <stefanha@gmail.com>,
tj@kernel.org, Roland Elek <elek.roland@gmail.com>,
Sebastian Herbszt <herbszt@gmx.de>
Subject: [Qemu-devel] [PATCH 10/11] ahci: spawn controller on demand
Date: Thu, 25 Nov 2010 08:07:41 +0100 [thread overview]
Message-ID: <1290668862-11695-11-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1290668862-11695-1-git-send-email-agraf@suse.de>
When we add a device using -drive to the guest, we also need to create a
new SATA bus to handle the device. This patch adds a function call that
every machine that likes to have IF_SATA support can call to get full
device creation by keeping the actual qdev code clean.
Signed-off-by: Alexander Graf <agraf@suse.de>
---
v2 -> v3:
- redesign
v4 -> v5:
- redesign to only use qdev in generic parts, get rid of
CONFIG_AHCI
---
blockdev.c | 35 +++++++++++++++++++++++++++++++++++
blockdev.h | 1 +
vl.c | 2 ++
3 files changed, 38 insertions(+), 0 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 5ce90cc..69befb6 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -499,6 +499,41 @@ DriveInfo *drive_init(QemuOpts *opts, int default_to_scsi, int *fatal_error)
return dinfo;
}
+static void ahci_post_init(void)
+{
+ int max_bus;
+ int bus, i;
+ QemuOpts *opts;
+ char name[32];
+
+ max_bus = drive_get_max_bus(IF_SATA);
+ for (bus = 0; bus <= max_bus; bus++) {
+ sprintf(name, "ahci-%d", bus);
+ opts = qemu_opts_create(qemu_find_opts("device"), name, 1);
+ qemu_opt_set(opts, "driver", "ahci");
+
+ for (i = 0; i < MAX_SATA_DEVS; i++) {
+ DriveInfo *dinfo = drive_get(IF_SATA, bus, i);
+
+ if (!dinfo) {
+ continue;
+ }
+
+ sprintf(name, "ahci-%d.%d", bus, i);
+ opts = qemu_opts_create(qemu_find_opts("device"), NULL, 0);
+ qemu_opt_set(opts, "driver", "ide-drive");
+ qemu_opt_set(opts, "unit", "0");
+ qemu_opt_set(opts, "bus", name);
+ qemu_opt_set(opts, "drive", dinfo->id);
+ }
+ }
+}
+
+void drive_post_init(void)
+{
+ ahci_post_init();
+}
+
void do_commit(Monitor *mon, const QDict *qdict)
{
const char *device = qdict_get_str(qdict, "device");
diff --git a/blockdev.h b/blockdev.h
index f50a15e..6db229a 100644
--- a/blockdev.h
+++ b/blockdev.h
@@ -42,6 +42,7 @@ DriveInfo *drive_get_by_blockdev(BlockDriverState *bs);
QemuOpts *drive_add(const char *file, const char *fmt, ...) GCC_FMT_ATTR(2, 3);
DriveInfo *drive_init(QemuOpts *arg, int default_to_scsi, int *fatal_error);
+void drive_post_init(void);
/* device-hotplug */
diff --git a/vl.c b/vl.c
index c58583d..1903040 100644
--- a/vl.c
+++ b/vl.c
@@ -2795,6 +2795,8 @@ int main(int argc, char **argv, char **envp)
if (qemu_opts_foreach(qemu_find_opts("drive"), drive_init_func, &machine->use_scsi, 1) != 0)
exit(1);
+ drive_post_init();
+
register_savevm_live(NULL, "ram", 0, 4, NULL, ram_save_live, NULL,
ram_load, NULL);
--
1.6.0.2
next prev parent reply other threads:[~2010-11-25 7:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-25 7:07 [Qemu-devel] [PATCH 00/11] AHCI emulation support v5 Alexander Graf
2010-11-25 7:07 ` [Qemu-devel] [PATCH 01/11] ide: split ide command interpretation off Alexander Graf
2010-11-25 7:07 ` [Qemu-devel] [PATCH 02/11] ide: fix whitespace gap in ide_exec_cmd Alexander Graf
2010-11-25 7:07 ` [Qemu-devel] [PATCH 03/11] ide: add support for ide bus ops Alexander Graf
2010-11-25 7:07 ` [Qemu-devel] [PATCH 04/11] ide: add DMA hooks to " Alexander Graf
2010-11-25 7:07 ` [Qemu-devel] [PATCH 05/11] ide: add ncq identify data for ahci sata drives Alexander Graf
2010-11-25 7:07 ` [Qemu-devel] [PATCH 06/11] pci: add storage class for sata Alexander Graf
2010-11-25 7:07 ` [Qemu-devel] [PATCH 07/11] pci: add ich7 pci id Alexander Graf
2010-11-25 7:07 ` [Qemu-devel] [PATCH 08/11] ahci: add ahci emulation Alexander Graf
2010-11-25 11:14 ` Isaku Yamahata
2010-11-25 7:07 ` [Qemu-devel] [PATCH 09/11] ahci: add -drive support Alexander Graf
2010-11-25 7:07 ` Alexander Graf [this message]
2010-11-26 18:21 ` [Qemu-devel] Re: [PATCH 10/11] ahci: spawn controller on demand Blue Swirl
2010-11-25 7:07 ` [Qemu-devel] [PATCH 11/11] ide: move pata specific parts to pata.c Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290668862-11695-11-git-send-email-agraf@suse.de \
--to=agraf@suse.de \
--cc=Joerg.Roedel@amd.com \
--cc=blauwirbel@gmail.com \
--cc=elek.roland@gmail.com \
--cc=herbszt@gmx.de \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).