qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: qemu-devel@nongnu.org
Cc: spice-devel@lists.freedesktop.org,
	Gerd Hoffmann <kraxel@redhat.com>,
	Hans de Goede <hdegoede@redhat.com>
Subject: [Qemu-devel] [PATCH 6/7] usb-linux: We only need to keep track of 15 endpoints
Date: Fri, 26 Nov 2010 19:13:22 +0100	[thread overview]
Message-ID: <1290795203-2597-6-git-send-email-hdegoede@redhat.com> (raw)
In-Reply-To: <1290795203-2597-1-git-send-email-hdegoede@redhat.com>

Currently we reserve room for endpoint data for 16 endpoints, but given
that we only use endpoint data for endpoints 1-15, and always index the
array with the endpoint-number - 1, 15 is enough.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 usb-linux.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/usb-linux.c b/usb-linux.c
index 5a979bd..9301084 100644
--- a/usb-linux.c
+++ b/usb-linux.c
@@ -78,7 +78,7 @@ typedef int USBScanFunc(void *opaque, int bus_num, int addr, int devpath,
 
 #define USBPROCBUS_PATH "/proc/bus/usb"
 #define PRODUCT_NAME_SZ 32
-#define MAX_ENDPOINTS 16
+#define MAX_ENDPOINTS 15
 #define USBDEVBUS_PATH "/dev/bus/usb"
 #define USBSYSBUS_PATH "/sys/bus/usb"
 
@@ -724,7 +724,7 @@ static int usb_host_set_interface(USBHostDevice *s, int iface, int alt)
     struct usbdevfs_setinterface si;
     int i, ret;
 
-    for (i = 1; i < MAX_ENDPOINTS; i++) {
+    for (i = 1; i <= MAX_ENDPOINTS; i++) {
         if (is_isoc(s, i)) {
             usb_host_stop_n_free_iso(s, i);
         }
@@ -1275,7 +1275,7 @@ static int usb_host_close(USBHostDevice *dev)
 
     qemu_set_fd_handler(dev->fd, NULL, NULL, NULL);
     dev->closing = 1;
-    for (i = 1; i < MAX_ENDPOINTS; i++) {
+    for (i = 1; i <= MAX_ENDPOINTS; i++) {
         if (is_isoc(dev, i)) {
             usb_host_stop_n_free_iso(dev, i);
         }
-- 
1.7.3.2

  parent reply	other threads:[~2010-11-26 18:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-26 18:13 [Qemu-devel] [PATCH 1/7] usb-linux: introduce a usb_linux_alt_setting function Hans de Goede
2010-11-26 18:13 ` [Qemu-devel] [PATCH 2/7] usb-linux: Get the alt. setting from sysfs rather then asking the dev Hans de Goede
2010-11-26 18:13 ` [Qemu-devel] [PATCH 3/7] usb-linux: Add support for buffering iso usb packets Hans de Goede
2010-11-26 18:13 ` [Qemu-devel] [PATCH 4/7] usb-linux: Refuse packets for endpoints which are not in the usb descriptor Hans de Goede
2010-11-26 18:13 ` [Qemu-devel] [PATCH 5/7] usb-linux: Refuse iso packets when max packet size is 0 (alt setting 0) Hans de Goede
2010-11-26 18:13 ` Hans de Goede [this message]
2010-11-26 18:13 ` [Qemu-devel] [PATCH 7/7] usb-linux: Add support for buffering iso out usb packets Hans de Goede
2010-12-09 13:16 ` [Qemu-devel] Re: [PATCH 1/7] usb-linux: introduce a usb_linux_alt_setting function Gerd Hoffmann
2010-12-15 11:50   ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1290795203-2597-6-git-send-email-hdegoede@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=spice-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).