From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=46032 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PNeVL-0007hb-LX for qemu-devel@nongnu.org; Tue, 30 Nov 2010 23:41:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PNRJh-0001oZ-HX for qemu-devel@nongnu.org; Tue, 30 Nov 2010 09:36:27 -0500 Received: from cantor.suse.de ([195.135.220.2]:55555 helo=mx1.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PNRJh-0000zH-Bc for qemu-devel@nongnu.org; Tue, 30 Nov 2010 09:36:25 -0500 From: Alexander Graf Date: Tue, 30 Nov 2010 15:35:50 +0100 Message-Id: <1291127761-16501-5-git-send-email-agraf@suse.de> In-Reply-To: <1291127761-16501-1-git-send-email-agraf@suse.de> References: <1291127761-16501-1-git-send-email-agraf@suse.de> Subject: [Qemu-devel] [PATCH 04/15] dbdma: Make little endian List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: QEMU-devel Developers Cc: Blue Swirl , Paul Brook The device is only used on big endian systems, but always byte swaps. That's a very good indicator that it's actually a little endian device ;-). Signed-off-by: Alexander Graf --- hw/mac_dbdma.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/hw/mac_dbdma.c b/hw/mac_dbdma.c index f449a59..5680fa9 100644 --- a/hw/mac_dbdma.c +++ b/hw/mac_dbdma.c @@ -707,8 +707,6 @@ static void dbdma_writel (void *opaque, DBDMA_DPRINTF("channel 0x%x reg 0x%x\n", (uint32_t)addr >> DBDMA_CHANNEL_SHIFT, reg); - value = bswap32(value); - /* cmdptr cannot be modified if channel is RUN or ACTIVE */ if (reg == DBDMA_CMDPTR_LO && @@ -788,7 +786,6 @@ static uint32_t dbdma_readl (void *opaque, target_phys_addr_t addr) break; } - value = bswap32(value); return value; } @@ -845,7 +842,7 @@ void* DBDMA_init (int *dbdma_mem_index) s = qemu_mallocz(sizeof(DBDMA_channel) * DBDMA_CHANNELS); *dbdma_mem_index = cpu_register_io_memory(dbdma_read, dbdma_write, s, - DEVICE_NATIVE_ENDIAN); + DEVICE_LITTLE_ENDIAN); register_savevm(NULL, "dbdma", -1, 1, dbdma_save, dbdma_load, s); qemu_register_reset(dbdma_reset, s); -- 1.6.0.2