From: Jes.Sorensen@redhat.com
To: kwolf@redhat.com
Cc: stefanha@linux.vnet.ibm.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v2 0/3] Cleanup qemu-img code
Date: Mon, 6 Dec 2010 09:17:33 +0100 [thread overview]
Message-ID: <1291623456-3826-1-git-send-email-Jes.Sorensen@redhat.com> (raw)
From: Jes Sorensen <Jes.Sorensen@redhat.com>
Hi,
These patches moves the handling of block help printing to shared
code, which allows the "?" detection to happen early in the parsing,
instead of half way down img_create() and img_convert(). I would like
to see this happen as I would like to pull some of the code out of
img_create() and into block.c so it can be shared with qemu and
qemu-img.
The formatting patch is solely because the third patch wanted to
change code next to the badly formatted code, and I didn't want to
pollute the patch with the formatting fixed.
The third patch fixes qemu-img to exit on detection of unknown options
instead of continuing with a potentially wrong set of arguments.
New in v2: Add missing free_option_parameters() and handle the help()
case in the general switch() statements for the getopt() output.
Cheers,
Jes
Jes Sorensen (3):
Consolidate printing of block driver options
Fix formatting and missing braces in qemu-img.c
Fail if detecting an unknown option
qemu-img.c | 132 ++++++++++++++++++++++++++++++++++++++++++++----------------
1 files changed, 97 insertions(+), 35 deletions(-)
--
1.7.3.2
next reply other threads:[~2010-12-06 8:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 8:17 Jes.Sorensen [this message]
2010-12-06 8:17 ` [Qemu-devel] [PATCH 1/3] Consolidate printing of block driver options Jes.Sorensen
2010-12-06 9:32 ` Stefan Hajnoczi
2010-12-06 10:20 ` Jes Sorensen
2010-12-06 10:37 ` Stefan Hajnoczi
2010-12-06 10:47 ` Jes Sorensen
2010-12-06 11:04 ` Stefan Hajnoczi
2010-12-06 8:17 ` [Qemu-devel] [PATCH 2/3] Fix formatting and missing braces in qemu-img.c Jes.Sorensen
2010-12-06 8:17 ` [Qemu-devel] [PATCH 3/3] Fail if detecting an unknown option Jes.Sorensen
2010-12-06 9:24 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291623456-3826-1-git-send-email-Jes.Sorensen@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).