From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=38822 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PPc0q-00032J-O9 for qemu-devel@nongnu.org; Mon, 06 Dec 2010 09:25:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PPc0o-0000Mi-Rz for qemu-devel@nongnu.org; Mon, 06 Dec 2010 09:25:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34776) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PPc0o-0000MX-Kg for qemu-devel@nongnu.org; Mon, 06 Dec 2010 09:25:54 -0500 From: Jes.Sorensen@redhat.com Date: Mon, 6 Dec 2010 15:25:33 +0100 Message-Id: <1291645540-9784-1-git-send-email-Jes.Sorensen@redhat.com> Subject: [Qemu-devel] [PATCH v3 0/7] Cleanup qemu-img code List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: kwolf@redhat.com Cc: stefanha@linux.vnet.ibm.com, qemu-devel@nongnu.org From: Jes Sorensen Hi, These patches applies a number of cleanups to qemu-img.c as well as a minor bug in qemu-malloc.c. The handling of block help printing is moved to shared code, which allows the "?" detection to happen early in the parsing, instead of half way down img_create() and img_convert(). I would like to see this happen as I would like to pull some of the code out of img_create() and into block.c so it can be shared with qemu and qemu-img. In addition there is a couple of patches to clean up the error handling in qemu-img.c and make it more consistent. The formatting patch is solely because the last patch wanted to change code next to the badly formatted code, and I didn't want to pollute the patch with the formatting fixed. The seventh patch fixes qemu-img to exit on detection of unknown options instead of continuing with a potentially wrong set of arguments. v3 applies a number of changes discussed on irc and email. This is the grow to seven from three patches series. Cheers, Jes Jes Sorensen (7): Add missing tracing to qemu_mallocz() Use qemu_mallocz() instead of calloc() in img_convert() img_convert(): Only try to free bs[] entries if bs is valid. Make error handling more consistent in img_create() and img_resize() Consolidate printing of block driver options Fix formatting and missing braces in qemu-img.c Fail if detecting an unknown option qemu-img.c | 162 +++++++++++++++++++++++++++++++++++++++----------------- qemu-malloc.c | 5 ++- 2 files changed, 117 insertions(+), 50 deletions(-) -- 1.7.3.2