From: Jes.Sorensen@redhat.com
To: kwolf@redhat.com
Cc: stefanha@linux.vnet.ibm.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 7/7] Fail if detecting an unknown option
Date: Mon, 6 Dec 2010 15:25:40 +0100 [thread overview]
Message-ID: <1291645540-9784-8-git-send-email-Jes.Sorensen@redhat.com> (raw)
In-Reply-To: <1291645540-9784-1-git-send-email-Jes.Sorensen@redhat.com>
From: Jes Sorensen <Jes.Sorensen@redhat.com>
This patch changes qemu-img to exit if an unknown option is detected,
instead of trying to continue with a set of arguments which may be
incorrect.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
---
qemu-img.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index d812db0..f021a06 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -309,6 +309,7 @@ static int img_create(int argc, char **argv)
break;
}
switch(c) {
+ case '?':
case 'h':
help();
break;
@@ -479,6 +480,7 @@ static int img_check(int argc, char **argv)
break;
}
switch(c) {
+ case '?':
case 'h':
help();
break;
@@ -557,6 +559,7 @@ static int img_commit(int argc, char **argv)
break;
}
switch(c) {
+ case '?':
case 'h':
help();
break;
@@ -695,6 +698,7 @@ static int img_convert(int argc, char **argv)
break;
}
switch(c) {
+ case '?':
case 'h':
help();
break;
@@ -1099,6 +1103,7 @@ static int img_info(int argc, char **argv)
break;
}
switch(c) {
+ case '?':
case 'h':
help();
break;
@@ -1176,6 +1181,7 @@ static int img_snapshot(int argc, char **argv)
break;
}
switch(c) {
+ case '?':
case 'h':
help();
return 0;
@@ -1291,6 +1297,7 @@ static int img_rebase(int argc, char **argv)
break;
}
switch(c) {
+ case '?':
case 'h':
help();
return 0;
@@ -1505,6 +1512,7 @@ static int img_resize(int argc, char **argv)
break;
}
switch(c) {
+ case '?':
case 'h':
help();
break;
--
1.7.3.2
next prev parent reply other threads:[~2010-12-06 14:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 14:25 [Qemu-devel] [PATCH v3 0/7] Cleanup qemu-img code Jes.Sorensen
2010-12-06 14:25 ` [Qemu-devel] [PATCH 1/7] Add missing tracing to qemu_mallocz() Jes.Sorensen
2010-12-06 14:42 ` [Qemu-devel] " Stefan Hajnoczi
2010-12-06 14:25 ` [Qemu-devel] [PATCH 2/7] Use qemu_mallocz() instead of calloc() in img_convert() Jes.Sorensen
2010-12-06 14:43 ` [Qemu-devel] " Stefan Hajnoczi
2010-12-06 14:25 ` [Qemu-devel] [PATCH 3/7] img_convert(): Only try to free bs[] entries if bs is valid Jes.Sorensen
2010-12-06 14:44 ` [Qemu-devel] " Stefan Hajnoczi
2010-12-06 14:25 ` [Qemu-devel] [PATCH 4/7] Make error handling more consistent in img_create() and img_resize() Jes.Sorensen
2010-12-06 14:58 ` [Qemu-devel] " Stefan Hajnoczi
2010-12-06 15:25 ` Kevin Wolf
2010-12-06 15:32 ` Jes Sorensen
2010-12-06 14:25 ` [Qemu-devel] [PATCH 5/7] Consolidate printing of block driver options Jes.Sorensen
2010-12-06 14:59 ` [Qemu-devel] " Stefan Hajnoczi
2010-12-06 14:25 ` [Qemu-devel] [PATCH 6/7] Fix formatting and missing braces in qemu-img.c Jes.Sorensen
2010-12-06 15:00 ` [Qemu-devel] " Stefan Hajnoczi
2010-12-06 14:25 ` Jes.Sorensen [this message]
2010-12-06 15:02 ` [Qemu-devel] Re: [PATCH 7/7] Fail if detecting an unknown option Stefan Hajnoczi
2010-12-06 15:33 ` [Qemu-devel] Re: [PATCH v3 0/7] Cleanup qemu-img code Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291645540-9784-8-git-send-email-Jes.Sorensen@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).