From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: Riku Voipio <riku.voipio@iki.fi>,
Wolfgang Schildbach <wschi@dolby.com>,
Nathan Froyd <froydnj@codesourcery.com>
Subject: [Qemu-devel] [PATCH 2/2] Remove dead code for ARM semihosting commandline handling
Date: Mon, 6 Dec 2010 15:06:06 +0000 [thread overview]
Message-ID: <1291647966-29220-3-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1291647966-29220-1-git-send-email-peter.maydell@linaro.org>
From: Wolfgang Schildbach <wschi@dolby.com>
There are some bits in the code which were used to store the commandline for
the semihosting call. These bits are now write-only and can be removed.
Signed-off-by: Wolfgang Schildbach <wschi@dolby.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
---
bsd-user/bsdload.c | 2 --
bsd-user/qemu.h | 1 -
linux-user/linuxload.c | 2 --
linux-user/qemu.h | 1 -
4 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/bsd-user/bsdload.c b/bsd-user/bsdload.c
index 14a93bf..6d9bb6f 100644
--- a/bsd-user/bsdload.c
+++ b/bsd-user/bsdload.c
@@ -176,8 +176,6 @@ int loader_exec(const char * filename, char ** argv, char ** envp,
retval = prepare_binprm(&bprm);
- infop->host_argv = argv;
-
if(retval>=0) {
if (bprm.buf[0] == 0x7f
&& bprm.buf[1] == 'E'
diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h
index 9763616..e343894 100644
--- a/bsd-user/qemu.h
+++ b/bsd-user/qemu.h
@@ -50,7 +50,6 @@ struct image_info {
abi_ulong entry;
abi_ulong code_offset;
abi_ulong data_offset;
- char **host_argv;
int personality;
};
diff --git a/linux-user/linuxload.c b/linux-user/linuxload.c
index 9ee27c3..ac8c486 100644
--- a/linux-user/linuxload.c
+++ b/linux-user/linuxload.c
@@ -174,8 +174,6 @@ int loader_exec(const char * filename, char ** argv, char ** envp,
retval = prepare_binprm(bprm);
- infop->host_argv = argv;
-
if(retval>=0) {
if (bprm->buf[0] == 0x7f
&& bprm->buf[1] == 'E'
diff --git a/linux-user/qemu.h b/linux-user/qemu.h
index e66a02b..32de241 100644
--- a/linux-user/qemu.h
+++ b/linux-user/qemu.h
@@ -50,7 +50,6 @@ struct image_info {
abi_ulong saved_auxv;
abi_ulong arg_start;
abi_ulong arg_end;
- char **host_argv;
int personality;
};
--
1.6.3.3
next prev parent reply other threads:[~2010-12-06 15:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 15:06 [Qemu-devel] [PATCH 0/2] ARM: fix commandline handling for semihosted executables Peter Maydell
2010-12-06 15:06 ` [Qemu-devel] [PATCH 1/2] Fix commandline handling for ARM " Peter Maydell
2010-12-06 15:06 ` Peter Maydell [this message]
2010-12-23 12:58 ` [Qemu-devel] [PATCH 0/2] ARM: fix commandline handling forsemihosted executables Schildbach, Wolfgang
2010-12-23 14:09 ` Peter Maydell
2011-01-07 15:34 ` riku voipio
2011-01-07 15:46 ` Schildbach, Wolfgang
2011-01-07 15:56 ` Peter Maydell
2011-01-07 16:29 ` riku voipio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291647966-29220-3-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=froydnj@codesourcery.com \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=wschi@dolby.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).