qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 08/10] ARM: Ignore top 16 bits when doing VCVT from 16 bit fixed point
Date: Mon,  6 Dec 2010 17:00:09 +0000	[thread overview]
Message-ID: <1291654811-29863-9-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1291654811-29863-1-git-send-email-peter.maydell@linaro.org>

VCVT of 16 bit fixed point to float should ignore the top 16 bits
of the source register. Cast to int16_t and friends rather than
int16 -- the former is guaranteed exactly 16 bits wide where the
latter is merely at least 16 bits wide (and so is usually 32 bits).

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Nathan Froyd <froydnj@codesourcery.com>
---
 target-arm/helper.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/target-arm/helper.c b/target-arm/helper.c
index 4bd1cd4..2925782 100644
--- a/target-arm/helper.c
+++ b/target-arm/helper.c
@@ -2549,7 +2549,7 @@ float32 VFP_HELPER(fcvts, d)(float64 x, CPUState *env)
 ftype VFP_HELPER(name##to, p)(ftype x, uint32_t shift, CPUState *env) \
 { \
     ftype tmp; \
-    tmp = sign##int32_to_##ftype ((itype)vfp_##p##toi(x), \
+    tmp = sign##int32_to_##ftype ((itype##_t)vfp_##p##toi(x), \
                                   &env->vfp.fp_status); \
     return ftype##_scalbn(tmp, -(int)shift, &env->vfp.fp_status); \
 } \
-- 
1.6.3.3

  parent reply	other threads:[~2010-12-06 17:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-06 17:00 [Qemu-devel] [PATCH V2 00/10] ARM: fix VCVT instructions Peter Maydell
2010-12-06 17:00 ` [Qemu-devel] [PATCH 01/10] ARM: Fix decoding of VFP forms of VCVT between float and int/fixed Peter Maydell
2010-12-06 17:00 ` [Qemu-devel] [PATCH 02/10] ARM: Fix decoding of Neon forms of VCVT between float and fixed point Peter Maydell
2010-12-06 17:00 ` [Qemu-devel] [PATCH 03/10] ARM: Fix sense of to_integer bit in Neon VCVT float/int conversion Peter Maydell
2010-12-06 17:00 ` [Qemu-devel] [PATCH 04/10] softfloat: Add float*_is_any_nan() functions Peter Maydell
2010-12-06 18:15   ` Nathan Froyd
2010-12-06 17:00 ` [Qemu-devel] [PATCH 05/10] ARM: Return correct result for float-to-integer conversion of NaN Peter Maydell
2010-12-06 18:18   ` Nathan Froyd
2010-12-06 17:00 ` [Qemu-devel] [PATCH 06/10] softfloat: Add float*_maybe_silence_nan() functions Peter Maydell
2010-12-06 18:16   ` Nathan Froyd
2010-12-06 17:00 ` [Qemu-devel] [PATCH 07/10] ARM: Return correct result for single<->double conversion of NaN Peter Maydell
2010-12-06 18:17   ` Nathan Froyd
2010-12-06 17:00 ` Peter Maydell [this message]
2010-12-06 17:00 ` [Qemu-devel] [PATCH 09/10] softfloat: Add float/double to 16 bit integer conversion functions Peter Maydell
2010-12-06 17:00 ` [Qemu-devel] [PATCH 10/10] ARM: Implement VCVT to 16 bit integer using new softfloat routines Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1291654811-29863-9-git-send-email-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).