From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, armbru@redhat.com
Subject: [Qemu-devel] [PATCH v1 00/25]: Monitor: First step on an internal QMP API
Date: Mon, 6 Dec 2010 16:23:47 -0200 [thread overview]
Message-ID: <1291659852-23028-1-git-send-email-lcapitulino@redhat.com> (raw)
Today, when writing an info command that is used by QMP and HMP, the
programmer has to implement:
1. The handler itself, that's the function that gathers data and
returns it as QObjects
2. A pretty printing function, which is called by the human monitor
to print the returned QObjects in human readable form
However, we want to have a clean separation between QMP and the human
monitor. Actually, we want to turn QMP into an internal API and the
human monitor should be written on top of that.
So, this series does:
1. Move all QMP calling code to the info handler using it, that's
we change the pretty printing function to call QMP and turn it
into an info handler
2. Drop all QMP calling code from do_info()
Please, note that this is only done for info handlers. Command handlers
will take a bit more time to be converted.
balloon.c | 26 +-----
balloon.h | 2 +-
block.c | 16 ++-
block.h | 8 +-
console.h | 8 +-
hw/pci.c | 9 ++-
hw/pci.h | 4 +-
input.c | 11 ++-
migration.c | 13 ++-
migration.h | 4 +-
monitor.c | 341 +++++++++++++++++++++++++++--------------------------------
qemu-char.c | 10 ++-
qemu-char.h | 4 +-
ui/vnc.c | 11 ++-
14 files changed, 227 insertions(+), 240 deletions(-)
next reply other threads:[~2010-12-06 18:24 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 18:23 Luiz Capitulino [this message]
2010-12-06 18:23 ` [Qemu-devel] [PATCH 01/25] QMP: Rename query handlers Luiz Capitulino
2010-12-07 12:28 ` Miguel Di Ciurcio Filho
2010-12-07 13:15 ` Luiz Capitulino
2010-12-06 18:23 ` [Qemu-devel] [PATCH 02/25] QMP: Drop user_print usage from the qmp_query_cmds[] table Luiz Capitulino
2010-12-06 18:23 ` [Qemu-devel] [PATCH 03/25] Monitor: Drop balloon handlers comments Luiz Capitulino
2010-12-06 18:23 ` [Qemu-devel] [PATCH 04/25] Monitor: Move qmp_query_version() up in monitor.c Luiz Capitulino
2010-12-06 18:23 ` [Qemu-devel] [PATCH 05/25] Monitor: Convert do_info_version_print() into do_info_version() Luiz Capitulino
2010-12-06 18:23 ` [Qemu-devel] [PATCH 06/25] Monitor: Convert qemu_chr_info_print() into qemu_chr_info() Luiz Capitulino
2010-12-06 18:23 ` [Qemu-devel] [PATCH 07/25] Monitor: Convert bdrv_info_print() into bdrv_info() Luiz Capitulino
2010-12-06 18:23 ` [Qemu-devel] [PATCH 08/25] Monitor: Convert bdrv_stats_print() into bdrv_stats() Luiz Capitulino
2010-12-06 18:23 ` [Qemu-devel] [PATCH 09/25] Monitor: Move qmp_query_cpus() up in monitor.c Luiz Capitulino
2010-12-06 18:23 ` [Qemu-devel] [PATCH 10/25] Monitor: Convert monitor_print_cpus() into do_info_cpus() Luiz Capitulino
2010-12-06 18:23 ` [Qemu-devel] [PATCH 11/25] Monitor: Convert do_pci_info_print() into do_pci_info() Luiz Capitulino
2010-12-06 18:23 ` [Qemu-devel] [PATCH 12/25] Monitor: Move qmp_query_kvm() up in monitor.c Luiz Capitulino
2010-12-06 18:24 ` [Qemu-devel] [PATCH 13/25] Monitor: Convert do_info_kvm_print() into do_info_kvm() Luiz Capitulino
2010-12-06 18:24 ` [Qemu-devel] [PATCH 14/25] Monitor: Move qmp_query_status() up in monitor.c Luiz Capitulino
2010-12-06 18:24 ` [Qemu-devel] [PATCH 15/25] Monitor: Convert do_info_status_print() into do_info_status() Luiz Capitulino
2010-12-06 18:24 ` [Qemu-devel] [PATCH 16/25] Monitor: Convert do_info_mice_print() into do_info_mice() Luiz Capitulino
2010-12-06 18:24 ` [Qemu-devel] [PATCH 17/25] Monitor: Convert do_info_vnc_print() into do_info_vnc() Luiz Capitulino
2010-12-06 18:24 ` [Qemu-devel] [PATCH 18/25] Monitor: Move qmp_query_name() up in monitor.c Luiz Capitulino
2010-12-06 18:24 ` [Qemu-devel] [PATCH 19/25] Monitor: Convert do_info_name_print() into do_info_name() Luiz Capitulino
2010-12-06 18:24 ` [Qemu-devel] [PATCH 20/25] Monitor: Move qmp_query_uuid() up in monitor.c Luiz Capitulino
2010-12-06 18:24 ` [Qemu-devel] [PATCH 21/25] Monitor: Convert do_info_uuid_print() into do_info_uuid() Luiz Capitulino
2010-12-06 18:24 ` [Qemu-devel] [PATCH 22/25] Monitor: qmp_query_migrate(): Return {} for empty MigrationState Luiz Capitulino
2010-12-06 18:24 ` [Qemu-devel] [PATCH 23/25] Monitor: Convert do_info_migrate_print() into do_info_migrate() Luiz Capitulino
2010-12-06 18:24 ` [Qemu-devel] [PATCH 24/25] Monitor: Introduce do_info_balloon() Luiz Capitulino
2010-12-06 18:24 ` [Qemu-devel] [PATCH 25/25] Monitor: do_info(): Drop unused code Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291659852-23028-1-git-send-email-lcapitulino@redhat.com \
--to=lcapitulino@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).