From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, armbru@redhat.com
Subject: [Qemu-devel] [PATCH 09/25] Monitor: Move qmp_query_cpus() up in monitor.c
Date: Mon, 6 Dec 2010 16:23:56 -0200 [thread overview]
Message-ID: <1291659852-23028-10-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1291659852-23028-1-git-send-email-lcapitulino@redhat.com>
So that next commit can change monitor_print_cpus() to call it.
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
monitor.c | 78 ++++++++++++++++++++++++++++++------------------------------
1 files changed, 39 insertions(+), 39 deletions(-)
diff --git a/monitor.c b/monitor.c
index 3091a1a..f067d07 100644
--- a/monitor.c
+++ b/monitor.c
@@ -854,6 +854,45 @@ static void do_info_registers(Monitor *mon)
#endif
}
+static void qmp_query_cpus(Monitor *mon, QObject **ret_data)
+{
+ CPUState *env;
+ QList *cpu_list;
+
+ cpu_list = qlist_new();
+
+ /* just to set the default cpu if not already done */
+ mon_get_cpu();
+
+ for(env = first_cpu; env != NULL; env = env->next_cpu) {
+ QDict *cpu;
+ QObject *obj;
+
+ cpu_synchronize_state(env);
+
+ obj = qobject_from_jsonf("{ 'CPU': %d, 'current': %i, 'halted': %i }",
+ env->cpu_index, env == mon->mon_cpu,
+ env->halted);
+
+ cpu = qobject_to_qdict(obj);
+
+#if defined(TARGET_I386)
+ qdict_put(cpu, "pc", qint_from_int(env->eip + env->segs[R_CS].base));
+#elif defined(TARGET_PPC)
+ qdict_put(cpu, "nip", qint_from_int(env->nip));
+#elif defined(TARGET_SPARC)
+ qdict_put(cpu, "pc", qint_from_int(env->pc));
+ qdict_put(cpu, "npc", qint_from_int(env->npc));
+#elif defined(TARGET_MIPS)
+ qdict_put(cpu, "PC", qint_from_int(env->active_tc.PC));
+#endif
+
+ qlist_append(cpu_list, cpu);
+ }
+
+ *ret_data = QOBJECT(cpu_list);
+}
+
static void print_cpu_iter(QObject *obj, void *opaque)
{
QDict *cpu;
@@ -901,45 +940,6 @@ static void monitor_print_cpus(Monitor *mon, const QObject *data)
qlist_iter(cpu_list, print_cpu_iter, mon);
}
-static void qmp_query_cpus(Monitor *mon, QObject **ret_data)
-{
- CPUState *env;
- QList *cpu_list;
-
- cpu_list = qlist_new();
-
- /* just to set the default cpu if not already done */
- mon_get_cpu();
-
- for(env = first_cpu; env != NULL; env = env->next_cpu) {
- QDict *cpu;
- QObject *obj;
-
- cpu_synchronize_state(env);
-
- obj = qobject_from_jsonf("{ 'CPU': %d, 'current': %i, 'halted': %i }",
- env->cpu_index, env == mon->mon_cpu,
- env->halted);
-
- cpu = qobject_to_qdict(obj);
-
-#if defined(TARGET_I386)
- qdict_put(cpu, "pc", qint_from_int(env->eip + env->segs[R_CS].base));
-#elif defined(TARGET_PPC)
- qdict_put(cpu, "nip", qint_from_int(env->nip));
-#elif defined(TARGET_SPARC)
- qdict_put(cpu, "pc", qint_from_int(env->pc));
- qdict_put(cpu, "npc", qint_from_int(env->npc));
-#elif defined(TARGET_MIPS)
- qdict_put(cpu, "PC", qint_from_int(env->active_tc.PC));
-#endif
-
- qlist_append(cpu_list, cpu);
- }
-
- *ret_data = QOBJECT(cpu_list);
-}
-
static int do_cpu_set(Monitor *mon, const QDict *qdict, QObject **ret_data)
{
int index = qdict_get_int(qdict, "index");
--
1.7.3.3.398.g0b0cd
next prev parent reply other threads:[~2010-12-06 18:24 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 18:23 [Qemu-devel] [PATCH v1 00/25]: Monitor: First step on an internal QMP API Luiz Capitulino
2010-12-06 18:23 ` [Qemu-devel] [PATCH 01/25] QMP: Rename query handlers Luiz Capitulino
2010-12-07 12:28 ` Miguel Di Ciurcio Filho
2010-12-07 13:15 ` Luiz Capitulino
2010-12-06 18:23 ` [Qemu-devel] [PATCH 02/25] QMP: Drop user_print usage from the qmp_query_cmds[] table Luiz Capitulino
2010-12-06 18:23 ` [Qemu-devel] [PATCH 03/25] Monitor: Drop balloon handlers comments Luiz Capitulino
2010-12-06 18:23 ` [Qemu-devel] [PATCH 04/25] Monitor: Move qmp_query_version() up in monitor.c Luiz Capitulino
2010-12-06 18:23 ` [Qemu-devel] [PATCH 05/25] Monitor: Convert do_info_version_print() into do_info_version() Luiz Capitulino
2010-12-06 18:23 ` [Qemu-devel] [PATCH 06/25] Monitor: Convert qemu_chr_info_print() into qemu_chr_info() Luiz Capitulino
2010-12-06 18:23 ` [Qemu-devel] [PATCH 07/25] Monitor: Convert bdrv_info_print() into bdrv_info() Luiz Capitulino
2010-12-06 18:23 ` [Qemu-devel] [PATCH 08/25] Monitor: Convert bdrv_stats_print() into bdrv_stats() Luiz Capitulino
2010-12-06 18:23 ` Luiz Capitulino [this message]
2010-12-06 18:23 ` [Qemu-devel] [PATCH 10/25] Monitor: Convert monitor_print_cpus() into do_info_cpus() Luiz Capitulino
2010-12-06 18:23 ` [Qemu-devel] [PATCH 11/25] Monitor: Convert do_pci_info_print() into do_pci_info() Luiz Capitulino
2010-12-06 18:23 ` [Qemu-devel] [PATCH 12/25] Monitor: Move qmp_query_kvm() up in monitor.c Luiz Capitulino
2010-12-06 18:24 ` [Qemu-devel] [PATCH 13/25] Monitor: Convert do_info_kvm_print() into do_info_kvm() Luiz Capitulino
2010-12-06 18:24 ` [Qemu-devel] [PATCH 14/25] Monitor: Move qmp_query_status() up in monitor.c Luiz Capitulino
2010-12-06 18:24 ` [Qemu-devel] [PATCH 15/25] Monitor: Convert do_info_status_print() into do_info_status() Luiz Capitulino
2010-12-06 18:24 ` [Qemu-devel] [PATCH 16/25] Monitor: Convert do_info_mice_print() into do_info_mice() Luiz Capitulino
2010-12-06 18:24 ` [Qemu-devel] [PATCH 17/25] Monitor: Convert do_info_vnc_print() into do_info_vnc() Luiz Capitulino
2010-12-06 18:24 ` [Qemu-devel] [PATCH 18/25] Monitor: Move qmp_query_name() up in monitor.c Luiz Capitulino
2010-12-06 18:24 ` [Qemu-devel] [PATCH 19/25] Monitor: Convert do_info_name_print() into do_info_name() Luiz Capitulino
2010-12-06 18:24 ` [Qemu-devel] [PATCH 20/25] Monitor: Move qmp_query_uuid() up in monitor.c Luiz Capitulino
2010-12-06 18:24 ` [Qemu-devel] [PATCH 21/25] Monitor: Convert do_info_uuid_print() into do_info_uuid() Luiz Capitulino
2010-12-06 18:24 ` [Qemu-devel] [PATCH 22/25] Monitor: qmp_query_migrate(): Return {} for empty MigrationState Luiz Capitulino
2010-12-06 18:24 ` [Qemu-devel] [PATCH 23/25] Monitor: Convert do_info_migrate_print() into do_info_migrate() Luiz Capitulino
2010-12-06 18:24 ` [Qemu-devel] [PATCH 24/25] Monitor: Introduce do_info_balloon() Luiz Capitulino
2010-12-06 18:24 ` [Qemu-devel] [PATCH 25/25] Monitor: do_info(): Drop unused code Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291659852-23028-10-git-send-email-lcapitulino@redhat.com \
--to=lcapitulino@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).