From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=35081 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PPjEo-00089T-Lt for qemu-devel@nongnu.org; Mon, 06 Dec 2010 17:08:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PPjEl-0005Gg-JQ for qemu-devel@nongnu.org; Mon, 06 Dec 2010 17:08:50 -0500 Received: from e6.ny.us.ibm.com ([32.97.182.146]:48373) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PPjEl-0005Gc-Fe for qemu-devel@nongnu.org; Mon, 06 Dec 2010 17:08:47 -0500 Received: from d01dlp02.pok.ibm.com (d01dlp02.pok.ibm.com [9.56.224.85]) by e6.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id oB6MA1xa006466 for ; Mon, 6 Dec 2010 17:10:01 -0500 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 9ADA34DE803E for ; Mon, 6 Dec 2010 17:06:52 -0500 (EST) Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id oB6M8fin416516 for ; Mon, 6 Dec 2010 17:08:41 -0500 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id oB6M8eEW025194 for ; Mon, 6 Dec 2010 15:08:40 -0700 From: Adam Litke In-Reply-To: <1291399402-20366-9-git-send-email-mdroth@linux.vnet.ibm.com> References: <1291399402-20366-1-git-send-email-mdroth@linux.vnet.ibm.com> <1291399402-20366-9-git-send-email-mdroth@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" Date: Mon, 06 Dec 2010 16:08:39 -0600 Message-ID: <1291673319.2213.8.camel@aglitke> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [RFC][PATCH v5 08/21] virtagent: add agent_viewfile qmp/hmp command List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: agl@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com, Jes.Sorensen@redhat.com, qemu-devel@nongnu.org, aliguori@linux.vnet.ibm.com, ryanh@us.ibm.com, abeekhof@redhat.com On Fri, 2010-12-03 at 12:03 -0600, Michael Roth wrote: > Utilize the getfile RPC to provide a means to view text files in the > guest. Getfile can handle binary files as well but we don't advertise > that here due to the special handling requiring to store it and provide > it back to the user (base64 encoding it for instance). Hence the > otherwise confusing "viewfile" as opposed to "getfile". What happens to the monitor if you use this to view a binary file? Retrieving binary files progmatically using the QMP interface is a valid use case right? If so, I don't think it makes sense to introduce confusion by renaming the rpc function from getfile to viewfile when we are just exposing the getfile interface. -- Thanks, Adam