From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=55455 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PPjV2-0007t2-2x
	for qemu-devel@nongnu.org; Mon, 06 Dec 2010 17:25:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agl@us.ibm.com>) id 1PPjV0-0000Gh-UP
	for qemu-devel@nongnu.org; Mon, 06 Dec 2010 17:25:35 -0500
Received: from e38.co.us.ibm.com ([32.97.110.159]:39499)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agl@us.ibm.com>) id 1PPjV0-0000GN-Lk
	for qemu-devel@nongnu.org; Mon, 06 Dec 2010 17:25:34 -0500
Received: from d03relay05.boulder.ibm.com (d03relay05.boulder.ibm.com
	[9.17.195.107])
	by e38.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id oB6NH3iY006545
	for <qemu-devel@nongnu.org>; Mon, 6 Dec 2010 16:17:03 -0700
Received: from d03av06.boulder.ibm.com (d03av06.boulder.ibm.com [9.17.195.245])
	by d03relay05.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	oB6MPTPV142938
	for <qemu-devel@nongnu.org>; Mon, 6 Dec 2010 15:25:29 -0700
Received: from d03av06.boulder.ibm.com (loopback [127.0.0.1])
	by d03av06.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP
	id oB6MTfck003777
	for <qemu-devel@nongnu.org>; Mon, 6 Dec 2010 15:29:41 -0700
From: Adam Litke <agl@us.ibm.com>
In-Reply-To: <1291399402-20366-10-git-send-email-mdroth@linux.vnet.ibm.com>
References: <1291399402-20366-1-git-send-email-mdroth@linux.vnet.ibm.com>
	<1291399402-20366-10-git-send-email-mdroth@linux.vnet.ibm.com>
Content-Type: text/plain; charset="UTF-8"
Date: Mon, 06 Dec 2010 16:25:27 -0600
Message-ID: <1291674327.2213.9.camel@aglitke>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [RFC][PATCH v5 09/21] virtagent: add va.getdmesg
	RPC
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: agl@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com, Jes.Sorensen@redhat.com, qemu-devel@nongnu.org, aliguori@linux.vnet.ibm.com, ryanh@us.ibm.com, abeekhof@redhat.com

On Fri, 2010-12-03 at 12:03 -0600, Michael Roth wrote:
> +/* va_getdmesg(): return dmesg output
> + * rpc return values:
> + *   - dmesg output as a string
> + */
> +static xmlrpc_value *va_getdmesg(xmlrpc_env *env,
> +                              xmlrpc_value *param,
> +                              void *user_data)
> +{
> +    char *dmesg_buf = NULL, cmd[256];
> +    int ret;
> +    xmlrpc_value *result = NULL;
> +    FILE *pipe;
> +
> +    SLOG("va_getdmesg()");
> +
> +    dmesg_buf = qemu_mallocz(VA_DMESG_LEN + 2048);
> +    sprintf(cmd, "dmesg -s %d", VA_DMESG_LEN);
> +
> +    pipe = popen(cmd, "r");
> +    if (pipe == NULL) {
> +        LOG("popen failed: %s", strerror(errno));
> +        xmlrpc_faultf(env, "popen failed: %s", strerror(errno));
> +        goto EXIT_NOCLOSE;
> +    }
> +
> +    ret = fread(dmesg_buf, sizeof(char), VA_DMESG_LEN, pipe);
> +    if (!ferror(pipe)) {
> +        dmesg_buf[ret] = '\0';
> +        TRACE("dmesg:\n%s", dmesg_buf);
> +        result = xmlrpc_build_value(env, "s", dmesg_buf);
> +    } else {
> +        LOG("fread failed");
> +        xmlrpc_faultf(env, "popen failed: %s", strerror(errno));
> +    }
> +
> +    pclose(pipe);
> +EXIT_NOCLOSE:

I think goto labels are supposed to be lower-case.

-- 
Thanks,
Adam